B2G Updates: Display "No updates found" message during Force Update check

RESOLVED FIXED

Status

defect
P1
critical
RESOLVED FIXED
7 years ago
7 years ago

People

(Reporter: tchung, Assigned: marshall)

Tracking

unspecified
ARM
Gonk (Firefox OS)
Dependency tree / graph

Firefox Tracking Flags

(blocking-basecamp:+, firefox18 fixed, firefox19 fixed)

Details

(Whiteboard: [dogfooding-blocker])

Attachments

(1 attachment)

+++ This bug was initially created as a clone of Bug #798948 +++

Need text displayed if an update is not available.  Right not, tapping Check now does send a request in logcat, but nothing is shown to the User if no updates are found.

Logcat:
10-15 10:32:51.510: E/GeckoConsole(455): AUS:SVC Checker:checkForUpdates - sending request to: http://update.boot2gecko.org/nightly/update.xml?force=1
10-15 10:32:51.510: I/GeckoDump(455): XXX FIXME : Got a mozContentEvent: force-update-check


Repro:
1) install 10-15-2012 unagi nightly build
** Gaia: 589c7f8f7df88766f7a5fa944f6bb05eef04b8c3
** Gecko: 1ec4bdea9de7c0567810fd09cb55b02304b3186d
2) settings > Device information > Software Updates > tap "Check Now"
3) Verify if no updates are available (because you're on a latest build), there's no error shown on the UI indicating nothing is found.   

Expected:
- when force update checking, and no updates found, display "No updates found" on the device someplace

Actual:
- no messages for "No updates Found" when force checking for updates
Summary: B2G Updates: Implement "force update check" → B2G Updates: Display "No updates found" message during Force Update check
Severity: major → normal
Priority: P1 → --
Assignee: nobody → marshall
blocking-basecamp: ? → +
In Josh's UX document, errors from a manual check show up in a pop-up message banner on the bottom of the screen.

@etienne Do you know if Gaia supports these kinds of banners? If not maybe we can just add a status message area in the settings page.
Assignee: marshall → nobody
blocking-basecamp: + → ?
Argh, accidentally cleared blocking-basecamp+. Can someone with powers greater than me change this back?
Assignee: nobody → marshall
blocking-basecamp: ? → +
Whiteboard: ota update → ota update [dogfooding-blocker]
Whiteboard: ota update [dogfooding-blocker] → ota update, [dogfooding-blocker]
adding severity P1 and importance: critical to get onto the dogfood-blocking bug query radar.
Severity: normal → critical
Priority: -- → P1
Whiteboard: ota update, [dogfooding-blocker] → [dogfooding-blocker]
What is the status here?
Blocks: 801987
Blocks: 802016
This uses a mozChromeEvent to notify of fatal errors, and a setting to notify of
non-fatal errors or completion.
Attachment #671919 - Flags: review?(fabrice)
Comment on attachment 671919 [details] [diff] [review]
update errors and status - v1

Review of attachment 671919 [details] [diff] [review]:
-----------------------------------------------------------------

r=me

::: b2g/components/UpdatePrompt.js
@@ +30,1 @@
>  

Nit: remove blank line.

@@ +42,5 @@
>                                     "nsIIdleService");
>  
> +XPCOMUtils.defineLazyServiceGetter(Services, "settings",
> +                                   "@mozilla.org/settingsService;1",
> +                                   "nsISettingsService");

Nit: add blank line ;)

Also, we usually don't add new fields to the "Services" object. I'm ok to clean that in a follow up.
Attachment #671919 - Flags: review?(fabrice) → review+
Depends on: 802373
Verified fix on 10-17-2012 unagi.  message now shows "This is already the latest version of Firefox OS"

** Gaia: e3efbd0411
BuildID=2012101708343

logcat: 
10-17 10:31:23.919: E/GeckoConsole(2038): AUS:SVC Checker:getUpdateURL - update URL: http://update.boot2gecko.org/stable/update.xml?force=1
10-17 10:31:23.919: I/Gecko(2038): *** AUS:SVC Checker:onLoad - number of updates available: 1
10-17 10:31:23.919: E/GeckoConsole(2038): AUS:SVC Checker:onLoad - number of updates available: 1
10-17 10:31:23.929: I/Gecko(2038): *** AUS:SVC UpdateService:selectUpdate - skipping update because the update's application version is less than the current application version
10-17 10:31:23.929: E/GeckoConsole(2038): AUS:SVC UpdateService:selectUpdate - skipping update because the update's application version is less than the current application version
https://hg.mozilla.org/mozilla-central/rev/e7497bc33b3c
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.