801987 - [OTA update] system notification never reappears after dismissing "Later" and then force updating

Status: VERIFIED FIXED

(Firefox OS Graveyard :: General, defect, P1)

Description

[Tony Chung [:tchung]]

The system update notification never reappears if you defer to "Later", and then try to do a force update check again.  however, aus:svc does find the update on the server.

Dogfood blocker, as you can't apply the update if there's not Gaia system update notification to press.

logcat: 
10-15 19:24:23.929: I/Gecko(1015): UpdatePrompt: Forcing update check
10-15 19:24:23.949: I/Gecko(1015): *** AUS:SVC Checker:getUpdateURL - update URL: http://update.boot2gecko.org/nightly/update.xml?force=1
10-15 19:24:23.949: E/GeckoConsole(1015): AUS:SVC Checker:getUpdateURL - update URL: http://update.boot2gecko.org/nightly/update.xml?force=1
10-15 19:24:23.959: I/Gecko(1015): *** AUS:SVC Checker:checkForUpdates - sending request to: http://update.boot2gecko.org/nightly/update.xml?force=1
10-15 19:24:23.959: E/GeckoConsole(1015): AUS:SVC Checker:checkForUpdates - sending request to: http://update.boot2gecko.org/nightly/update.xml?force=1
10-15 19:24:23.959: I/GeckoDump(1015): XXX FIXME : Got a mozContentEvent: force-update-check


Repro:
1) install 10-15-2012 unagi nightly build
** Gaia: 589c7f8f7df88766f7a5fa944f6bb05eef04b8c3
** Gecko: 1ec4bdea9de7c0567810fd09cb55b02304b3186d
2) settings > Device information > Software Updates > tap "Check Now"
3) Notice the system Update notification appears.  Tap it
4) A confirmation overlay asks to Install Now or "Later".  Choose Later.
5) Go back to settings > and tap the force update check again.
6) Verify no system notifcation appears anymore, despite AUS:svc finding the update is available in logcat.

Expected:
- Force update should always show the system update notification, despite dismissing it earlier via "Later"

Actual:
- not update notification appears.   And without it, you can't update in gaia.

Comment 1

[Lukas Blakk [:lsblakk] use ?needinfo]

Marshall, are you the right person for this one? If not please pass on to whomever is.

Comment 2

[Marshall Culpepper [:marshall_law]]

This might have to do with nsUpdateService not prompting when there is already an active update:
http://dxr.mozilla.org/mozilla-central/toolkit/mozapps/update/nsUpdateService.js#l1927

Fabrice, can you take a look this?

Comment 3

[[:fabrice] Fabrice Desré]

Attachment: patch

Comment 4

[Marshall Culpepper [:marshall_law]]

Comment on attachment 672074 [details] [diff] [review]
patch

Review of attachment 672074 [details] [diff] [review]:
-----------------------------------------------------------------

::: b2g/components/UpdatePrompt.js
@@ +313,5 @@
> +    // If we already have an active update available, don't try to
> +    // download again, just prompt for install.
> +    let um = Cc["@mozilla.org/updates/update-manager;1"]
> +               .getService(Ci.nsIUpdateManager);
> +    if (um.activeUpdate) {

nit: use Services.um here? (unless you think we should get rid of that..)

@@ +314,5 @@
> +    // download again, just prompt for install.
> +    let um = Cc["@mozilla.org/updates/update-manager;1"]
> +               .getService(Ci.nsIUpdateManager);
> +    if (um.activeUpdate) {
> +      this.showApplyPrompt(um.activeUpdate);

Can you also update the status setting so the "Checking.." message in gaia gets cleared correctly? 

this.setUpdateStatus("check-complete");

Comment 5

[[:fabrice] Fabrice Desré]

https://hg.mozilla.org/integration/mozilla-inbound/rev/9fba5058ab84

Comment 6

[[:fabrice] Fabrice Desré]

https://hg.mozilla.org/releases/mozilla-aurora/rev/756a74c9a84c

Comment 7

[Tony Chung [:tchung]]

Testing on hold at the moment.   

awaiting bclary to generate a newer unagi_stable build on , so i can test this fix works while checking for a future update. 

logcat: 
10-17 10:40:53.309: E/GeckoConsole(2038): AUS:SVC Checker:getUpdateURL - update URL: http://update.boot2gecko.org/stable/update.xml?force=1
10-17 10:40:53.319: I/Gecko(2038): *** AUS:SVC Checker:onLoad - number of updates available: 1
10-17 10:40:53.319: E/GeckoConsole(2038): AUS:SVC Checker:onLoad - number of updates available: 1
10-17 10:40:53.319: I/Gecko(2038): *** AUS:SVC UpdateService:selectUpdate - skipping update because the update's application version is less than the current application version
10-17 10:40:53.319: E/GeckoConsole(2038): AUS:SVC UpdateService:selectUpdate - skipping update because the update's application version is less than the current application version

Comment 8

[(no longer active)]

https://hg.mozilla.org/mozilla-central/rev/9fba5058ab84

Comment 9

[Tony Chung [:tchung]]

Verified fix when updating on 10-17 unagi update.   Pressing Later, and then force update check will return the updater notification.