800986 - bmm small fixes

Status: RESOLVED FIXED

(Infrastructure & Operations :: RelOps: General, task)

Description

[Dustin J. Mitchell [:dustin] (he/him)]

This is a roll-up of a bunch of small(ish) changes:

* make inventory pattern a config knob
* inventory sync crontask needs a newline
* use mysql for the frontend, not sqlite
* fix 302 redirects generated by the web.py code - they are adding the full path

Comment 1

[(not currently active) Ted Mielczarek]

(In reply to Dustin J. Mitchell [:dustin] from comment #0)
> * fix 302 redirects generated by the web.py code - they are adding the full
> path

Which redirects?

Comment 2

[Dustin J. Mitchell [:dustin] (he/him)]

The redirects I've had problems with are those that add a trailing slash.  They're inserting the full filesystem path of the CGI into the URL.

Comment 3

[(not currently active) Ted Mielczarek]

Ah, that behavior comes from templeton, FYI.

Comment 4

[Dustin J. Mitchell [:dustin] (he/him)]

OK, mock has me stumped on #3.  It can't find the mozilla-python27 dependency for mozilla-python27-mysql-python.

Will resume hacking on this on Monday.

Comment 5

[Dustin J. Mitchell [:dustin] (he/him)]

Attachment: didnt-work.patch

So, this was my first attempt, trying to get MySQL-python installed into mozilla-python27.  Build dependencies didn't work right.

Comment 6

[Dustin J. Mitchell [:dustin] (he/him)]

Attachment: bug800986.patch

This only fixes point 2, using mysql.  But I'd like to get that in soon.

Comment 7

[Jake Watkins [:dividehex]]

Comment on attachment 671091 [details] [diff] [review]
bug800986.patch


> # temporary until mysql is running

just remember to update the comment otherwise g2t

Comment 8

[Dustin J. Mitchell [:dustin] (he/him)]

Comment on attachment 671091 [details] [diff] [review]
bug800986.patch

comment removed - thanks

Comment 9

[Dustin J. Mitchell [:dustin] (he/him)]

* make inventory pattern a config knob
* inventory sync crontask needs a newline
* fix 302 redirects generated by the web.py code - they are adding the full path
* move config.ini to /opt/bmm/config.ini
* add automatic DB reconnection support to bmm (modeled on code in Buildbot)
* inventory sync should use limit=100 to get data from inventory faster (with default, inventory fetch takes >300s)

Comment 10

[Jake Watkins [:dividehex]]

* change owner/group on /var/lib/tftpboot/pxelinux.cfg to allow apache to write

Comment 11

[Dustin J. Mitchell [:dustin] (he/him)]

* make inventory pattern a config knob
  (bmm DONE, puppet DONE)

* inventory sync crontask needs a newline
  (puppet DONE)

* fix 302 redirects generated by the web.py code - they are adding the full path
  https://github.com/markrcote/templeton/pull/1
  and we can suffer in silence until that's fixed..

* move config.ini to /opt/bmm/config.ini
  (puppet DONE)

* add automatic DB reconnection support to bmm (modeled on code in Buildbot)
  SKIPPED - better to just not keep a DB conn open while polling inventory

* inventory sync should use limit=100 to get data from inventory faster
  (bmm DONE)

* change owner/group on /var/lib/tftpboot/pxelinux.cfg to allow apache to write
  (puppet DONE)

That should do it.  Patches in a few.

Comment 12

[Dustin J. Mitchell [:dustin] (he/him)]

Attachment: bug800986-bmm.patch

Comment 13

[Dustin J. Mitchell [:dustin] (he/him)]

Attachment: bug800986-puppet.patch

Comment 14

[Dustin J. Mitchell [:dustin] (he/him)]

Ted, I just merged my repo into http://hg.mozilla.org/build/bmm including these changes, so hopefully they're OK.  Also, we have a 4real repo now!

Comment 15

[(not currently active) Ted Mielczarek]

Comment on attachment 671554 [details] [diff] [review]
bug800986-bmm.patch

Review of attachment 671554 [details] [diff] [review]:
-----------------------------------------------------------------

This looks fine. Hooray, a real repo!

Comment 16

[Dustin J. Mitchell [:dustin] (he/him)]

Sweet.  They were already landed, but I bumped the version to 0.1.2 and will install that with puppet in a moment, with dividehex's r+.