Closed Bug 803862 Opened 7 years ago Closed 7 years ago

Port |Bug 722933 - add -MACHINE option for link.exe| to comm-central

Categories

(MailNews Core :: Build Config, defect)

Product:
MailNews Core
Component:
Build Config
Platform:
All
Windows XP
Type:
defect
Priority:
Not set

Tracking

(seamonkey2.16 fixed)

Status:
RESOLVED FIXED
Milestone:
Thunderbird 19.0
Tracking Flags:
Tracking Status
seamonkey2.16 --- fixed

People

(Reporter: iann_bugzilla, Assigned: iann_bugzilla)

References

Details

Attachments

(1 file)

Add -MACHINE [Checked in: Comment 2]
2.53 KB, patch
Callek
: review+
Details | Diff | Splinter Review 
From Bug 722933:
when building dll, link.exe outputs the following warning.

LINK : warning LNK4068: /MACHINE not specified; defaulting to X86

Also...
- 64-bit link.exe bug, we cannot switch to VS2010 for Win64 build, To use 32-bit link.exe for 64-bit build, we require -MACHINE options.
- When we support Win32/arm build, since arm target is cross compiler only, we must add this option...
Attachment #673594 - Flags: review?(bugspam.Callek)
Try run for 35163d3a83da is complete.
Detailed breakdown of the results available here:
    https://tbpl.mozilla.org/?tree=Try&rev=35163d3a83da
Results (out of 37 total builds):
    success: 19
    warnings: 16
    failure: 2
Builds (or logs if builds failed) available at:
http://ftp.mozilla.org/pub/mozilla.org/firefox/try-builds/iann_cvs@blueyonder.co.uk-35163d3a83da
Attachment #673594 - Flags: review?(bugspam.Callek) → review+
Comment on attachment 673594 [details] [diff] [review]
Add -MACHINE [Checked in: Comment 2]

http://hg.mozilla.org/comm-central/rev/f5d1ecdb30d6
Attachment #673594 - Attachment description: Add -MACHINE → Add -MACHINE [Checked in: Comment 2]
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
status-seamonkey2.16: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 19.0
You need to log in before you can comment on or make changes to this bug.