Last Comment Bug 803862 - Port |Bug 722933 - add -MACHINE option for link.exe| to comm-central
: Port |Bug 722933 - add -MACHINE option for link.exe| to comm-central
Status: RESOLVED FIXED
:
Product: MailNews Core
Classification: Components
Component: Build Config (show other bugs)
: Trunk
: All Windows XP
: -- normal (vote)
: Thunderbird 19.0
Assigned To: Ian Neal
:
Mentors:
Depends on: 722933 803856
Blocks: 802352 803854
  Show dependency treegraph
 
Reported: 2012-10-20 10:32 PDT by Ian Neal
Modified: 2012-10-28 16:08 PDT (History)
1 user (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
fixed


Attachments
Add -MACHINE [Checked in: Comment 2] (2.53 KB, patch)
2012-10-20 10:32 PDT, Ian Neal
bugspam.Callek: review+
Details | Diff | Splinter Review

Description Ian Neal 2012-10-20 10:32:41 PDT
Created attachment 673594 [details] [diff] [review]
Add -MACHINE [Checked in: Comment 2]

From Bug 722933:
when building dll, link.exe outputs the following warning.

LINK : warning LNK4068: /MACHINE not specified; defaulting to X86

Also...
- 64-bit link.exe bug, we cannot switch to VS2010 for Win64 build, To use 32-bit link.exe for 64-bit build, we require -MACHINE options.
- When we support Win32/arm build, since arm target is cross compiler only, we must add this option...
Comment 1 Mozilla RelEng Bot 2012-10-20 14:15:36 PDT
Try run for 35163d3a83da is complete.
Detailed breakdown of the results available here:
    https://tbpl.mozilla.org/?tree=Try&rev=35163d3a83da
Results (out of 37 total builds):
    success: 19
    warnings: 16
    failure: 2
Builds (or logs if builds failed) available at:
http://ftp.mozilla.org/pub/mozilla.org/firefox/try-builds/iann_cvs@blueyonder.co.uk-35163d3a83da
Comment 2 Ian Neal 2012-10-28 16:07:49 PDT
Comment on attachment 673594 [details] [diff] [review]
Add -MACHINE [Checked in: Comment 2]

http://hg.mozilla.org/comm-central/rev/f5d1ecdb30d6

Note You need to log in before you can comment on or make changes to this bug.