803736 - Remove codesighs

Status: RESOLVED FIXED

(Release Engineering :: General, defect)

Description

[Steve Fink [:sfink] [:s:]]

I heard through the grapevine that codesighs is dead.

Comment 1

[Steve Fink [:sfink] [:s:]]

Attachment: Remove codesighs

I applied this patch and the one for buildbot-configs, and I can still start up a scheduler master. But that's about the extent of testing I'm capable of.

Comment 2

[Steve Fink [:sfink] [:s:]]

Attachment: Remove codesighs

Remove it from buildbot-configs too.

Comment 3

[Steve Fink [:sfink] [:s:]]

Comment on attachment 673473 [details] [diff] [review]
Remove codesighs

Oops, I guess it's a bad idea to give 2 different patches the same name when using bzexport. :-)

Comment 5

[Steve Fink [:sfink] [:s:]]

I really ought to start searching for bugs before filing new ones. Especially since "the grapevine" in this case was bug 798798, now that I'm rereading it.

Comment 6

[Phil Ringnalda (:philor)]

You wrote the patch I really didn't want to write, that means that everything else you did was automatically also right.

Comment 7

[[e-mail] (:bhearsum)]

Comment on attachment 673475 [details] [diff] [review]
Remove codesighs

Review of attachment 673475 [details] [diff] [review]:
-----------------------------------------------------------------

Someone else needs to review the lightning/seamonkey parts of this. Once that's done feel free to land this + the buildbotcustom patch on the default branches. They should get put into production pretty soon afterwards.

You also need to update the in-repo mozconfigs (eg, https://mxr.mozilla.org/mozilla-central/source/browser/config/mozconfigs/linux32/nightly). Don't do that until these patches are in production though, otherwise I'm pretty sure the builds will burn.

Comment 8

[Justin Wood (:Callek)]

Comment on attachment 673475 [details] [diff] [review]
Remove codesighs

Review of attachment 673475 [details] [diff] [review]:
-----------------------------------------------------------------

rs+ on seamonkey side, we're a few generations [months] behind on the default branch here. So any changes won't be harmful at all. If m-c changes from under us to break this we can then take this (and related) patched out of band on our own. Thanks for the effort though!

Comment 9

[Philipp Kewisch [:Fallen][☁️📆]]

Comment on attachment 673475 [details] [diff] [review]
Remove codesighs

Thanks for keeping calendar in mind!

Comment 10

[Steve Fink [:sfink] [:s:]]

http://hg.mozilla.org/build/buildbotcustom
http://hg.mozilla.org/build/buildbotcustom/rev/8fb417d57f62

Comment 11

[Steve Fink [:sfink] [:s:]]

http://hg.mozilla.org/build/buildbot-configs/rev/89195fad4418

Comment 12

[Kim Moir [:kmoir] ET]

In production

Comment 13

[[e-mail] (:bhearsum)]

I think this means we're all done here?