901898 - Codesighs is never run by buildbot, but is still enabled in mozconfigs

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Description

[Mark Banner (:standard8)]

Codesighs got removed from buildbot as part of bug 803736. However, its still enabled in the mozconfig files, and still being built.

If we're not using it, we should remove the option from the mozconfig files, and maybe even remove its code as well (similar to bug 823915).

Comment 1

[Mark Banner (:standard8)]

http://mxr.mozilla.org/comm-central/search?string=codesighs&find=mozconfigs&findi=&filter=^[^\0]*%24&hitlimit=&tree=comm-central

Comment 2

[Ed Morley [:emorley]]

Attachment: Patch v1

Comment 4

[Gregory Szorc [:gps]]

Comment on attachment 787065 [details] [diff] [review]
Patch v1

Review of attachment 787065 [details] [diff] [review]:
-----------------------------------------------------------------

I don't know the full history of codesighs and don't know if it is appropriate to remove all of its code. We may no longer run codesighs on automation. However, automation is only one consumer of the tree. Is anyone else running codesighs? Does it deserve to die regardless?

Anyway, I just asked that question in #build and Ms2ger says it can die. That's enough of a second opinion for me, so, r+.

Comment 5

[Ed Morley [:emorley]]

Ty :-)

remote:   https://hg.mozilla.org/integration/mozilla-inbound/rev/2654301601dd

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/2654301601dd

Comment 7

[David Baron :dbaron: (⌚️UTC-5, no longer working on Mozilla)]

FWIW, codesighs's advantages over the tool in bug 659950 are:

 * it shows useful diffs explaining what changed

 * it adds up the data prior to some things that cause quantization, i.e., parts of the library having their sizes rounded up to some rounder size (although I'm not sure how big of an effect that is these days)