Closed
Bug 803740
Opened 13 years ago
Closed 13 years ago
Telephony tests not working with --gecko-path on TBPL
Categories
(Remote Protocol :: Marionette, defect)
Tracking
(firefox18 fixed, firefox19 fixed)
RESOLVED
FIXED
mozilla19
People
(Reporter: jgriffin, Assigned: jgriffin)
References
Details
Attachments
(1 file, 1 obsolete file)
|
7.08 KB,
patch
|
mdas
:
review+
|
Details | Diff | Splinter Review |
The telephony tests are all timing out on TBPL, but I think I figured out why.
If we wait for system-message-listener-ready (see bug 792647) before we shutdown B2G in order to install a new copy of gecko, the tests seem to be pass. If we shutdown B2G *before* this event occurs, and then install gecko and restart B2G, the telephony API's never become usable, regardless of how long you wait.
My previous attempt at fixing this (bug 803253) worked locally but fails on TBPL because it only waits for system-message-listener-ready *after* installing a new gecko, if you use the --gecko-path argument.
This patch waits for this message before and after a gecko installation.
I'm going to run this on cedar before asking for review, in case it needs other adjustments.
|
Assignee | |
Comment 1•13 years ago
|
||
|
|
Assignee | |
Comment 2•13 years ago
|
||
|
|
Assignee | |
Comment 3•13 years ago
|
||
Comment on attachment 673480 [details] [diff] [review]
Wait for system-message-listener-ready before installing new gecko
This seems to have fixed the problem on cedar.
Attachment #673480 -
Flags: review?(mdas)
|
|
Assignee | |
Comment 4•13 years ago
|
||
Pushed to try: https://tbpl.mozilla.org/?tree=Try&rev=26021e377a20
|
|
Assignee | |
Updated•13 years ago
|
Attachment #673480 -
Attachment is obsolete: true
Attachment #673480 -
Flags: review?(mdas)
|
|
||
Updated•13 years ago
|
Attachment #674715 -
Flags: review?(mdas) → review+
|
|
Assignee | |
Comment 6•13 years ago
|
||
try run looked ok, except for an unrelated error.
https://hg.mozilla.org/integration/mozilla-inbound/rev/0a2a5585313d
Assignee: nobody → jgriffin
Target Milestone: --- → mozilla19
|
||
Comment 7•13 years ago
|
||
Status: NEW → RESOLVED
Closed: 13 years ago
Flags: in-testsuite+
Resolution: --- → FIXED
|
|
Assignee | |
Updated•13 years ago
|
Whiteboard: [automation-needed-in-aurora]
|
|
Assignee | |
Comment 8•13 years ago
|
||
|
|
Assignee | |
Comment 9•13 years ago
|
||
status-firefox18:
--- → fixed
status-firefox19:
--- → fixed
Whiteboard: [automation-needed-in-aurora]
|
||
Updated•3 years ago
|
Product: Testing → Remote Protocol
You need to log in
before you can comment on or make changes to this bug.
Description
•