Last Comment Bug 804001 - The "Check now" button in advanced preferences should be "Check now..." after bug 595723
: The "Check now" button in advanced preferences should be "Check now..." after...
Status: RESOLVED FIXED
: polish
Product: Thunderbird
Classification: Client Software
Component: Preferences (show other bugs)
: unspecified
: All All
: -- minor (vote)
: Thunderbird 19.0
Assigned To: :aceman
:
:
Mentors:
Depends on: 595723
Blocks:
  Show dependency treegraph
 
Reported: 2012-10-21 11:09 PDT by :aceman
Modified: 2012-10-30 07:13 PDT (History)
2 users (show)
ryanvm: in‑testsuite-
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---


Attachments
patch (2.95 KB, patch)
2012-10-21 11:21 PDT, :aceman
mconley: review+
bwinton: ui‑review+
Details | Diff | Splinter Review

Description :aceman 2012-10-21 11:09:15 PDT
In bug 595723 we made the System integration dialog to appear unconditionally after clicking "Check now" in preferences. Because of that the button should be renamed to "Check now..." according to current style.
Comment 1 :aceman 2012-10-21 11:21:38 PDT
Created attachment 673712 [details] [diff] [review]
patch
Comment 2 Mike Conley (:mconley) 2012-10-24 07:59:49 PDT
Comment on attachment 673712 [details] [diff] [review]
patch

Review of attachment 673712 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good to me.
Comment 3 Blake Winton (:bwinton) (:☕️) 2012-10-29 07:40:10 PDT
Comment on attachment 673712 [details] [diff] [review]
patch

Yeah, I could buy that.  ui-r=me.

Thanks,
Blake.
Comment 4 Ryan VanderMeulen [:RyanVM] 2012-10-30 07:13:43 PDT
https://hg.mozilla.org/comm-central/rev/f70375216fa7

Note You need to log in before you can comment on or make changes to this bug.