804469 - [Marketplace] Installed app can't be removed immediately if it has been executed (need reboot)

Status: VERIFIED FIXED

(Core Graveyard :: DOM: Apps, defect)

Description

[John Shih]

## Environment :
Otoro phone, build 2012-10-23
Build info: 
* "gaia master" revision= 608ba8a6a931322c96ac1cea7e02f4c4bf9d70fd
* "gecko" revision= 167d5a73c6aa564d1abcae4654467aa18aba9a3e

## Repro :
1. Install an app from marketplace
2. Execute it
3. Press the home button to quit
4. Back to homescreen, then long press on it
5. Press "X" and choose Delete in the dialogue

## Expected:
* Back to homescreen and see the app disappear

## Actual:
* The app didn't disappear, you have to reboot
* If you then try to install another app from market place, it will fail to appear as well

Comment 1

[John Shih]

If you install a app and try to remove it directly (doesn't execute)
it will work fine

Comment 3

[Jason Smith [:jsmith]]

I can confirm this as well. Smoke test bustage.

Comment 4

[(inactive after 6/18) Alive Kuo [:alive]]

I am looking into this. It seems not a gaia bug.
Try this:
1. Open Settings app -> Application Permission, check calculator is there.
2. Press home and then longpress home, remove caculator app.
3. Back to Settings app, the calculator disappears. 
This is normal case, but if you try the following steps then something broken:
4. Use card view to kill the settings app.
5. Open settings app again. Goto Application Permission page again. Check clock is there.
6. Press home and then longpress home button, remove clock app.
7. Back to settings app, the clock app is still there!!

Therefore, the actual problem is,
'mozApps.mgmt install/uninstall' callback is broken when the page/app is killed and restarted.

The original STR works because,
your lovely homescreen app is killed by OOM in background. So, the homescreen you see after you launch an app and then return to, is not the first one. It's the second-time-invoked homescreen. After that, install anything in marketplace doesn't reflect to homescreen.

Comment 5

[Andrew Overholt [:overholt]]

David, did you assign this to me so I could find an owner?

Comment 7

[David Scravaglieri [:scravag]]

No you can find an owner

Comment 8

[[:fabrice] Fabrice Desré]

Attachment: patch

The code removing message listeners when a process stops was incorrect, using the |children| property as an array while it's a dictionary.

Comment 9

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

Comment on attachment 679859 [details] [diff] [review]
patch

Review of attachment 679859 [details] [diff] [review]:
-----------------------------------------------------------------

Do you know when does it change from an array to an object? sigh.

Comment 10

[[:fabrice] Fabrice Desré]

https://hg.mozilla.org/integration/mozilla-inbound/rev/fb0c9673cc5c

Comment 11

[(no longer active)]

https://hg.mozilla.org/mozilla-central/rev/fb0c9673cc5c

Comment 12

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/b3f4f5e82a08

Comment 13

[Jason Smith [:jsmith]]

Verified on 11/12.

Comment 14

[Yuren [:yurenju] (AFK ~ Oct. 12) (volunteer mode)]

Reopen, still happen on 11/21 build.

Comment 15

[Jason Smith [:jsmith]]

(In reply to Yuren Ju [:yurenju] from comment #14)
> Reopen, still happen on 11/21 build.

bug 812119 is already tracking this.