804587 - [Keyboard] Do not capitalise the first letter for input type=text by default

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::Keyboard, defect)

Description

[Ben Francis [:benfrancis]]

STR:
* Open browser app
* Focus awesomebar

Expected:
* First letter not capitalised

Actual:
* First letter capitalised

Alternative STR:
* Open UI Tests app
* Select Keyboard test
* Focus "input type=text" box

Expected:
* First letter is not capitalised

Actual:
* First letter is capitalised

I discussed this with Mounir and he feels the default behaviour should be that type=text does not capitalise, but type=textarea does.

If we want to do autocapitalisation for type=text we need to support that inputMode, as described bug 796544

Comment 1

[Ben Francis [:benfrancis]]

(Note that the STR for the browser app will not work until https://github.com/mozilla-b2g/gaia/pull/5955 lands)

Comment 2

[David Flanagan [:djf]]

taking this and wrapping it into my big keyboard refactor.

Comment 3

[Mounir Lamouri (:mounir)]

(In reply to David Flanagan [:djf] from comment #2)
> taking this and wrapping it into my big keyboard refactor.

David, for information, the recommended workflow with bugzilla is to split patches because it is easier to review and more understandable. Having one patch to rule them all is usually not an ideal situation.

Comment 5

[Naoki Hirata :nhirata (please use needinfo instead of cc)]

I lost track of this bug : https://github.com/mozilla-b2g/gaia/issues/3740  :(

Comment 6

[Mounir Lamouri (:mounir)]

Re-writing the summary. I think it's better to say what should be done instead of saying what is currently done.

Comment 7

[David Flanagan [:djf]]

Fixed by https://github.com/mozilla-b2g/gaia/pull/6007

Comment 8

[John Shih]

verified
build info
2012-10-26
gaia master : 2c50025f7a7ce6f2e653c0e75ef7bd505d823cb8
gecko : c9173078c6a84ed9a423868090cf57f593247f53