804911 - [email] disable notifications / remove settings

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::E-Mail, defect, P1)

Description

[Dylan Oliver [:doliver]]

Email notifications are being dropped from v1. We need to do some clean up work to hide them:

* disable notifications by default
* set check mail frequency to "Manually" by default
* email settings: remove notifications toggle
* email settings: remove check mail frequency selector

Comment 1

[Andrew Sutherland [:asuth] (he/him)]

(In reply to Dylan Oliver [:doliver] from comment #0)
> * set check mail frequency to "Manually" by default

(This is already the case, though it does bear repeating.)


In terms of reasons removing this makes sense, see bug 796751 on the UX implications of the current limitations of mozNotifications.  I also may have discussed this on another bug, but it's not coming to mind right now.

Comment 2

[Dylan Oliver [:doliver]]

We verbally blocking+'d this in triage this morning but no one marked it. 

We have too much work left on notifications to make them functional for v1 -- so we will remove them instead.

Comment 3

[Steve Chung [:steveck]]

Hi Dylan,
Based on this issue and https://bugzilla.mozilla.org/show_bug.cgi?id=804918, https://bugzilla.mozilla.org/show_bug.cgi?id=805102, the general setting list would become empty... Does that means me need to hide whole general setting part in v1?

Comment 4

[Dylan Oliver [:doliver]]

Yes, it's a good question. It's something we should review with Casey but I think you're right. It looks like we should just have the list of accounts there now.

Comment 5

[Steve Chung [:steveck]]

Attachment: Patch for hiding general settings section

Comment 6

[Alex Keybl [:akeybl]]

We're marking this bug with the C1 milestone since it follows the criteria of "unfinished feature work" (see https://etherpad.mozilla.org/b2g-convergence-schedule).

If this work is not finished by Nov19, this bug will need an exception and will be called out at the upcoming Exec Review.

Comment 7

[Dominic Kuo [:dkuo]]

Comment on attachment 677337 [details]
Patch for hiding general settings section

r+, and please see github comments.

Comment 8

[J Zimbrick]

Appears fixed in Unagi build 20121231070201.

General Setting appear to be hidden.

Verifying as fixed.

Comment 9

[mlevin]

UCID: email-003

Link: https://moztrap.mozilla.org/results/case/61741/

Test Case: #4383

Comment 10

[Tracy Walker [:tracy]]

associated test case in moztrap has been disabled.