804998 - Reviews counter is not working as expected

Status: RESOLVED FIXED

(Marketplace Graveyard :: Consumer Pages, defect, P2)

Description

[Victor Carciu]

Prerequisites:
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:19.0) Gecko/19.0 Firefox/19.0

Steps to reproduce:
1.Go to MP and open a rated app
2.Observe that there is a button for opening all reviews, containing the average stars given and a counter for the number of reviews

Expected results:
The number of the reviews is equal with the number from the button presented at step 2.

Actual results:
The counter is not working as expected and the number of reviews is not the same with the number displayed on the button from step 2.

Please see screencast for this bug : http://screencast.com/t/EEeYcfE4wBUv

NOTES:
Reproducible also in production.

Comment 1

[Wil Clouser [:clouserw]]

I assume this is related to only showing reviews from the current version.  -> rob

Comment 2

[Rob Hudson [:robhudson]]

Happy to look. The screencast shows hosted apps, however, which shouldn't have multiple versions.

The reviews have a few denormalized fields that don't seem to be updating properly, which happens in a task. Or the task runs but the queries are wrong. I'll take a good look.

See also bug 805286.

Comment 3

[Rob Hudson [:robhudson]]

With help from Basta we've got a theory, which I'll test tomorrow...

The tasks are doing aggregate queries and assigning the results to the denormalized fields on the addons table. But it's using `.filter(...).update(...)`, which calls Django's `update` which does a SQL UPDATE and doesn't sign pre/post save signals, which is what django-cache-machine uses to invalidate its cache. So the values are updating in the db, but django-cache-machine is still returning the old values from cache.

Since we have the object already, I'm going to just update it to use our obj.update(...) call, which also does a SQL UPDATE but also sends the appropriate signals. This should invalidate the queries in django-cache-machine and let the correct totals stashed on the addon table come through.

Comment 4

[Rob Hudson [:robhudson]]

https://github.com/mozilla/zamboni/commit/34595c7114e6d2a3aace348a43bd6ce13c5ee22e

Comment 5

[Victor Carciu]

I am not sure if the change is applied only from now, but the issue is still reproducible for some apps : http://screencast.com/t/Z6t9v3HY

Comment 6

[Rob Hudson [:robhudson]]

The patch to fix this hasn't gone out to prod yet. When it does, we could either blow away memcache or run a script that targets webapps with reviews to force them to clear the cache that is keeping these from showing the correct values.

Comment 7

[Wil Clouser [:clouserw]]

closing for comment 6

Comment 8

[Victor Carciu]

Verified as fixed : http://screencast.com/t/SNPT3u19Oaj

Comment 9

[Victor Carciu]

I am not sure if we have the same issue here , but the reviews counter is not working as expected again (use https://marketplace-dev.allizom.org/app/ffdoku/?src=mkt-search) : http://screencast.com/t/aMwegKJx

Comment 10

[Matt Basta [:basta]]

This is no longer an issue in Fireplace thanks to the API.