805286 - Displaying "Not yet rated 0 reviews" for app with 1 review

Status: VERIFIED FIXED

(Marketplace Graveyard :: Consumer Pages, defect, P3)

Description

[Maureen Hanratty]

Attachment: "Not yet rated 0 reviews"

Confusing screen. 

1. The app has 1 review but text says it has 0 reviews (Related to this bug: https://bugzilla.mozilla.org/show_bug.cgi?id=804998)

2. Apps with 0 reviews do not have this button. They display text "This app is not yet rated and the "Write a Review" button.

Comment 1

[Maureen Hanratty]

Attachment: Screenshot of app with 0 reviews

Screenshot of app with has 0 reviews

Comment 2

[Rob Hudson [:robhudson]]

URL: https://marketplace.mozilla.org/app/todoist/

Comment 3

[Rob Hudson [:robhudson]]

https://github.com/mozilla/zamboni/commit/34595c7114e6d2a3aace348a43bd6ce13c5ee22e

This fixes the cause. To fix the symptom we just need to re-save the add-on, which should reset its cache and pull in the proper counts from the database.

Comment 4

[Cristian Boldan]

Issue from the step 1 (The app has 1 review but text says it has 0 reviews Not yet rated) is still reproducing.
Verified on FF19 (Win 7)
Please see screencast http://screencast.com/t/qhxosQAb

Comment 5

[Rob Hudson [:robhudson]]

The task that updates the denormalized fields is failing on hosted apps that have multiple versions. It works fine otherwise. Hosted apps technically shouldn't have multiple versions but we have some that do because of an old cron job that was checking manifests and creating new versions.

Andrew and I agreed that we should collapse versions for hosted apps.

I'll write a migration that does roughly the following:
* For all hosted, active web apps:
* Get the latest version
* Get all versions that aren't the latest version and:
  * Update any related records pointing to this version to point to the latest version
  * Delete this version & file from the db

That should fix this problem and possibly future problems from hosted apps and versions not being consistent.

Comment 6

[Christopher Van Wiemeersch [:cvan]]

(In reply to Rob Hudson [:robhudson] from comment #5)
> The task that updates the denormalized fields is failing on hosted apps that
> have multiple versions.

Aww, why is that?

Comment 7

[Rob Hudson [:robhudson]]

The collapsing versions script was added over a few commits and tested against the data on -dev.  I'll test hosted apps with zero reviews and see if I can still reproduce. If not, we could run the script against prod also.

Comment 8

[Rob Hudson [:robhudson]]

I was able to reproduce on an app and verified it had only a single version:
https://marketplace-dev.allizom.org/app/ginger/

It also worked correctly on another app:
https://marketplace-dev.allizom.org/app/mindseng/

Comment 9

[Rob Hudson [:robhudson]]

Trying one more time...
https://github.com/mozilla/zamboni/commit/9cb4297 

I found a race condition only sometimes when the addon was saved and it having stale data which overwrote the data the task just wrote. Since we were only saving the addon to trigger a re-index, this bypasses the save step and just calls the reindexing directly.

Comment 10

[Cristian Boldan]

Issue is still reproducible in https://marketplace-dev.allizom.org/ on FF20 (Win 7)
Please see screencast http://screencast.com/t/eExbs7rEa

Comment 11

[Rob Hudson [:robhudson]]

It looks like count caching now. If you re-visit the app you tested is it correct?  I just tested one on -dev and immediately after it said "0 reviews" but after about 1 minute it updated.

I can see if we can invalidate this somehow, but it's an improvement -- at least the data is correct in the database.

Comment 12

[Rob Hudson [:robhudson]]

I'm stuck on this...

I can reproduce locally sometimes. The task is updating the total reviews field of the db fine and the .save() should invalidate the cached queries. But every so often it seems like the invalidation doesn't work and the cached query is returned with stale data.

Comment 13

[Cristian Boldan]

I have re-visited the app and, on some apps it looked like it's a cache issue, but usually it reproduced the same as before fixing, even though I waited a certain amount of time, cleared cache or re-visited the page.

Comment 14

[Matt Basta [:basta]]

This is no longer a bug in Fireplace thanks to the use of ratings objects to get an actual count.

Comment 15

[Iulian Timis]

Verified as fixed in https://marketplace-dev.allizom.org/ on FF24 (Win 7).
Postfix screencast http://screencast.com/t/OkrihBOBL
Closing bug.