805095 - When downloading news articles for offline, modal alert dialogs are shown for expired articles.

Status: RESOLVED FIXED

(MailNews Core :: Networking: NNTP, defect)

Description

[Glenn Knickerbocker]

User Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:10.0.9) Gecko/20100101 Firefox/10.0.9
Build ID: 20121011153109

Steps to reproduce:

While groups are being synced for offline reading, I'm reading other mail and newsgroups.


Actual results:

As each article that can't be retrieved is attempted, the Error! HTML replaces the article I'm viewing in the message pane.


Expected results:

The Error! HTML should be displayed only in place of the article it's reporting on.

Comment 1

[Glenn Knickerbocker]

Ow!  I switched to reading articles in a separate message window to work around this.  When I got through mail and started on newsgroups, the Error! HTML replaced the article in the message window as well.  Selecting any new folder or group in the folder pane caused it to stop.

Comment 2

[David Lechner (:dlech)]

When you say "While groups are..." do you mean newsgroups? Your use of "article" makes is sound like maybe you mean RSS or something else. What causes some articles to no be able to be retrieved?

Comment 3

[Glenn Knickerbocker]

"Article" is the word used in the NNTP RFCs.  Retrieval can fail for all kinds of reasons--connection error, login error, error in the server causing the article not to be found, article canceled or expired, etc.  These all happen frequently on a badly designed NNTP gateway that I'm stuck using at work.

Comment 4

[Wayne Mery (:wsmwk)]

duplicate of bug 98534 ?

Comment 5

[Glenn Knickerbocker]

Not a duplicate, unrelated.  The message displayed is correct and expected, but it's displayed in the wrong place.

Comment 6

[Hartmut Welpmann [:welpy-cw]]

Unfortunately this still a thing with nntp-js: While the message display doesn't change, the user is presented with a modal alert dialog for every single expired message encountered, making Thunderbird rather unusable (The easiest way out is to type Ctrl-Q immediately after clicking OK).

Comment 7

[Hartmut Welpmann [:welpy-cw]]

Attachment: Bug 805095 - No additional alert dialog when displaying about:newserror. r=mkmelin

Comment 8

[Hartmut Welpmann [:welpy-cw]]

There's still a unit test to adapt.

Comment 9

[Hartmut Welpmann [:welpy-cw]]

There was code to adapt to the unit test.

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/3290596cac87
No additional alert dialog when displaying about:newserror.r=mkmelin