805523 - toast notification clicks not working

Status: VERIFIED FIXED

(Firefox Graveyard :: SocialAPI, defect)

Description

[Shane Caraveo (:mixedpuppy)]

The toast notification api allows a url for the click handler.  It works in beta, doesn't work in aurora, on windows.

Comment 1

[Mark Hammond [:markh] [:mhammond]]

This is actually a regression from bug 795065 - openUILink now insists on having the second param (aEvent) passed or things fail.

However, as bug 808001 already wants to change this to openUILinkIn, I won't bother trying to get the regression fixed but just upload a patch to bug 808001.

Comment 2

[Mark Hammond [:markh] [:mhammond]]

fixed via bug 808001

Comment 3

[:Gavin Sharp [email: [e-mail]]]

(for branches, bug 814264 would also fix this)

Comment 4

[Mark Hammond [:markh] [:mhammond]]

Bug 808001 is fixed on 19 meaning this is too.

Comment 5

[Alex Keybl [:akeybl]]

Bug 814264 was approved today, so this should be resolved in FF18 soon.

Comment 6

[:Gavin Sharp [email: [e-mail]]]

Fixed on 18 by bug 814264 (needs verification!).

Comment 7

[u279076]

Is there a way to force a toast to appear so I can verify this?

Comment 8

[Mark Hammond [:markh] [:mhammond]]

(In reply to Anthony Hughes, Mozilla QA (:ashughes) from comment #7)
> Is there a way to force a toast to appear so I can verify this?

The best way is to have firefox shut down and arrange for a message (eg, a chat) to be sent to you, then start firefox.  The message that was sent while FF wasn't running should appear as a toast on startup.

Comment 9

[Shane Caraveo (:mixedpuppy)]

the demo provider has a button to send a notification.  I haven't tried it in a while, since the osx builds I have no longer have notifications :(

Comment 10

[u279076]

Testing with Firefox 18.0b2 this didn't work as expected.

1. Activated Social API
2. Quit Firefox
3. Had Shane send me a message with a URL in it
4. Started Firefox
> Red "1" appeared over the messages button
> Clicking the message opened a chat panel where I could click the link and open a new tab
> No toast notification appeared

I tried this a couple times with the same result. I have "Show desktop notifications" enabled.

Comment 11

[u279076]

I spoke with Shane about this offline and he mentioned that Facebook's implementation should send a notification when the sidebar is hidden for anything that would normally populate the activity stream. Following his suggested steps:

1. Activate Social API
2. Hide the sidebar
3. Have someone post a link to my wall
> Toast notification appears but clicking it did nothing

Following Shane's advice, I will now try with the demo provider.

Comment 12

[Mark Hammond [:markh] [:mhammond]]

I just remembered - my repro was wrong - instead of having someone send a message via facebook, have someone comment on one of your wall posts...

Comment 13

[u279076]

With Firefox 18.0b2, when trying the demo provider I can't click the link. I get the following errors in error console:

social.notification-create-error: TypeError: event is undefined
WorkerAPI: topic doesn't have a handler: 'social.notification-action'

With Firefox 19.0a2 2012-12-04 this works fine. I suppose it's possible that this missed 18.0b2 and will be fixed in 18.0b3.

Comment 14

[Mark Hammond [:markh] [:mhammond]]

It looks like beta2 was built from changeset number 117166 and bug 814264 was changeset number 117198, so yeah, it looks like it missed b2.

Comment 15

[Mihai Morar, (:MihaiMorar)]

It looks like is fixed on 18b4. I had verified only on Windows 7 x64 and Ubuntu x86. Can someone verify for Mac OS to set this as verified fixed please, because I don't have access at Mac OS today?

Comment 16

[u279076]

Thank Mario, I confirm this is working in 18.0b5 on Mac OSX 10.7.