808001 - Clicking on notification pop-ups opens them in the focused tab, not in a new tab

Status: VERIFIED FIXED

(Firefox Graveyard :: SocialAPI, defect)

Description

[Ioana (away)]

Reproduced on Firefox 17 beta 4 - Build ID: 20121031065642

STR:
1. Open www.facebook.com and log into your Facebook account.
2. Click the Turn On button from http://www.facebook.com/about/messenger-for-firefox.
3. From a secondary Facebook account, perform an action that generates a notification for the account in the sidebar (Like their post, comment their post).
4. When the notification is displayed on the bottom right side of the sidebar, click on the link inside it.

The link is loaded in the open & focused tab instead of being opened in a new tab. When clicking on Notifications button next to the Search bar and clicking the notification, it is opened in a new tab.

Comment 1

[:Gavin Sharp [email: [e-mail]]]

(In reply to Ioana Budnar [QA] from comment #0)
> 4. When the notification is displayed on the bottom right side of the
> sidebar, click on the link inside it.

I can't reproduce - what do you mean by "bottom right of the sidebar"? I couldn't get any links to appear in the upper half of the sidebar - any time I clicked on an entry in that activity feed I just get a flyout panel. Maybe a screenshot of what you're clicking on would help?

Comment 2

[u279076]

I believe what Ioana is referring to is the toast notification that appears. On Linux there is a temporary overlay notification that appears on the bottom-right of the screen.

Comment 3

[:Gavin Sharp [email: [e-mail]]]

Ah! Makes sense - I missed the summary.

Comment 4

[:Gavin Sharp [email: [e-mail]]]

The click listener for notifications in WorkerAPI.jsm just calls openUILink(nUri.spec) on the most recently focused chrome window - it should call openUILinkIn(nUri.spec, "tab") instead.

Comment 5

[Srinath N [:srinath]]

Hi Gavin,

I'm interested in working on this defect. Are you available for mentoring?

Comment 6

[:Gavin Sharp [email: [e-mail]]]

Sure! I think someone was already working on this one, but perhaps you can work together. You can find me on IRC as "gavin".

Comment 7

[Mark Hammond [:markh] [:mhammond]]

Attachment: Use openUILinkIn

Sorry for jumping in on this one, but as this patch also fixes the more serious bug 805523 I felt it should be done ASAP.

Comment 8

[Mark Hammond [:markh] [:mhammond]]

Tracking 18 for bug 805523

Comment 9

[:Gavin Sharp [email: [e-mail]]]

Comment on attachment 684253 [details] [diff] [review]
Use openUILinkIn

This is great, and probably worth taking on branches on its own merits, but I think we'll solve bug 805523 specifically another way (see bug 814264).

Comment 10

[Mark Hammond [:markh] [:mhammond]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/e817a9af24c1

Comment 11

[Mark Hammond [:markh] [:mhammond]]

Comment on attachment 684253 [details] [diff] [review]
Use openUILinkIn

[Approval Request Comment]
Bug caused by (feature/regressing bug #): N/A
User impact if declined: Users clicking on a social notification will have their current page navigated away from.
Testing completed (on m-c, etc.): Landed on m/c 
Risk to taking this patch (and alternatives if risky): Low risk.
String or UUID changes made by this patch: None

Comment 12

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/e817a9af24c1

Comment 13

[:Gavin Sharp [email: [e-mail]]]

I don't think we need to track this, we're tracking bug 805523 and bug 814264.

Comment 14

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/3cf0a53eb531

Comment 15

[u279076]

I know it's kind of late in the cycle, but I'm wondering if this can be uplifted to Beta given the patch is low risk.

Comment 16

[Mihai Morar, (:MihaiMorar)]

I log into two different accounts on facebook, and before got logged in the second one I had activated Social API. After second account login was completed, social API auto activated sidebar for the second account. Is that expected, because if it is I can't run Step 4 from Comment 0 ? 

Windows 7 x64, FF 19b4:

Mozilla/5.0 (Windows NT 6.1; WOW64; rv:19.0) Gecko/20100101 Firefox/19.0(20130130080006)

Comment 17

[Mark Hammond [:markh] [:mhammond]]

(In reply to MarioMi from comment #16)
> I log into two different accounts on facebook, and before got logged in the
> second one I had activated Social API. After second account login was
> completed, social API auto activated sidebar for the second account. Is that
> expected, because if it is I can't run Step 4 from Comment 0 ? 

It is expected.  When comment 0 talks about the secondary account, it means from a different browser (eg, Fx using a different profile, Fx on a different machine, or an entirely different browser) - which is used simply to generate the message.

Comment 18

[Cornel Ionce [:noni] [Hubs QA]]

Verified as fixed on Firefox 19 beta 5.

Windows 7 - User Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:19.0) Gecko/20100101 Firefox/19.0
Mac OS X - User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.8; rv:19.0) Gecko/20100101 Firefox/19.0
Linux - User Agent: Mozilla/5.0 (X11; Ubuntu; Linux i686; rv:19.0) Gecko/20100101 Firefox/19.0

Build ID: 20130206083616

Comment 19

[Mihai Morar, (:MihaiMorar)]

I confirm the fix is verified on FF 20b6 too:

Mozilla/5.0 (Windows NT 6.1; WOW64; rv:20.0) Gecko/20100101 Firefox/20.0
Mozilla/5.0 (X11; Linux i686; rv:20.0) Gecko/20100101 Firefox/20.0
Mozilla/5.0 (Macintosh; Intel Mac OS X 10.8; rv:20.0) Gecko/20100101 Firefox/20.0
BuildsID: 20130320062118