806011 - Can't change the character set for opened saved message

Status: RESOLVED FIXED

(Thunderbird :: Message Reader UI, defect)

Description

[Dmitry]

Attachment: test.eml

User Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:15.0) Gecko/20100101 Firefox/15.0
Build ID: 20120824154833

Steps to reproduce:

* Open the attached test.eml using "File → Open Saved Message"...
* Having the "View → Character Encoding → Auto-Detect" set to "Russian", the given message is not correctly recognized as UTF-8 message.
* Setting "Character Encoding" to "Unicode (UTF-8)" has no effect.

Expected: It is not possible to force the correct encoding to view the massage.

Comment 1

[Dmitry]

Attachment: Screenshot of the viewer

Comment 2

[Urmas]

Same behavior in 16.0.2 if Autodetect encoding is turned off.

Comment 4

[Magnus Melin [:mkmelin]]

nsMessenger::SetDocumentCharset - http://mxr.mozilla.org/comm-central/source/mailnews/base/src/nsMessenger.cpp#1596

Comment 5

[Jorg K (CEST = GMT+2)]

Looking at it in the debugger shows that at
https://dxr.mozilla.org/comm-central/source/mailnews/base/src/nsMessenger.cpp#1600
mLastDisplayURI is empty, to the block that follows is skipped and the message is not displayed again using the override charset. Note, that forwarding/replying does use the override.

mLastDisplayURI is only set once here in nsMessenger::OpenURL():
https://dxr.mozilla.org/comm-central/source/mailnews/base/src/nsMessenger.cpp#445

Also note the comment here:
https://dxr.mozilla.org/comm-central/source/mailnews/base/src/nsMessenger.h#90

Messages opened from files are treated in nsMessenger::LoadURL().

Setting mLastDisplayURI there fixes the problem. Patch coming.

Comment 6

[Jorg K (CEST = GMT+2)]

Attachment: Suggested solution (v1).

One-line fix as discussed in comment #5.

Comment 7

[Magnus Melin [:mkmelin]]

Comment on attachment 8713865 [details] [diff] [review]
Suggested solution (v1).

Review of attachment 8713865 [details] [diff] [review]:
-----------------------------------------------------------------

Yes, this seems reasonable and works fine! r=mkmelin

Comment 8

[Jorg K (CEST = GMT+2)]

Comment on attachment 8713865 [details] [diff] [review]
Suggested solution (v1).

[Approval Request Comment]
Regression caused by (bug #): No regression.
User impact if declined: Low, can't change charset of message opened from file.
Testing completed (on c-c, etc.): Manual.
Risk to taking this patch (and alternatives if risky):
Not risky, one line change to set the message URL.

Comment 9

[:aceman]

https://hg.mozilla.org/comm-central/rev/f98bae5d9f43

Comment 10

[Jorg K (CEST = GMT+2)]

Aurora (TB 46):
https://hg.mozilla.org/releases/comm-aurora/rev/d61d865c805e

Comment 11

[Kent James (:rkent)]

Comment on attachment 8713865 [details] [diff] [review]
Suggested solution (v1).

http://hg.mozilla.org/releases/comm-beta/rev/18da5ccc17b1