Closed Bug 806320 Opened 12 years ago Closed 10 years ago

social.page-mark should include meta-data

Categories

(Firefox Graveyard :: SocialAPI, enhancement)

Product:
Firefox Graveyard
Component:
SocialAPI
Version:
19 Branch
Type:
enhancement
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED
Milestone:
Firefox 26

People

(Reporter: em, Assigned: mixedpuppy)

References

Details

(Whiteboard: [needs-api-change]) 

Since recommendations tend to include the title of the recommended page it makes sense to provide this to the social provider. That is, the social.user-recommend should include the title of the page. 

Other meta-data might also be included, perhaps the data url of the favicon as well.

Without such meta-data the provider will need to load the page again and extract such information on its own. This may result in needless web requests and a delayed share response for the user.
sounds correct to me.
Status: UNCONFIRMED → NEW
Ever confirmed: true
OS: Linux → All
Hardware: x86 → All
I wonder if maybe we shouldn't include the HTML <head> section as well. In particular if I am sharing a URL I will be interested in the canonical URL. This could be represented by a facebook tag, or the google rel tag, or some other item.
Providing meta data from the page risks leaking private information to the provider (e.g. information that should only visible when the page is loaded by a logged-in user), so this can be tricky to get right. Passing the title may be feasible.
Sorry for the bug-spam.  This is a first cut at bugs that need (or potentially need) a change to the social api to be implemented appropriately.
Whiteboard: [needs-api-change]
(In reply to :Gavin Sharp (use gavin@gavinsharp.com for email) from comment #3)
> Providing meta data from the page risks leaking private information to the
> provider (e.g. information that should only visible when the page is loaded
> by a logged-in user), so this can be tricky to get right. Passing the title
> may be feasible.

we can use opengraph, those are designed for this purpose.

http://ogp.me/

There are a few other techniques as well which avoid the risk factors, we can dig back into old f1 code to find the parsing we did.
there is meta data in the share prototype in bug 818675
Blocks: 818675
Summary: social.user-recommend should include meta-data → social.page-mark should include meta-data
No longer blocks: 818675
Depends on: 818675, 853151
This was fixed with the new marks button (bug 913826), closing.
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Assignee: nobody → francesco.lodolo
Target Milestone: --- → Firefox 26
@RyanVM, did you mean to assign this bug?  If so, why?
Flags: needinfo?(ryanvm)
Because he's the one who fixed bug 913826, which is what fixed this.
Flags: needinfo?(ryanvm)
sigh.  I put the wrong but #, the new marks button is bug 891219.
Assignee: francesco.lodolo → mixedpuppy
Product: Firefox → Firefox Graveyard
You need to log in before you can comment on or make changes to this bug.