807299 - Regression: Invalidation issues with about:apps and add-ons-manager

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: Toolbar, defect)

Description

[Aaron Train [:aaronmt]]

Attachment: Nightly (10/31) - Screenshot

See screenshot.

STR (new profile)

1) Visit about:apps

Comment 1

[Aaron Train [:aaronmt]]

I think this is a drawing issue actually. If I pinch in, I see the container expand. In console I see

D/GeckoLayerClient( 2307): Aborting draw due to resolution change
E/GeckoConsole( 2307): [JavaScript Error: "TypeError: this._mLastPinchPoint is undefined" {file: "chrome://browser/content/browser.js" line: 3757}]

Comment 2

[Aaron Train [:aaronmt]]

Attachment: Nightly (10/31) - Screenshot (landscape)

Tiles regression?

Comment 3

[Aaron Train [:aaronmt]]

http://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=972986c4f75e&tochange=5ecff3e46ed5

Comment 4

[Benoit Girard (:BenWa)]

When looking at this Chris you could try disabling the tile store to rule out that the tile is getting harvested incorrectly.

Comment 5

[Benoit Girard (:BenWa)]

I can't reproduce this with a current m-c tip build:
changeset:   112302:358c9830d166
tag:         tip
parent:      112283:50cd5f7339f6
parent:      112301:60c78a559a84
user:        Ed Morley <[e-mail]>
date:        Mon Nov 05 15:23:36 2012 +0000
summary:     Merge last PGO-green changeset of mozilla-inbound to mozilla-central

Aaron can you confirm that the bug is still there? Maybe it's specific to some dimensions?

Comment 6

[Aaron Train [:aaronmt]]

I can still reproduce this on Nightly (11/05), a slight pinch-zoom in reveals it.

--
Samsung Galaxy Nexus (Android 4.1.2)
Samsung Galaxy Note II (Android 4.1.1)

Comment 7

[Chris Lord [:cwiiis]]

Attachment: Fix incorrect progressive draw cancelling

Not pleased with this patch, but it seems necessary and fixes a lot of invalidation issues for me on my patch queue. Not 100% sure this will fix this, so I could really do with some QA help here.

Comment 9

[Benoit Girard (:BenWa)]

Comment on attachment 679213 [details] [diff] [review]
Fix incorrect progressive draw cancelling

Review of attachment 679213 [details] [diff] [review]:
-----------------------------------------------------------------

I have no problem prevent a painting abort if we're not sure. Aborting should only be done if we're sure.

Comment 10

[Chris Lord [:cwiiis]]

Pushed to inbound: https://hg.mozilla.org/integration/mozilla-inbound/rev/119b681073b4

Not marking this as leave-open, but please reopen if this bug persists. I don't expect it will, but you never know...

Comment 11

[Aaron Train [:aaronmt]]

Nice. I'll tour Nightly with this fix looking at some of issues I saw on tomorrow's m-c build.

Comment 12

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/119b681073b4

Comment 13

[Aaron Train [:aaronmt]]

This still isn't fixed for me on my Galaxy Nexus using the 11/08 Nightly. I still see what you get in the two screenshots attached.

Comment 14

[Benoit Girard (:BenWa)]

I'm going to investigate and confirm/reject that this bug is caused by aborting.

Comment 15

[Benoit Girard (:BenWa)]

I can reproduce this bug by rotating the phone.

Comment 16

[Aaron Train [:aaronmt]]

Another way to reproduce; install Ad-Block Plus, head to the Add-ons Manager and expand it's options and rotate the browser. The entire Add-ons Manager becomes white.

Comment 17

[Benoit Girard (:BenWa)]

I was able to confirm today that it's not caused by progressive painting. I tried to run mozregression but I'm missing python modules and installed a bunch of stuff with no success.

It would be a great help if we can find the regression window.

Comment 19

[Aaron Train [:aaronmt]]

Attachment: Nightly (11/14) - Add-ons Manager

Add-ons Manager in 11/14 (left is what I see going in, and right is what I get after a pinch zoom, or a rotation)

Comment 20

[Cristian Nicolae (:xti)]

There is the same regression range as for bug 795438:

The last Good build: 10/25

Bad build: 10/26

The exact regression-range is: http://hg.mozilla.org/integration/mozilla-inbound/pushloghtml?fromchange=8a6b6b5f3e55&tochange=044f1370c2b8

Comment 21

[Benoit Girard (:BenWa)]

Since it's the same issue as bug 795438 marking as blocking bug 783368.

Comment 22

[Aaron Train [:aaronmt]]

Marking as Aurora/Nightly affected now.

Comment 23

[Ioana Chiorean]

Attachment: screenshots

This is reproducible on Firefox 18 Beta 5 both on phones and tablet.

Devices: Galaxy Nexus (4.1.1) and Asus EEE Transformers (4.0.3)

Comment 24

[Ioana Chiorean]

(In reply to Ioana Chiorean from comment #23)
> Created attachment 694300 [details]
> screenshots
> 
> This is reproducible on Firefox 18 Beta 5 both on phones and tablet.
> 
> Devices: Galaxy Nexus (4.1.1) and Asus EEE Transformers (4.0.3)

Due to this, I will reopen the bug . Set to flag for 18 to WONTFIX if will not be pushed to beta too. 

Note: Not reproducible on Nightly (2012-12-19) nor on Aurora (2012-12-19)

Comment 25

[Brad Lassey [:blassey] (use needinfo?)]

qawanted to retest on trunk

Comment 26

[Aaron Train [:aaronmt]]

(In reply to Brad Lassey [:blassey] from comment #25)
> qawanted to retest on trunk

Look above. Fixed on trunk/aurora, broken on beta.

Comment 27

[Aaron Train [:aaronmt]]

This is still an issue for some apparently; dupe (bug 803073). Can we get a check here as this is tracking For Beta (mozilla-19).

Comment 29

[bug.zilla]

Hi,

is there an update to this?
Can we help with testing?

Comment 30

[Aaron Train [:aaronmt]]

I need to check if this is still an issue.

Comment 31

[Erin Lancaster [:elan]]

Addin QA wanted to flag the re-testing Aaron mentions above.

Comment 32

[bug.zilla]

Attachment: Screenshot

Comment 33

[bug.zilla]

This is an issue in all tabs not just about:addons, see screenshot

Comment 34

[Andreea Pod]

Attachment: Nightly (02/08) - Samsung Galaxy S ll

I'm not able to reproduce this issue on Firefox 19 Beta 5 on Asus EEE Transformers (4.0.3) 
But this issue occurs on Samsung Galaxy S2, on latest nightly(2013-02-08), see screenshot

Comment 35

[Ioana Chiorean]

Attachment: Screens 20 Beta 1 build 2

This is still reproducing badly

Comment 36

[Andreea Pod]

Attachment: Firefox 20 Beta1 (02/22)

Issues on Firefox 20 Beta 1 on Acer Iconia( Android  3.2.1), see screenshot

Comment 37

[Tony Chung [:tchung]]

recent comments shows its reproducing on Fx20 beta 1 builds.

Comment 38

[Aaron Train [:aaronmt]]

Some of this might have flared up due to bug 842389 which will be backed out and requiring a re-spin of Firefox 20 Beta 1

Comment 39

[bug.zilla]

Hi,

this problem persists on my device.
Can anyone replicate?

Comment 40

[Mark Finkle (:mfinkle) (use needinfo?)]

I think this was fixed by bug 850396. Can we retest the current beta?

Comment 41

[Aaron Train [:aaronmt]]

Re-tested my original devices as filed, (Note/Galaxy Nexus) w/current Fx20; this seems fixed for me. Andreea, can you check your devices as you tested in this bug?

Comment 42

[Chris Lord [:cwiiis]]

I've noticed that sometimes the image can take a while to load, but I've not noticed any invalidation issues on this page.

Comment 43

[Ioana Chiorean]

Using build Firefox 20 beta 6 on Acer Iconia A500 and Galaxy SII I am not able to reproduce the issues. Seems fixed.

Comment 44

[Aaron Train [:aaronmt]]

Marking fixed via bug 850396

Comment 45

[bug.zilla]

Attachment: Screenshot

Comment 46

[bug.zilla]

Hi,

same issue on my device (Galaxy Note)
See attached screenshot.

Can I provide any useful info to help identify the problem?

Comment 47

[Chris Lord [:cwiiis]]

(In reply to bug.zilla from comment #46)
> Hi,
> 
> same issue on my device (Galaxy Note)
> See attached screenshot.
> 
> Can I provide any useful info to help identify the problem?

This is more likely to be bug 852526, which is fixed - try again after tomorrow's Nightly build :)

Comment 48

[Andreea Pod]

Attachment: Screens 20 Beta6 build 1

I'm still able to reproduce this on Firefox for Android 20 Beta 6(2013-03-21) on Samsung Galaxy S II (Android 4.0.3). I will test it next week on Firefox for Android 20 Beta 7.

Comment 49

[bug.zilla]

Hi,

still an issue on my Galaxy Note.
Affects all tabs, not just about:addons.

Comment 50

[Chris Lord [:cwiiis]]

(In reply to bug.zilla from comment #49)
> Hi,
> 
> still an issue on my Galaxy Note.
> Affects all tabs, not just about:addons.

Multiple different bugs have been conflated here, but I don't believe there to be any major issues here anymore. If you have problems, please open a new bug with a detailed description and steps to reproduce. I think there are people on the team who have access to Galaxy Notes, so we should be able to help you. Thanks!

Comment 51

[Teodora Vermesan (:TeoVermesan)]

I don't see this issue anymore on Firefox for Android 23.0a1(2013-04-09), Firefox for Android 22.0a2(2013-04-09) and Firefox for Android 21.0b1 using Samsung Galaxy Note (Android 4.0.4).