Closed Bug 807974 Opened 8 years ago Closed 8 years ago

Be less chatty when the build fails

Categories

(Firefox Build System :: Mach Core, enhancement)

enhancement
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
mozilla19

People

(Reporter: ehsan, Assigned: gps)

References

Details

Attachments

(1 file)

Here's what mach currently shows:

Error running mach:

    ['build']

The error occured in code that was called by the mach command. This is either
a bug in the called code itself or in the way that mach is calling it.

You should consider filing a bug for this issue.

If filing a bug, please include the full output of mach, including this error
message.

The details of the failure are as follows:

Exception: Process executed with non-0 exit code: [u'/usr/bin/make', u'-f', u'client.mk', u'-s']

  File "/Users/ehsanakhgari/moz/mozilla-central/python/mozbuild/mach/commands/build.py", line 48, in build
    log=False, print_directory=False)
  File "/Users/ehsanakhgari/moz/mozilla-central/python/mozbuild/mozbuild/base.py", line 242, in _run_make
    fn(**params)
  File "/Users/ehsanakhgari/moz/mozilla-central/python/mozbuild/mozbuild/base.py", line 265, in _run_command_in_srcdir
    self.run_process(cwd=self.topsrcdir, **args)
  File "/Users/ehsanakhgari/moz/mozilla-central/python/mach/mach/mixin/process.py", line 100, in run_process
    raise Exception('Process executed with non-0 exit code: %s' % args)

We should be able to be a little bit more concise here.  :-)
I fixed this with the patch on bug 803400. If you want to contribute a fix before I land that, go right ahead!
(In reply to comment #1)
> I fixed this with the patch on bug 803400. If you want to contribute a fix
> before I land that, go right ahead!

No, I'll wait! ;-)
I decided to implement this sooner than bug 803400 because it is affecting first-time tree builders who use mach. I'd like to get a fix in the tree ASAP.
Assignee: nobody → gps
Status: NEW → ASSIGNED
Attachment #678424 - Flags: review?(jhammel)
This requires the refactoring work from bug 808346 to apply cleanly.
Depends on: 808346
(In reply to Gregory Szorc [:gps] from comment #4)
> This requires the refactoring work from bug 808346 to apply cleanly.

Should I not review until this bug is fixed?
You could probably do the review now. This just won't apply cleanly because of moved files.
Assuming this isn't platform specific o_O
OS: Mac OS X → All
Hardware: x86 → All
Attachment #678424 - Flags: review?(jhammel) → review+
https://hg.mozilla.org/mozilla-central/rev/e57bd488af4c
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla19
Duplicate of this bug: 803319
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.