Closed Bug 809401 Opened 7 years ago Closed 7 years ago
Horoscopo app doesn't scroll properly as an App
The horoscopes in the Horoscopo app don't scroll properly as an App, but the same content does when loaded directly within the browser. review page for those who can access: https://marketplace.mozilla.org/reviewers/apps/review/horoscopo (otherwise manifest is in the URL)
http://b2g.ig.com.br/horoscopo/ for testing
James, please take a look.
I can reproduce this. The app is using an overflowing div for most of its scrolling (which we're actually pretty good at now). Strangely, its somehow broken in the app, but not in normal Fennec. I suspect it has something to do with the fact I turned off bouncy overscroll in Webapps.
This disables our resetting of the scroll position for subscrollers.
Assignee: nobody → wjohnston
Attachment #690651 - Flags: review?(bugmail.mozilla)
Comment on attachment 690651 [details] [diff] [review] Patch Review of attachment 690651 [details] [diff] [review]: ----------------------------------------------------------------- Makes sense.
Attachment #690651 - Flags: review?(bugmail.mozilla) → review+
Beautiful little app by the way!
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 20
(In reply to Ed Morley [UTC+0; email:edmorley@moco] from comment #8) > https://hg.mozilla.org/mozilla-central/rev/e1245c60df42 Any chance we can get this on the other branches? Aurora at least.
Comment on attachment 690651 [details] [diff] [review] Patch [Approval Request Comment] Bug caused by (feature/regressing bug #): Bug 783553 User impact if declined: Can't scroll overflow elements in webapps Testing completed (on m-c, etc.): Landed on mc last week Risk to taking this patch (and alternatives if risky): This is pretty low risk. A Webapp only feature. Since we're pushing for webapps on Aurora, makes sense to me to push it there. String or UUID changes made by this patch: None.
Attachment #690651 - Flags: approval-mozilla-aurora?
Attachment #690651 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
This got backed out along with bug 808408. https://hg.mozilla.org/releases/mozilla-aurora/rev/c946b3643904
Back in. This had nothing to do with the test failures. I'll look into the other ones. Thanks for catching them. https://hg.mozilla.org/releases/mozilla-aurora/rev/7c1c3d33b320
verified on the latest Aurora with the Horoscopo app.
Status: RESOLVED → VERIFIED
Verified on Firefox Mobile 20 beta 5 and Aurora 21.0a2 2013-03-14 using the LG Nexus 4 (Android 4.2.2)
You need to log in before you can comment on or make changes to this bug.