809401 - Horoscopo app doesn't scroll properly as an App

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: Web Apps (PWAs), defect, P2)

Description

[Andrew Williamson [:eviljeff]]

The horoscopes in the Horoscopo app don't scroll properly as an App, but the same content does when loaded directly within the browser.

review page for those who can access:
https://marketplace.mozilla.org/reviewers/apps/review/horoscopo
(otherwise manifest is in the URL)

Comment 1

[Aaron Train [:aaronmt]]

http://b2g.ig.com.br/horoscopo/ for testing

Comment 2

[Bill Walker [:bwalker] [@wfwalker]]

James, please take a look.

Comment 3

[Wesley Johnston (:wesj)]

I can reproduce this. The app is using an overflowing div for most of its scrolling (which we're actually pretty good at now). Strangely, its somehow broken in the app, but not in normal Fennec. I suspect it has something to do with the fact I turned off bouncy overscroll in Webapps.

Comment 4

[Wesley Johnston (:wesj)]

Attachment: Patch

This disables our resetting of the scroll position for subscrollers.

Comment 5

[Kartikaya Gupta (email:[e-mail])]

Comment on attachment 690651 [details] [diff] [review]
Patch

Review of attachment 690651 [details] [diff] [review]:
-----------------------------------------------------------------

Makes sense.

Comment 6

[Wesley Johnston (:wesj)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/e1245c60df42

Comment 7

[Wesley Johnston (:wesj)]

Beautiful little app by the way!

Comment 8

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/e1245c60df42

Comment 9

[Andrew Williamson [:eviljeff]]

(In reply to Ed Morley [UTC+0; email:edmorley@moco] from comment #8)
> https://hg.mozilla.org/mozilla-central/rev/e1245c60df42

Any chance we can get this on the other branches?  Aurora at least.

Comment 10

[Wesley Johnston (:wesj)]

Comment on attachment 690651 [details] [diff] [review]
Patch

[Approval Request Comment]
Bug caused by (feature/regressing bug #): Bug 783553
User impact if declined: Can't scroll overflow elements in webapps
Testing completed (on m-c, etc.): Landed on mc last week
Risk to taking this patch (and alternatives if risky): This is pretty low risk. A Webapp only feature. Since we're pushing for webapps on Aurora, makes sense to me to push it there.
String or UUID changes made by this patch: None.

Comment 11

[Wesley Johnston (:wesj)]

https://hg.mozilla.org/releases/mozilla-aurora/rev/4f44102ca641

Comment 12

[Ryan VanderMeulen [:RyanVM]]

This got backed out along with bug 808408.
https://hg.mozilla.org/releases/mozilla-aurora/rev/c946b3643904

Comment 13

[Wesley Johnston (:wesj)]

Back in. This had nothing to do with the test failures. I'll look into the other ones. Thanks for catching them.

https://hg.mozilla.org/releases/mozilla-aurora/rev/7c1c3d33b320

Comment 14

[Andrew Williamson [:eviljeff]]

verified on the latest Aurora with the Horoscopo app.

Comment 16

[Adrian Tamas (:AdrianT)]

Verified on Firefox Mobile 20 beta 5 and Aurora 21.0a2 2013-03-14 using the LG Nexus 4 (Android 4.2.2)