811214 - Build failure in SpdySession3.cpp with clang 3.1

Status: RESOLVED FIXED

(Core :: Networking: HTTP, defect)

Description

[Mike Hommey [:glandium]]

netwerk/protocol/http/SpdySession3.cpp:1873:20: error: expected a class or namespace
    GenerateGoAway(goawayReason::OK);
                   ^
1 error generated.

Comment 2

[Mike Hommey [:glandium]]

Attachment: Fix build failure in SpdySession3.cpp with clang 3.1

Comment 4

[Rafael Ávila de Espíndola (:espindola) (not reading bugmail)]

ah, so I guess it was another instance of "clang, but not using c++11". Thanks!

Comment 5

[Mike Hommey [:glandium]]

(In reply to Rafael Ávila de Espíndola (:espindola) from comment #4)
> ah, so I guess it was another instance of "clang, but not using c++11".
> Thanks!

Ah indeed. And that's happening because of this:

/usr/bin/../lib/gcc/x86_64-linux-gnu/4.7/../../../../include/c++/4.7/type_traits:256:39: error: use of undeclared identifier
      '__float128'
    struct __is_floating_point_helper<__float128>
                                      ^
1 error generated.

during the test for -std=gnu++0x.

Comment 6

[Mike Hommey [:glandium]]

which, essentially is http://llvm.org/bugs/show_bug.cgi?id=13530

Comment 7

[Mike Hommey [:glandium]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/951697d19ced

Comment 8

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/951697d19ced