811406 - Work - Trim http:// and single trailing slash from location text in the Firefox app bar

Status: RESOLVED FIXED

(Firefox for Metro Graveyard :: Browser, defect, P3)

Description

[Matt Brubeck (:mbrubeck)]

We should hide "http://" at the start of the URL, and "/" at the end of the URL (if it is the only "/" in the URL).  This should match the default behavior of desktop Firefox (bug 665580).  We should also respect the browser.urlbar.trimURLs pref for users who want to disable this behavior.

Comment 1

[Jonathan Wilde [:jwilde]]

p=2, because there's some delicate interactions with the autocomplete XBL for this

Comment 2

[Jonathan Wilde [:jwilde]]

Attachment: patch v1

Mostly just a straight copy of what desktop FF does, plus some tweaks to make things fit better into browser UI.

Comment 3

[Jonathan Wilde [:jwilde]]

Attachment: patch v1.1

Whoops, committing blank lines again.

Comment 4

[Frank Yan (:fryn)]

Comment on attachment 762238 [details] [diff] [review]
patch v1.1

Review of attachment 762238 [details] [diff] [review]:
-----------------------------------------------------------------

::: browser/metro/theme/browser.css
@@ +308,5 @@
>    padding: 0 !important;
>  }
>  
> +#urlbar-edit :invalid {
> +  box-shadow: none !important;

Interesting. Comment this plz.

Comment 5

[Jonathan Wilde [:jwilde]]

Comment on attachment 762238 [details] [diff] [review]
patch v1.1

Review of attachment 762238 [details] [diff] [review]:
-----------------------------------------------------------------

::: browser/metro/base/content/browser-ui.js
@@ +721,5 @@
> +    let spec = uri.spec;
> +    let trimmedSpec = this.trimURL(spec);
> +    if (spec != trimmedSpec) {
> +      // Prepend the portion that trimValue removed from the beginning.
> +      // This assumes trimValue will only truncate the URL at

These comments should be updated to say trimURL instead of trimValue. Will update before landing on inbound.

Comment 6

[Jonathan Wilde [:jwilde]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/459cc5f50007

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/459cc5f50007