Work - Trim http:// and single trailing slash from location text in the Firefox app bar
RESOLVED
FIXED
in Firefox 24
Status
Firefox for Metro Graveyard
Browser
P3
normal
RESOLVED
FIXED
People
(Reporter: mbrubeck, Assigned: jwilde)
Tracking
({platform-parity, polish, ux-minimalism})
Firefox Tracking Flags
(Not tracked)
Details
(Whiteboard: [shovel-ready] feature=work)
Attachments
(1 attachment, 1 obsolete attachment)
|
7.56 KB,
patch
|
fryn
:
review+
|
Details | Diff | Splinter Review |
We should hide "http://" at the start of the URL, and "/" at the end of the URL (if it is the only "/" in the URL). This should match the default behavior of desktop Firefox (bug 665580). We should also respect the browser.urlbar.trimURLs pref for users who want to disable this behavior.
|
||
Updated•6 years ago
|
Whiteboard: [metro-mvp?][LOE:1] → [metro-mvp][LOE:1]
|
||
Updated•6 years ago
|
Whiteboard: [metro-mvp][LOE:1] → [metro-mvp][LOE:1] feature=work
|
||
Updated•6 years ago
|
Summary: Trim http:// and single trailing slash in the Metro URL bar → Work - Trim http:// and single trailing slash in the Metro URL bar
Whiteboard: [metro-mvp][LOE:1] feature=work → feature=work
|
|
||
Updated•6 years ago
|
Summary: Work - Trim http:// and single trailing slash in the Metro URL bar → Work - Trim http:// and single trailing slash in the location field of the Firefox app bar
|
|
||
Updated•6 years ago
|
Summary: Work - Trim http:// and single trailing slash in the location field of the Firefox app bar → Work - Trim http:// and single trailing slash from location text in the Firefox app bar
|
||
Updated•6 years ago
|
Priority: -- → P3
Whiteboard: feature=work → [shovel-ready] feature=work
|
(Assignee) | |
Updated•6 years ago
|
Assignee: nobody → hello
|
|
(Assignee) | |
Updated•6 years ago
|
Status: NEW → ASSIGNED
|
|
(Assignee) | |
Comment 1•6 years ago
|
||
p=2, because there's some delicate interactions with the autocomplete XBL for this
|
|
(Assignee) | |
Comment 2•6 years ago
|
||
Created attachment 762222 [details] [diff] [review] patch v1 Mostly just a straight copy of what desktop FF does, plus some tweaks to make things fit better into browser UI.
|
|
(Assignee) | |
Comment 3•6 years ago
|
||
Created attachment 762238 [details] [diff] [review] patch v1.1 Whoops, committing blank lines again.
Attachment #762222 -
Attachment is obsolete: true
Attachment #762238 -
Flags: review?(fyan)
|
|
||
Comment 4•6 years ago
|
||
Comment on attachment 762238 [details] [diff] [review] patch v1.1 Review of attachment 762238 [details] [diff] [review]: ----------------------------------------------------------------- ::: browser/metro/theme/browser.css @@ +308,5 @@ > padding: 0 !important; > } > > +#urlbar-edit :invalid { > + box-shadow: none !important; Interesting. Comment this plz.
Attachment #762238 -
Flags: review?(fyan) → review+
|
|
(Assignee) | |
Comment 5•6 years ago
|
||
Comment on attachment 762238 [details] [diff] [review] patch v1.1 Review of attachment 762238 [details] [diff] [review]: ----------------------------------------------------------------- ::: browser/metro/base/content/browser-ui.js @@ +721,5 @@ > + let spec = uri.spec; > + let trimmedSpec = this.trimURL(spec); > + if (spec != trimmedSpec) { > + // Prepend the portion that trimValue removed from the beginning. > + // This assumes trimValue will only truncate the URL at These comments should be updated to say trimURL instead of trimValue. Will update before landing on inbound.
|
|
(Assignee) | |
Comment 6•6 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/459cc5f50007
|
||
Comment 7•6 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/459cc5f50007
Status: ASSIGNED → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 24
|
||
Updated•5 years ago
|
OS: Windows 8 Metro → Windows 8.1
You need to log in
before you can comment on or make changes to this bug.
Description
•