812157 - Do not create a revision when "Save changes" is clicked without changes being made

Status: RESOLVED WORKSFORME

(developer.mozilla.org Graveyard :: Editing, defect, P2)

Description

[David Bruant]

I've just clicked on "save" while making no change to the page and it created an history entry: https://developer.mozilla.org/en-US/docs/WebAPI/Doc_status$compare?to=328989&from=328983

I think it should rather do the same thing than "Discard changes"

I'm doing this a lot, because my worflow is like
* start editing
* press "save and keep editing" several times after doing some edits
* Press save to go back to the page without making changes.

I know it's irrational, but I intuitivelt feel more comfortable clicking on a button with a positive message (save) instead of a negative one (discard changes) when trying to leave the page.

Comment 1

[John Karahalis [:openjck]]

I don't think that's irrational. I do the same thing.

Anyway, really good idea. I will be sure we look into it.

Comment 3

[Janet Swisher]

See also bug 797845.

Comment 4

[Luke Crouch [:groovecoder]]

Progress: https://github.com/groovecoder/kuma/commit/18b38e19db34e4b007dd3a817cd0e84add4b03f2

Needs:

* Fix test case
* (Probably) Refactor the form code to be more sane

Comment 5

[Federico 'klez' Culloca]

It seems to me this problem has been a solved one for quite a bit.

Since a couple of other bugs depend on this one, can this bug be closed or am I missing something?

Comment 6

[Sebastian Zartner [:sebo]]

Currently the buttons for saving the page are disabled as long as the contents equal the previous revision.
So, I close this as WORKSFORME. If somebody thinks it should work differently, feel free to reopen it.

Sebastian