812682 - Updated eBay Logos for Desktop

Status: RESOLVED FIXED

(Firefox :: Search, defect)

Description

[Joanne Nagel]

Attachment: eBay 16x16 icon file

eBay has recently updated their Logo and request that we update the search drop-down with the new logos for Desktop & Mobile

Comment 1

[Joanne Nagel]

Attachment: eBay 16x16 png file

Sorry, not sure how to upload batch files...

Comment 2

[Joanne Nagel]

Attachment: eBay 32x32 png file

Comment 3

[:Gavin Sharp [email: [e-mail]]]

This is an easy one to pick-up: just a matter of pushing the 16x16 PNG through http://software.hixie.ch/utilities/cgi/data/data with the "base64" option selected, and then replacing the data: URI in the <Image> in http://mxr.mozilla.org/mozilla-central/source/browser/locales/en-US/searchplugins/eBay.xml with the result.

As far as I can tell, we don't have an eBay search for mobile, and bug 795495 isn't fixed yet, so we don't yet have use for the 32x32 version. The 16x16 ICO is a larger file for some reason (does it include both sizes?), so we probably don't need to use that.

Comment 4

[Eric Wong (:ekw)]

Attachment: Patch

Comment 5

[Eric Wong (:ekw)]

Attachment: Screenshot of new ebay logo in search drop-down

Comment 6

[:Gavin Sharp [email: [e-mail]]]

Comment on attachment 684797 [details] [diff] [review]
Patch

Thanks, but I forgot to mention one thing - if you copy out of the Firefox URL bar, you'll get the escaped version, so you need to unescape that. Let's use this:

data:image/png;base64,iVBORw0KGgoAAAANSUhEUgAAABAAAAAQCAYAAAAf8/9hAAABaklEQVQ4jc2TO0hbYQBGz42pMVDrINQuGvrCpZOSoQ4WoZoOxVk7FISCQxy6BEUtSIeCIBTsYCl0cHEQV0GU0lcIIkrpUEGNVYdi6qOtiTH+ubn3c4iTOPSaxbOfM30fkuokzUoy+n/MqVOHpDkP4lk+WpIMUM7FcCxJuqAMgK8U+dzAp5Us9QOr3gJm6RvbLRG2WyI4v3dIH7vcf7VO8/BP9jI2ZqGD3HQN6R/9zCz3AuCqwIeVIfwAf2L9BB+1ocwhtS96cBtGiPfdYnLxgMejmySivRSCtbDxlp3qML/+LbGfXSOV/l4MYNsEwo1cuXObTGcXgfEjynwWNdf8OPkDTLyVQNM0ztZ7Hoae8Tk5TM7+y5PwVDFQFXtO+vUb5LqkooNY1lUaXiaRxMTTIL7dB5hEO2U3u7lReQ+Y5O71CBX+KvC6nPmNMb2LN8sUDiVJl2MH+RJ8xwd8KSHwFRXvPCdvd86fOqETu2NuOELmXqEAAAAASUVORK5CYII=

Comment 7

[Eric Wong (:ekw)]

Attachment: Patch

Unescaped Image data

Comment 8

[:Gavin Sharp [email: [e-mail]]]

Thanks Eric!

Comment 9

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/3220b4cae8b5

Comment 10

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/3220b4cae8b5

Comment 11

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/3220b4cae8b5

Comment 12

[:Gavin Sharp [email: [e-mail]]]

Comment on attachment 685382 [details] [diff] [review]
Patch

Joanne points out via email that it would be good to uplift this change to Aurora/Beta to avoid having to wait until Firefox 20. This is a trivial image swap, no risk and no string changes/etc.

Comment 13

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/22925fa0b92b
https://hg.mozilla.org/releases/mozilla-beta/rev/8207d045d7e6

Comment 14

[:Gavin Sharp [email: [e-mail]]]

Thanks Ryan!

Comment 15

[Scoobidiver (away)]

The eBay logo for non en-US builds is not updated.

Comment 16

[:Gavin Sharp [email: [e-mail]]]

(In reply to Scoobidiver from comment #15)
> The eBay logo for non en-US builds is not updated.

Good catch, I had forgotten about those. We'll have to fix that in a followup, I filed bug 818328.

Comment 17

[Axel Hecht [:Pike]]

Guess you want this for comm-% and thunderbird, too?

Comment 18

[:Gavin Sharp [email: [e-mail]]]

"Want" is a strong word, I don't think there's a strong driver for comm-% and thunderbird to do anything (of course they're free to...).

Comment 19

[Manuela Muntean [Away]]

Verified fixed on the latest beta, Firefox 18 beta 3.

User Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:18.0) Gecko/20100101 Firefox/18.0
Build ID: 20121205060959

Comment 20

[Mitza]

Verified fixed on the latest beta, Firefox 20 beta 6. (Build ID: 20130320062118)

User Agent: Mozilla/5.0 (X11; Linux i686; rv:20.0) Gecko/20100101 Firefox/20.0
User Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:20.0) Gecko/20100101 Firefox/20.0
User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.8; rv:20.0) Gecko/20100101 Firefox/20.0

Comment 21

[Manuela Muntean [Away]]

Setting this to verified, based on comment 20.