813638 - Under Windows Classic Theme Thunderbird 17 title bar is same colour as window background

Status: RESOLVED FIXED

(Thunderbird :: Theme, defect)

Description

[Virgo Pärna]

User Agent: Mozilla/5.0 (Windows NT 5.1; rv:17.0) Gecko/17.0 Firefox/17.0
Build ID: 20121119183901

Steps to reproduce:

Updated Thunderbird to version 17.


Actual results:

Under Windows XP with classic Windows theme Thunderbirds window title bar does not have correct colour (blue when active, dark gray when inactive).



Expected results:

Window title bar should be blue, when active and dark gray, when not inactive.

Comment 1

[Richard Marti (:Paenglab)]

Please can you provide a screenshot? Have you disabled the tabs? With hidden menu bar the tabs would draw in the title bar, then the title bar color change would make the tabs hard readable. To become the color changing title bar back you can do this: Go to Tools/Options.../Advanced/General and click on Config Editor... Then say yes to the warning and search for mail.tabs.drawInTitlebar. Double click it to change to false.

Comment 2

[Virgo Pärna]

Attachment: Screenshot

Here is the requested screenshot. Tabs are not disabled, but they are below the menu bar (isn't it default on Windows XP?). And menu bar is wisible. Setting mail.tabs.drawInTitlebar to false helped, but it should be default, when tabs are below menu bar.

Comment 3

[Vincent (caméléon)]

Maybe also reported here :
https://getsatisfaction.com/mozilla_messaging/topics/thunderbird_17_0_horrible_bright_blue_menu_bar
and
http://forums.mozfr.org/viewtopic.php?f=4&t=109356

Comment 4

[Andy Townsend]

For info I'm seeing exactly the same effect as reported in comment 2 on Windows 7 64-bit.

Setting mail.tabs.drawInTitlebar to false makes the title bar background correct and contain the correct text.

Setting mail.tabs.drawInTitlebar to true makes the title bar background incorrect and contain no text (so you can't see which account you are looking at).

Comment 5

[Andy Townsend]

Actually, after reading 

https://developer.mozilla.org/en-US/docs/Mozilla/Preferences/Preference_reference/mail.tabs.drawInTitlebar 

it's clear that the intended "functionality" of this option (to draw the tabs in the title bar when set to "true") isn't working either.

Comment 6

[Richard Marti (:Paenglab)]

When you hide the menu bar the tabs are in title bar. You can then access the menu bar either by pressing the ALT key or with the mouse on the new button with the three bars, which should be shown on the right of the main tool bar, and then use the Application menu.

Comment 7

[Joe Sabash [:JoeS1]]

As I recall, windows classic theme acted like this bugs complaint.
I don't have that laptop availablr to check now, but the theme that worked correctly had "XP" in the theme name.

Comment 8

[:aceman]

I see this for a long time but I thought it was already filed :)

Comment 9

[John David Galt]

The same (analogously) is true even with Classic View set in the Windows XP UI.  The point is that since this gratuitous UI change, we can no longer tell whether Thunderbird is the active app by looking at its title bar; in effect it no longer HAS a title bar.

Please provide a preference to turn off this change (and all future UI changes, preferably before releasing them!!)

Comment 10

[Richard Marti (:Paenglab)]

(In reply to John David Galt from comment #9)
> Please provide a preference to turn off this change (and all future UI
> changes, preferably before releasing them!!)

Please check comment 1.

Comment 11

[Mike Conley (:mconley) (:⚙️)]

John:

Did flipping mail.tabs.drawInTitlebar to false fix the problem?

-Mike

Comment 12

[John David Galt]

Yes, thanks, that has fixed it for me.

Comment 13

[Mark Banner (:standard8)]

I just did some tests, I can confirm this affects users of the Windows Classic theme on Windows XP and Windows 7.

Comment 14

[Richard Marti (:Paenglab)]

Attachment: proposed fix

This patch adds only on inactive window the inactivecaption color. I added also a rule which makes the menu text visible on inactive background color.

This is only a part of the fix. Maybe we should have a logic where the draw in title bar is on false when the menu is not on auto hide. Aero and Win8 default should stay as they are now because the menu bar is drawn below the tabs. But this would be out of my skills.

Or when draw in title bar is on true then the menu bar is on all this systems below the tabs. Draw in title bar is no system standard then we could also break the menu position standard.

Comment 15

[Richard Marti (:Paenglab)]

Attachment: screenshot with patch in action (on top active on bottom inactive)

Comment 16

[Blake Winton (:bwinton) (:☕️)]

Comment on attachment 686201 [details] [diff] [review]
proposed fix

>+++ b/mail/themes/qute/mail/mailWindow1.css
>@@ -402,24 +402,29 @@
>+#messengerWindow[tabsintitlebar]:-moz-system-metric(windows-classic)
>+menubar > menu:-moz-window-inactive {

Since this is a continuation of the previous line and not a new selector, I think we want to indent it a little.  (I'll let you pick whether 2 or 4 spaces looks better.)

Aside from that, it looks good, so ui-r=me, and r=me!

Thanks,
Blake.

Comment 17

[Richard Marti (:Paenglab)]

Attachment: patch for check-in

I've chosen 2px indentation.

[Approval Request Comment]
This could help to differentiate between active and inactive window under Classic also for ESR17.

Comment 18

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/comm-central/rev/5c47002e482b
https://hg.mozilla.org/releases/comm-aurora/rev/65e60d5672e0
https://hg.mozilla.org/releases/comm-beta/rev/1bdd7893efd9
https://hg.mozilla.org/releases/comm-esr17/rev/359ef8f9ace5

Comment 20

[Bruce Robson]

I've just updated thunderbird from 10.0.12esr to 17.0.2esr and the title bar
was wrong until I set mail.tabs.drawInTitlebar to false. By wrong I mean
a)  colour didn't change when window changes between active/inactive
b)  no title text
c)  no thunderbird icon at the left
This is despite the tracking flags for this bug stating status-thunderbird-esr17: Fixed

I'm running 32-bit Windows XP pro using the classic theme.

Comment 21

[:aceman]

For some reason this got fixed for me only now with latest nightly of 2014-04-29. It works regardless of draw_in_titlebar value.

Comment 22

[Richard Marti (:Paenglab)]

The reason is bug 953204.

Comment 23

[John David Galt]

That's weird, bug 953204 seems to have broken it for me.  The menubar and tabbar background are not supposed to be the same.

Comment 24

[Richard Marti (:Paenglab)]

This bug shouldn't be used for this issue.
John, please can you file a new bug for your problem, if it's on Daily or latest 31.0a2? Please also include screenshots.