81398 - [tabbing] tab focus cycles through form elements in wrong order

Status: VERIFIED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[Michael Schwendt]

Visit above URL, and then notice how pressing TAB moves the cursor to the
various form elements in wrong order.

Same with the "Contact Us" JavaScript-based form here:
http://www.unopiueuropa.de/coming_soon/index_ted.htm

It's not like that with Netscape Navigator 4.77 and neither Opera. TAB should
cycle through the elements from top to bottom, left to right.

Comment 1

[rods (gone)]

Attachment: reduced testcase

Comment 2

[rods (gone)]

The problem with the reduced test case is the the align="left" on the table. if 
you remove that then the tabindex=0 gets the focus, but then it messes up again 
after that.

Also note: My soon to be checked in docshell nav code doesn't change the 
behavior of this.

Also, when the aligh="left" is there the GetNextTabbableContent returns nsnull 
instead of the zero'th item.

Comment 3

[saari (gone)]

-> for tabbing fun

Comment 4

[Brian Ryner (not reading)]

*** Bug 90355 has been marked as a duplicate of this bug. ***

Comment 5

[Brian Ryner (not reading)]

moving these out to 0.9.5 since it doesn't look like I will have time for 0.9.4.

Comment 6

[Brian Ryner (not reading)]

Ok, the problem here was that we weren't properly handling placeholder frames. 
I've rewritten the frame traversal for tabbing to take into account placeholder
frames and give the real frame instead.  In addition to this bug, this fixes
85217 and 88740.

Comment 7

[Brian Ryner (not reading)]

Attachment: patch

Comment 8

[saari (gone)]

okay, code looks good, r=saari with testing to death

Comment 9

[Brian Ryner (not reading)]

Attachment: patch

Comment 10

[Brian Ryner (not reading)]

The new patch has the same basic idea, just some logic cleanup and optimization.

Comment 11

[saari (gone)]

r=saari again, looks good

Comment 12

[Brian Ryner (not reading)]

Comment on attachment 48123 [details] [diff] [review]
patch

updating from saari's r=

Comment 13

[David Hyatt]

sr=hyatt

Comment 14

[Brian Ryner (not reading)]

fix checked in.

Comment 15

[Vladimir Ermakov]

The tab doesnt even go into the page, it tabs from url bar to the sidebar, and
back... When you click on one of the fields in the testcase and press tab it
tabs to the link and then to the url bar and you cant tab back to the page.
Reopening. This is on windows 98 so I'm changing platform to all. Increasing
severity to normal, because you cannot acess form fields with tab at all. 

Comment 16

[Brian Ryner (not reading)]

What build are you seeing this on?

Comment 17

[Vladimir Ermakov]

2001-10-08-05-0.9.4 build on windows 98 for example

Comment 18

[Brian Ryner (not reading)]

If you test on a trunk build, you should see that this is fixed.  Please don't
reopen bugs because they aren't fixed in 0.9.4 builds if they were checked in
after 0.9.4 branched (which was on 9/4).  If you'd like to nominate it for
checkin on the 0.9.4 branch, add the appropriate keywords.  I'm going to go
ahead and remark this as fixed.

Thanks.

Comment 19

[Vladimir Ermakov]

[e-mail]: The current behaviour is that tabindex 1 gets selected
first, then tabindex 2, only then tabindex 0 is selected...

This is the same behaviour as IE, but I would guess it should go to 0 before
going to one... is this a bug?

Comment 20

[Brian Ryner (not reading)]

No, the HTML spec defines it to work this way.

Comment 21

[Vladimir Ermakov]

Heh, read right over it :)

Verifying on windows 98 2002-01-07-03-trunk and linux RedHat
2002-01-04-08-trunk