Closed Bug 814701 Opened 7 years ago Closed 7 years ago

toolkit/components/downloads/test/unit/test_privatebrowsing.js fails on Birch

Categories

(Toolkit :: Downloads API, defect)

x86_64
Linux
defect
Not set

Tracking

()

RESOLVED FIXED
mozilla20

People

(Reporter: ehsan, Assigned: bellindira)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

This is broken because the test assumes that the cancellation prompt will occur when entering private browsing mode and downloads are active. When per-window mode is enabled, the prompt only appears when exiting PB mode and downloads are active.
Assignee: nobody → bellindira
Status: NEW → ASSIGNED
The test does the following:
* Open a normal window.
* Create a download (Download-A) with specific details.
* Check that Download-A is retrievable.
* Open a private window.
* Check that Download-A is accessible.
* Create another download (Download-B) with specific and different details.
* Check that Download-B is not retrievable.
* Open a normal window.
* Check that Download-A is retrievable.
* Check that Download-B is not accessible.

Notice: There are two major differences:
1) On normal mode (no per-window) the test checks if a "public download" is paused when entering to PB mode and resumed when exiting PB. However, in per-window mode a "public download" is never paused/resumed when entering/exiting a private window. 
2) Download-B (download in private window) is never retrievable on per-window scheme.

BTW, I was wondering if it must be added an skip if = MOZ_PER_WINDOW_PRIVATE_BROWSING for test [test_privatebrowsing.js] on xpcshell.ini. Something like this:
skip-if = MOZ_PER_WINDOW_PRIVATE_BROWSING == 1
Attachment #685780 - Flags: review?(ehsan)
(In reply to Bellindira Castillo [:bellindira] from comment #2)
> BTW, I was wondering if it must be added an skip if =
> MOZ_PER_WINDOW_PRIVATE_BROWSING for test [test_privatebrowsing.js] on
> xpcshell.ini. Something like this:
> skip-if = MOZ_PER_WINDOW_PRIVATE_BROWSING == 1

Yes, but you should use the "perwindowprivatebrowsing" flag that I added in bug 814748.
(In reply to Ehsan Akhgari [:ehsan] from comment #3)
> (In reply to Bellindira Castillo [:bellindira] from comment #2)
> > BTW, I was wondering if it must be added an skip if =
> > MOZ_PER_WINDOW_PRIVATE_BROWSING for test [test_privatebrowsing.js] on
> > xpcshell.ini. Something like this:
> > skip-if = MOZ_PER_WINDOW_PRIVATE_BROWSING == 1
> 
> Yes, but you should use the "perwindowprivatebrowsing" flag that I added in
> bug 814748.

I'll do that myself when landing!  :-)
Attachment #685780 - Flags: review?(ehsan) → review+
https://hg.mozilla.org/mozilla-central/rev/c1859634b922
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla20
This test fails on Windows on the Birch branch:

https://tbpl.mozilla.org/php/getParsedLog.php?id=17481033&tree=Birch
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Bug 814700 added some changes to this test. After those changes, is this test still failing?
No, looks like it's fixed now.  Thanks for mentioning it.
Status: REOPENED → RESOLVED
Closed: 7 years ago7 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.