Closed Bug 814952 Opened 10 years ago Closed 10 years ago

[Azure] Svg ellipse with stroke but no fill is not displayed.

Categories

(Core :: Graphics, defect)

17 Branch
x86_64
Windows 7
defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla20
Tracking Status
firefox17 --- wontfix
firefox18 + wontfix
firefox19 + verified
firefox20 + fixed
firefox-esr17 --- wontfix

People

(Reporter: Annon0m0s, Assigned: bas.schouten)

References

()

Details

(Keywords: regression, testcase)

Attachments

(3 files, 2 obsolete files)

User Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:17.0) Gecko/17.0 Firefox/17.0
Build ID: 20121119183901

Steps to reproduce:

Show static svg page.


Actual results:

The page show one ellipse and two rectangles.


Expected results:

It should have shown two ellipses and two rectangles. The ellipse which is not shown has no fill but does have a stroke. The similar rectangle with no fill but has a stroke does display properly.  The ellipse and rectangle with fills display properly.  This shows correctly in Chrome.
I can confirm
http://hg.mozilla.org/mozilla-central/rev/d7841347b558
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:20.0) Gecko/20.0 Firefox/20.0 ID:20121124130632


setting gfx.content.azure.enabled to false helps.
Blocks: 715768
Status: UNCONFIRMED → NEW
Component: Untriaged → Graphics
Ever confirmed: true
Keywords: regression
Product: Firefox → Core
Summary: Svg ellipse with stroke but no fill is not displayed. → [Azure]Svg ellipse with stroke but no fill is not displayed.
Target Milestone: --- → mozilla17
Target Milestone: mozilla17 → ---
Keywords: testcase
Summary: [Azure]Svg ellipse with stroke but no fill is not displayed. → [Azure] Svg ellipse with stroke but no fill is not displayed.
Assignee: nobody → bas
Status: NEW → ASSIGNED
Comment on attachment 687616 [details] [diff] [review]
Further refactor and cleanup path state management

This patch gets rid of all shortcuts and should just do completely correct Cairo emulation. That way hopefully we'll stop running into these terrible edge cases.
Attachment #687616 - Flags: review? → review?(jmuizelaar)
Duplicate of this bug: 818963
Attached patch Add a reftest (obsolete) — Splinter Review
Attachment #689694 - Flags: review?(jmuizelaar)
I think you need to hg add the reftest file.
(workaround : if you set a white background - and don't let the ellipse background set to none - the ellipse shows as expected)
PS: sorry for the spam, but the bugs shows in Google search...
Comment on attachment 689694 [details] [diff] [review]
Add a reftest

Review of attachment 689694 [details] [diff] [review]:
-----------------------------------------------------------------

The reftest is not included in this patch
Attachment #689694 - Flags: review?(jmuizelaar) → review-
Attachment #687616 - Flags: review?(jmuizelaar) → review+
Attached patch Add a reftest v2 (obsolete) — Splinter Review
Fixed.
Attachment #689694 - Attachment is obsolete: true
Attachment #690944 - Flags: review?(jmuizelaar)
Something seems to have gone wrong with reftest.list.
Attached patch Add a reftest v3Splinter Review
Thanks, looks like Mercurial mysteriously screwed up the Merge.
Attachment #690944 - Attachment is obsolete: true
Attachment #690944 - Flags: review?(jmuizelaar)
Attachment #690950 - Flags: review?(jmuizelaar)
Comment on attachment 690950 [details] [diff] [review]
Add a reftest v3

Review of attachment 690950 [details] [diff] [review]:
-----------------------------------------------------------------

::: layout/reftests/bugs/814952-1.html
@@ +11,5 @@
> +        }
> +
> +
> +    </style>
> +

Probably don't need so much white space here :)
Attachment #690950 - Flags: review?(jmuizelaar) → review+
https://hg.mozilla.org/mozilla-central/rev/fa72584497cb
https://hg.mozilla.org/mozilla-central/rev/950611b8b91c
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla20
If this is low risk (despite the build issue), please nominate for uplift so that we can get this into our fifth beta, going to build Tuesday.
Jeff, can you please help with branch nomination/landings as requested in comment# 16, as Bas is Out ?
Comment on attachment 687616 [details] [diff] [review]
Further refactor and cleanup path state management

[Approval Request Comment]
Bug caused by (feature/regressing bug #): 715768
User impact if declined: certain SVG content can render incorrectly
Testing completed (on m-c, etc.): Has been on m-c for a while, and we have some decent svg tests
Risk to taking this patch (and alternatives if risky): A limited amount of svg content would draw wrong. The patch is fairly invasive which is unfortunate. It may be that any bugs caused by this patch may not turn up until we release anyways, so the extra testing time might not help.
Attachment #687616 - Flags: approval-mozilla-beta?
Attachment #687616 - Flags: approval-mozilla-aurora?
Comment on attachment 687616 [details] [diff] [review]
Further refactor and cleanup path state management

Approving the patch for aurora only .Considering the risk analysis and where we are in the cycle giving an a- for beta & prefer this gets good aurora testing.
Attachment #687616 - Flags: approval-mozilla-beta?
Attachment #687616 - Flags: approval-mozilla-beta-
Attachment #687616 - Flags: approval-mozilla-aurora?
Attachment #687616 - Flags: approval-mozilla-aurora+
Duplicate of this bug: 823032
Duplicate of this bug: 830427
Reproduced the issue on Nightly 2012-12-01 using the STR in comment 0.
Verified fixed Mozilla/5.0 (Windows NT 6.1; WOW64; rv:19.0) Gecko/20100101 Firefox/19.0b4
Not a critical security issue, neither a esr-specific regression or a is causing instability on esr, hence marking it wontfix.
You need to log in before you can comment on or make changes to this bug.