814952 - [Azure] Svg ellipse with stroke but no fill is not displayed.

Status: RESOLVED FIXED

(Core :: Graphics, defect)

Description

[Annon0m0s]

Attachment: bug_ff_ellipse_stroke_no_fill.svg

User Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:17.0) Gecko/17.0 Firefox/17.0
Build ID: 20121119183901

Steps to reproduce:

Show static svg page.


Actual results:

The page show one ellipse and two rectangles.


Expected results:

It should have shown two ellipses and two rectangles. The ellipse which is not shown has no fill but does have a stroke. The similar rectangle with no fill but has a stroke does display properly.  The ellipse and rectangle with fills display properly.  This shows correctly in Chrome.

Comment 1

[Alice0775 White]

I can confirm
http://hg.mozilla.org/mozilla-central/rev/d7841347b558
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:20.0) Gecko/20.0 Firefox/20.0 ID:20121124130632


setting gfx.content.azure.enabled to false helps.

Comment 2

[Bas Schouten (:bas.schouten)]

Attachment: Further refactor and cleanup path state management

Comment 3

[Bas Schouten (:bas.schouten)]

Comment on attachment 687616 [details] [diff] [review]
Further refactor and cleanup path state management

This patch gets rid of all shortcuts and should just do completely correct Cairo emulation. That way hopefully we'll stop running into these terrible edge cases.

Comment 5

[Bas Schouten (:bas.schouten)]

Attachment: Add a reftest

Comment 6

[Robert Longson [:longsonr]]

I think you need to hg add the reftest file.

Comment 7

[aveclafaux]

(workaround : if you set a white background - and don't let the ellipse background set to none - the ellipse shows as expected)
PS: sorry for the spam, but the bugs shows in Google search...

Comment 8

[Jeff Muizelaar [:jrmuizel]]

Comment on attachment 689694 [details] [diff] [review]
Add a reftest

Review of attachment 689694 [details] [diff] [review]:
-----------------------------------------------------------------

The reftest is not included in this patch

Comment 9

[Bas Schouten (:bas.schouten)]

Attachment: Add a reftest v2

Fixed.

Comment 10

[Robert Longson [:longsonr]]

Something seems to have gone wrong with reftest.list.

Comment 11

[Bas Schouten (:bas.schouten)]

Attachment: Add a reftest v3

Thanks, looks like Mercurial mysteriously screwed up the Merge.

Comment 12

[Jeff Muizelaar [:jrmuizel]]

Comment on attachment 690950 [details] [diff] [review]
Add a reftest v3

Review of attachment 690950 [details] [diff] [review]:
-----------------------------------------------------------------

::: layout/reftests/bugs/814952-1.html
@@ +11,5 @@
> +        }
> +
> +
> +    </style>
> +

Probably don't need so much white space here :)

Comment 13

[(no longer active)]

Backed out since this doesn't build: https://hg.mozilla.org/integration/mozilla-inbound/rev/edd575426780

Comment 14

[Bas Schouten (:bas.schouten)]

http://hg.mozilla.org/integration/mozilla-inbound/rev/fa72584497cb
http://hg.mozilla.org/integration/mozilla-inbound/rev/950611b8b91c

Adjusted for some weird (maybe per spec?) GCC behavior.

Comment 15

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/fa72584497cb
https://hg.mozilla.org/mozilla-central/rev/950611b8b91c

Comment 16

[Alex Keybl [:akeybl]]

If this is low risk (despite the build issue), please nominate for uplift so that we can get this into our fifth beta, going to build Tuesday.

Comment 17

[bhavana bajaj [:bajaj]]

Jeff, can you please help with branch nomination/landings as requested in comment# 16, as Bas is Out ?

Comment 18

[Jeff Muizelaar [:jrmuizel]]

Comment on attachment 687616 [details] [diff] [review]
Further refactor and cleanup path state management

[Approval Request Comment]
Bug caused by (feature/regressing bug #): 715768
User impact if declined: certain SVG content can render incorrectly
Testing completed (on m-c, etc.): Has been on m-c for a while, and we have some decent svg tests
Risk to taking this patch (and alternatives if risky): A limited amount of svg content would draw wrong. The patch is fairly invasive which is unfortunate. It may be that any bugs caused by this patch may not turn up until we release anyways, so the extra testing time might not help.

Comment 19

[bhavana bajaj [:bajaj]]

Comment on attachment 687616 [details] [diff] [review]
Further refactor and cleanup path state management

Approving the patch for aurora only .Considering the risk analysis and where we are in the cycle giving an a- for beta & prefer this gets good aurora testing.

Comment 20

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/54367ea8db11
https://hg.mozilla.org/releases/mozilla-aurora/rev/d82433e6a75d

https://hg.mozilla.org/releases/mozilla-beta/rev/f14e44074da0
https://hg.mozilla.org/releases/mozilla-beta/rev/3418ab85117b

Comment 21

[bhavana bajaj [:bajaj]]

(In reply to Ryan VanderMeulen from comment #20)
> https://hg.mozilla.org/releases/mozilla-aurora/rev/54367ea8db11
> https://hg.mozilla.org/releases/mozilla-aurora/rev/d82433e6a75d
> 
> https://hg.mozilla.org/releases/mozilla-beta/rev/f14e44074da0
> https://hg.mozilla.org/releases/mozilla-beta/rev/3418ab85117b

Ryan, this was not approved for beta, check comment 19.can you please do the needed backout ?

Comment 22

[Ryan VanderMeulen [:RyanVM]]

Gah, saw a + there rather than a -. Backed out of beta.
https://hg.mozilla.org/releases/mozilla-beta/rev/78e698f8ed54

Comment 25

[Paul Silaghi, QA [:pauly]]

Reproduced the issue on Nightly 2012-12-01 using the STR in comment 0.
Verified fixed Mozilla/5.0 (Windows NT 6.1; WOW64; rv:19.0) Gecko/20100101 Firefox/19.0b4

Comment 26

[bhavana bajaj [:bajaj]]

Not a critical security issue, neither a esr-specific regression or a is causing instability on esr, hence marking it wontfix.