[Azure] Svg ellipse with stroke but no fill is not displayed.

RESOLVED FIXED in Firefox 19

Status

()

Core
Graphics
RESOLVED FIXED
5 years ago
4 years ago

People

(Reporter: Annon0m0s, Assigned: bas)

Tracking

({regression, testcase})

17 Branch
mozilla20
x86_64
Windows 7
regression, testcase
Points:
---
Bug Flags:
in-testsuite +

Firefox Tracking Flags

(firefox17 wontfix, firefox18+ wontfix, firefox19+ verified, firefox20+ fixed, firefox-esr17 wontfix)

Details

(URL)

Attachments

(3 attachments, 2 obsolete attachments)

(Reporter)

Description

5 years ago
Created attachment 684942 [details]
bug_ff_ellipse_stroke_no_fill.svg

User Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:17.0) Gecko/17.0 Firefox/17.0
Build ID: 20121119183901

Steps to reproduce:

Show static svg page.


Actual results:

The page show one ellipse and two rectangles.


Expected results:

It should have shown two ellipses and two rectangles. The ellipse which is not shown has no fill but does have a stroke. The similar rectangle with no fill but has a stroke does display properly.  The ellipse and rectangle with fills display properly.  This shows correctly in Chrome.

Comment 1

5 years ago
I can confirm
http://hg.mozilla.org/mozilla-central/rev/d7841347b558
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:20.0) Gecko/20.0 Firefox/20.0 ID:20121124130632


setting gfx.content.azure.enabled to false helps.
Blocks: 715768
Status: UNCONFIRMED → NEW
tracking-firefox18: --- → ?
tracking-firefox19: --- → ?
tracking-firefox20: --- → ?
tracking-firefox-esr17: --- → ?
Component: Untriaged → Graphics
Ever confirmed: true
Keywords: regression
Product: Firefox → Core
Summary: Svg ellipse with stroke but no fill is not displayed. → [Azure]Svg ellipse with stroke but no fill is not displayed.
Target Milestone: --- → mozilla17

Updated

5 years ago
Target Milestone: mozilla17 → ---
Keywords: testcase
Summary: [Azure]Svg ellipse with stroke but no fill is not displayed. → [Azure] Svg ellipse with stroke but no fill is not displayed.
(Assignee)

Updated

5 years ago
Assignee: nobody → bas
Status: NEW → ASSIGNED

Updated

5 years ago
tracking-firefox18: ? → +
tracking-firefox19: ? → +
tracking-firefox20: ? → +
tracking-firefox-esr17: ? → ---
(Assignee)

Comment 2

5 years ago
Created attachment 687616 [details] [diff] [review]
Further refactor and cleanup path state management
Attachment #687616 - Flags: review?
(Assignee)

Comment 3

5 years ago
Comment on attachment 687616 [details] [diff] [review]
Further refactor and cleanup path state management

This patch gets rid of all shortcuts and should just do completely correct Cairo emulation. That way hopefully we'll stop running into these terrible edge cases.
Attachment #687616 - Flags: review? → review?(jmuizelaar)
(Assignee)

Updated

5 years ago
Duplicate of this bug: 818963
(Assignee)

Comment 5

5 years ago
Created attachment 689694 [details] [diff] [review]
Add a reftest
Attachment #689694 - Flags: review?(jmuizelaar)

Comment 6

5 years ago
I think you need to hg add the reftest file.

Comment 7

5 years ago
(workaround : if you set a white background - and don't let the ellipse background set to none - the ellipse shows as expected)
PS: sorry for the spam, but the bugs shows in Google search...
Comment on attachment 689694 [details] [diff] [review]
Add a reftest

Review of attachment 689694 [details] [diff] [review]:
-----------------------------------------------------------------

The reftest is not included in this patch
Attachment #689694 - Flags: review?(jmuizelaar) → review-
Attachment #687616 - Flags: review?(jmuizelaar) → review+
(Assignee)

Comment 9

5 years ago
Created attachment 690944 [details] [diff] [review]
Add a reftest v2

Fixed.
Attachment #689694 - Attachment is obsolete: true
Attachment #690944 - Flags: review?(jmuizelaar)

Comment 10

5 years ago
Something seems to have gone wrong with reftest.list.
(Assignee)

Comment 11

5 years ago
Created attachment 690950 [details] [diff] [review]
Add a reftest v3

Thanks, looks like Mercurial mysteriously screwed up the Merge.
Attachment #690944 - Attachment is obsolete: true
Attachment #690944 - Flags: review?(jmuizelaar)
Attachment #690950 - Flags: review?(jmuizelaar)
Comment on attachment 690950 [details] [diff] [review]
Add a reftest v3

Review of attachment 690950 [details] [diff] [review]:
-----------------------------------------------------------------

::: layout/reftests/bugs/814952-1.html
@@ +11,5 @@
> +        }
> +
> +
> +    </style>
> +

Probably don't need so much white space here :)
Attachment #690950 - Flags: review?(jmuizelaar) → review+
Backed out since this doesn't build: https://hg.mozilla.org/integration/mozilla-inbound/rev/edd575426780
(Assignee)

Comment 14

5 years ago
http://hg.mozilla.org/integration/mozilla-inbound/rev/fa72584497cb
http://hg.mozilla.org/integration/mozilla-inbound/rev/950611b8b91c

Adjusted for some weird (maybe per spec?) GCC behavior.
https://hg.mozilla.org/mozilla-central/rev/fa72584497cb
https://hg.mozilla.org/mozilla-central/rev/950611b8b91c
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
status-firefox20: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla20
If this is low risk (despite the build issue), please nominate for uplift so that we can get this into our fifth beta, going to build Tuesday.
status-firefox17: --- → affected
status-firefox18: --- → affected
status-firefox19: --- → affected
Jeff, can you please help with branch nomination/landings as requested in comment# 16, as Bas is Out ?
Comment on attachment 687616 [details] [diff] [review]
Further refactor and cleanup path state management

[Approval Request Comment]
Bug caused by (feature/regressing bug #): 715768
User impact if declined: certain SVG content can render incorrectly
Testing completed (on m-c, etc.): Has been on m-c for a while, and we have some decent svg tests
Risk to taking this patch (and alternatives if risky): A limited amount of svg content would draw wrong. The patch is fairly invasive which is unfortunate. It may be that any bugs caused by this patch may not turn up until we release anyways, so the extra testing time might not help.
Attachment #687616 - Flags: approval-mozilla-beta?
Attachment #687616 - Flags: approval-mozilla-aurora?
Comment on attachment 687616 [details] [diff] [review]
Further refactor and cleanup path state management

Approving the patch for aurora only .Considering the risk analysis and where we are in the cycle giving an a- for beta & prefer this gets good aurora testing.
Attachment #687616 - Flags: approval-mozilla-beta?
Attachment #687616 - Flags: approval-mozilla-beta-
Attachment #687616 - Flags: approval-mozilla-aurora?
Attachment #687616 - Flags: approval-mozilla-aurora+
https://hg.mozilla.org/releases/mozilla-aurora/rev/54367ea8db11
https://hg.mozilla.org/releases/mozilla-aurora/rev/d82433e6a75d

https://hg.mozilla.org/releases/mozilla-beta/rev/f14e44074da0
https://hg.mozilla.org/releases/mozilla-beta/rev/3418ab85117b
status-firefox18: affected → fixed
status-firefox19: affected → fixed
Flags: in-testsuite+
(In reply to Ryan VanderMeulen from comment #20)
> https://hg.mozilla.org/releases/mozilla-aurora/rev/54367ea8db11
> https://hg.mozilla.org/releases/mozilla-aurora/rev/d82433e6a75d
> 
> https://hg.mozilla.org/releases/mozilla-beta/rev/f14e44074da0
> https://hg.mozilla.org/releases/mozilla-beta/rev/3418ab85117b

Ryan, this was not approved for beta, check comment 19.can you please do the needed backout ?
Gah, saw a + there rather than a -. Backed out of beta.
https://hg.mozilla.org/releases/mozilla-beta/rev/78e698f8ed54
status-firefox17: affected → wontfix
status-firefox18: fixed → wontfix
status-firefox-esr17: --- → affected

Updated

5 years ago
Duplicate of this bug: 823032

Updated

4 years ago
Duplicate of this bug: 830427
Reproduced the issue on Nightly 2012-12-01 using the STR in comment 0.
Verified fixed Mozilla/5.0 (Windows NT 6.1; WOW64; rv:19.0) Gecko/20100101 Firefox/19.0b4
status-firefox19: fixed → verified
Not a critical security issue, neither a esr-specific regression or a is causing instability on esr, hence marking it wontfix.
status-firefox-esr17: affected → wontfix
You need to log in before you can comment on or make changes to this bug.