Closed
Bug 815492
Opened 12 years ago
Closed 11 years ago
Pause Web Audio streams when we go into the bfcache
Categories
(Core :: Web Audio, defect)
Tracking
()
RESOLVED
FIXED
mozilla22
People
(Reporter: ehsan.akhgari, Assigned: ehsan.akhgari)
References
Details
Attachments
(1 file)
3.21 KB,
patch
|
bzbarsky
:
review+
|
Details | Diff | Splinter Review |
Boris, can you please explain what we should do here? Thanks!
Comment 1•12 years ago
|
||
So the basic idea is that when a page is unloaded we should stop playing sound from it, whether it's going into bfache or whether the window is being torn down. Bug 814789 does the latter, because nsGlobalWindow::SetNewDocument does this: if (!currentInner->IsFrozen()) { currentInner->FreeInnerObjects(); } before switching to the new inner. To handle the bfache case, I think what we want to do is something along the lines of nsGlobalWindow::SuspendTimeouts and nsGlobalWindow::ResumeTimeouts (as called from WindowStateHolder::WindowStateHolder and nsDocShell::RestoreFromHistory, though for the latter we may be able to do it from nsGlobalWindow::RestoreWindowState instead). And we'll need to basically pause/resume the audio there, all the way down the window tree.
Assignee | ||
Updated•11 years ago
|
Assignee: nobody → ehsan
Assignee | ||
Comment 3•11 years ago
|
||
Attachment #728022 -
Flags: review?(bzbarsky)
Comment 4•11 years ago
|
||
Comment on attachment 728022 [details] [diff] [review] Patch (v1) r=me
Attachment #728022 -
Flags: review?(bzbarsky) → review+
Assignee | ||
Comment 5•11 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/fe50f4cbc119
Comment 6•11 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/fe50f4cbc119
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla22
Assignee | ||
Comment 7•11 years ago
|
||
Mass moving Web Audio bugs to the Web Audio component. Filter on duckityduck.
Component: Video/Audio → Web Audio
You need to log in
before you can comment on or make changes to this bug.
Description
•