816279 - Add SHOWFOR support for Thunderbird to SUMO

Status: RESOLVED FIXED

(support.mozilla.org :: Knowledge Base Software, task, P2)

Description

[Roland Tanglao needinfo please :rolandtanglao, :mohnkuchen, :adobo, :sinigang, :roland]

For the multiple platform sprint currently scheduled for the week of December 10, 2012, add SHOWFOR support for Thunderbird. (Kadir, please close this bug if you already have a bug for this; i couldn't find one )

Comment 1

[David Weir (satdav)]

For this happen

Comment 2

[Ricky Rosario [:rrosario, :r1cky]]

2012Q4 is in the past. Moving on to the future!

Comment 3

[Andrei Hajdukewycz [:sancus]]

Err, this is a support.mozilla.org bug. It's not a support.mozillamessaging.com bug.

Comment 4

[Roland Tanglao needinfo please :rolandtanglao, :mohnkuchen, :adobo, :sinigang, :roland]

:sancus showfor has been rewritten so adding thunderbird support should be easier now:

1. demo of rewrite

https://rawgithub.com/mythmon/kitsune/fxos-showfor-915686/kitsune/sumo/static/showfordemo.html

2. test cases

https://gist.github.com/mythmon/7236259

sancus will you have time to write the thunderbird  support in Q4 or in early Q1 2014? if not no biggie, we'll just assign this bug to another dev!

Comment 5

[Roland Tanglao needinfo please :rolandtanglao, :mohnkuchen, :adobo, :sinigang, :roland]

:sancus the showfor rewrite happend in bug 915686

Comment 6

[Kadir Topal [:atopal]]

Adding this to the backlog for now. If it's simple to implement we should do it this quarter. If not, we can leave it till next quarter when we actually move the content.

Mike, can you comment on the effort needed to support an additional product/version with the new showfor code?

Comment 7

[Michael Cooper [:mythmon]]

It depends on the level of interaction with other products, and how well it corresponds to the general model in the new showfor.

That being said, to add Thunderbird to the new showfor should be really easy. Optimistically, it might be able to be done entirely in the database, but more likely it would require about 1 point worth of updates to the showfor code to make sure it all works.

Comment 8

[Kadir Topal [:atopal]]

Thanks for the info, Mike. Adding this to the next sprint, so we can use the time till next quarter to test the migration of content.

Comment 9

[Roland Tanglao needinfo please :rolandtanglao, :mohnkuchen, :adobo, :sinigang, :roland]

(In reply to Mike Cooper [:mythmon] from comment #7)
> It depends on the level of interaction with other products, and how well it
> corresponds to the general model in the new showfor.
> 
i don't think there is any level of  interaction with other products.
and the model of showfor for thunderbird should be 100% identical to firefox desktop. Also there is no need for exceptions i.e. there is no thunderbird equivalent of firefox 3.5, firefox 3.6 and other firefox exceptions. Thunderbird does have exceptions but they are sooooo old we can ignore them.

> That being said, to add Thunderbird to the new showfor should be really
> easy. Optimistically, it might be able to be done entirely in the database,
> but more likely it would require about 1 point worth of updates to the
> showfor code to make sure it all works.

Comment 10

[Roland Tanglao needinfo please :rolandtanglao, :mohnkuchen, :adobo, :sinigang, :roland]

finally it's *SUPER* awesome that this is only 1 point and that mike and the awesome some devs are working on this. Further questions on thunderbird showfor please don't heitate to "needinfo" me or ping me on IRC

Comment 11

[Ricky Rosario [:rrosario, :r1cky]]

(In reply to Roland Tanglao :rolandtanglao from comment #10)
> finally it's *SUPER* awesome that this is only 1 point

To be clear, it's 1pt to add support. Most of the work will be actually migrating the entire knowledge base over.

Comment 12

[Roland Tanglao needinfo please :rolandtanglao, :mohnkuchen, :adobo, :sinigang, :roland]

> (In reply to Roland Tanglao :rolandtanglao from comment #10)
> > finally it's *SUPER* awesome that this is only 1 point
> 
> To be clear, it's 1pt to add support. Most of the work will be actually
> migrating the entire knowledge base over.
thanks for the clarification; it's what i thought; sorry for being unclear. luckily fingers crossed sumo-dev won't be required for the rest of the kb migration. hopefully me and sancus can take care of the other aspects of migration which are covered in the other bugs.(In reply to Ricky Rosario [:rrosario, :r1cky] from comment #11)

Comment 13

[Ricky Rosario [:rrosario, :r1cky]]

Making 1pt based on Comment 7. Assigning to :mythmon.

Comment 14

[Ricky Rosario [:rrosario, :r1cky]]

Clearing needinfo on sancus. I think we'll need a followup bug for the actual migration of content if it doesn't exist yet.

Comment 15

[Roland Tanglao needinfo please :rolandtanglao, :mohnkuchen, :adobo, :sinigang, :roland]

(In reply to Ricky Rosario [:rrosario, :r1cky] from comment #14)
> Clearing needinfo on sancus. I think we'll need a followup bug for the
> actual migration of content if it doesn't exist yet.

the actual migration of content is covered by:

bug 816277 " Create Database Dump of SuMoMo KB articles and migrate to SUMO staging on allizom.org "

bug 820553 " Add SUMO topics to Thunderbird articles once they are migrated from SuMoMo "

Comment 16

[Kadir Topal [:atopal]]

Roland, we should add topics before we migrate articles (at least that would create the least amount of work). We can already go ahead and add TB as a product and add the topics, before we migrate articles next year.

Comment 17

[Michael Cooper [:mythmon]]

The code changes here were really very minimal. However, now we need to add Thunderbird as a topic in the site admin, and add all it's versions in the site admin. This should be pretty easy, but I'm going to leave the bug open until that is done.

PR: https://github.com/mozilla/kitsune/pull/1748
Landed in: https://github.com/mythmon/kitsune/commit/fd916d8c94b6cd4e1547d31eb57cd4531f0e79a8

Comment 18

[Kadir Topal [:atopal]]

Roland, can you comment on the Thnderbird versions and platforms we'd want to support?

Comment 19

[Roland Tanglao needinfo please :rolandtanglao, :mohnkuchen, :adobo, :sinigang, :roland]

(In reply to Kadir Topal [:atopal] from comment #18)
> Roland, can you comment on the Thnderbird versions and platforms we'd want
> to support?

versions: thundebird 17 and above

platforms: mac, windows and linux

Comment 20

[Kadir Topal [:atopal]]

So, it's Thunderbird 17 and 24, right?

Also, the shortcode is "tb", right? So, it would be tb17 and tb24.

Comment 21

[Roland Tanglao needinfo please :rolandtanglao, :mohnkuchen, :adobo, :sinigang, :roland]

(In reply to Kadir Topal [:atopal] from comment #20)
> So, it's Thunderbird 17 and 24, right?
> 
> Also, the shortcode is "tb", right? So, it would be tb17 and tb24.

yup shortcode:"tb", "tb17" and "tb24" and "tb31" and "tb38" etc :-)
we can ignore any version of thunderbird less than thunderbird 17 (i.e. we will not migrate any content where the following showfors are used:tb3, tb5, tb6, tb7, tb8, tb9, tb10, tb11, tb12, tb13, tb14, tb15 and tb16 are used)
some obsolete info here:
https://support.mozillamessaging.com/en-US/kb/markup-and-templates#w_showfor-for

Comment 22

[Michael Cooper [:mythmon]]

Roland: Can you add these in the SUMO admin? I could do it, but I think that this feature needs to be socialized a bit, instead of just me fiddling all the bits. It would help with the bus number of showfor :)

To do this, you need to first add a Product object for Thunderbird, and then add Version objects for each version you want supported.

Comment 23

[Verdi [:verdi] Best to slack me]

(In reply to Mike Cooper [:mythmon] from comment #22)
> Roland: Can you add these in the SUMO admin? I could do it, but I think that
> this feature needs to be socialized a bit, instead of just me fiddling all
> the bits. It would help with the bus number of showfor :)
> 
> To do this, you need to first add a Product object for Thunderbird, and then
> add Version objects for each version you want supported.

Mike maybe you can help Ibai and Roland update this article* and add products to it https://support.mozilla.org/en-US/kb/topics-subtopics I think there is more than just creating a product. For example, we probably don't want a new Thunderbird product to be visible right now.

*Ibai & Roland were going to write this doc https://etherpad.mozilla.org/sumo-p-2013-06-06

Comment 24

[Kadir Topal [:atopal]]

Actually, I created the product and topics last week and I had already added the versions when I asked Roland to confirm. We should be good to go. 

Mike, anything else that we might be missing?

Comment 25

[Michael Cooper [:mythmon]]

Ah, fantastic! Someone can use that system besides me. When we start adding content that uses Thunderbird, it should be available for Showfor. I think we are done here, so I'll mark it as RESOFIXED.

Comment 26

[Kadir Topal [:atopal]]

Wooho!, We are ready for the Thunderbird migration. Thanks for all your work, Mike!