816295 - [Gallery] Unable to delete Videos and Images from the Gallery app

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::Gallery, defect, P2)

Description

[Deepa Subramanian]

User Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:17.0) Gecko/17.0 Firefox/17.0
Build ID: 20121119183901

Steps to reproduce:

Unagi Build ID: 20121128071138 OS Version: 1.0.0 
1. Select gallery App from device
2. Select thumbnail view
3. Tap the "selection mode" button next to the "Camera button" at the bottom
4. Select 2 photos 
5. Tap delete button on the bottom 


Actual results:

Tapping delete button does not prompt for a confirmation message to delete the photos


Expected results:

Message to confirm the delete action should be prompted to the user

Comment 1

[David Flanagan [:djf]]

This is caused by a regression that breaks window.confirm()
I don't have a bug number yet.

Comment 2

[Tony Chung [:tchung]]

This affects both videos and images in the gallery app.

Comment 3

[Chris Jones [:cjones] inactive; ni?/f?/r? if you need me]

Maybe this is what's breaking uninstall of apps from homescreen too?

Comment 5

[David Flanagan [:djf]]

It is caused by this commit:

https://github.com/mozilla-b2g/gaia/commit/40979205733dfa05ad4db2ddfcf01797636c8a87#apps/system/js/modal_dialog.js

Comment 6

[David Flanagan [:djf]]

Attachment: pull request that reverts the breakage

Chris,

I'm asking you for r? because you just commented and I imagine you have the power to land this without waiting for blocking+

Comment 7

[Chris Jones [:cjones] inactive; ni?/f?/r? if you need me]

Comment on attachment 686341 [details]
pull request that reverts the breakage

r+a=me

Comment 8

[David Flanagan [:djf]]

Cristian: note that this was your patch that just got reverted.  I didn't try to figure out what it was doing, so you'll have to redo it.

Comment 9

[:Margaret Leibovic]

(In reply to Chris Jones [:cjones] [:warhammer] from comment #3)
> Maybe this is what's breaking uninstall of apps from homescreen too?

No, that's a separate issue tracked in bug 812119.

Comment 10

[Deepa Subramanian]

Delete button works. Verified on Build ID 2012 1129071415

Comment 11

[Deepa Subramanian]

Verified on Build ID: Build ID: 20121129071415 and is fixed.