816452 - Don't fire mozbrowsererror when we get a statechange with status NS_BINDING_ABORTED; that just indicates we stopped the load.

Status: RESOLVED FIXED

(Firefox OS Graveyard :: General, defect)

Description

[(inactive after 6/18) Alive Kuo [:alive]]

This is follow-up of https://bugzilla.mozilla.org/show_bug.cgi?id=815623#c9

Not sure this is gecko's problem but still wanna to track it in an individual bug.

STR is stated in bug 815623.
After doing some investigation, I find gaia is getting mozbrowsererror event fired to the iframe which doesn't encounter an error. It's strange. Not sure what the error is, but after reload no error happens.

Comment 1

[Benjamin Chen [:bechen]]

mxr.mozilla.org/mozilla-central/source/uriloader/base/nsDocLoader.cpp#282

Comment 2

[Justin Lebar (not reading bugmail)]

For the purposes of debugging this, you could dump the error code that's received in BrowserElementChild.js::onStateChange.

Comment 3

[Patrick Wang (Chih-Kai Wang) (:kk1fff)]

Thank Justin. I think that we can describe the mozbrowsererror in more detail (maybe copy some logics from nsDocShell::DisplayLoadError to determine the error type), so the embedder can get the type of mozbrowsererror.

Currently, even stopping loading page can cause mozbrowsererror, and we have only one error type from onStateChange. There's a TODO in BEC's onStateChange, do we have a plan to do this?

Comment 4

[Justin Lebar (not reading bugmail)]

> There's a TODO in BEC's onStateChange, do we have a plan to do this?

I'm not aware of anyone else having a plan to do so.

Comment 5

[Patrick Wang (Chih-Kai Wang) (:kk1fff)]

(In reply to Justin Lebar [:jlebar] from comment #2)
> For the purposes of debugging this, you could dump the error code that's
> received in BrowserElementChild.js::onStateChange.

The state in onStateChange is NS_BIND_ABORTED. It is set because nsDocLoader::Stop is called. The Stop is initially called in nsDocShell::InternalLoad()[1]. But I don't know why DocShell stops loading there. Justin, would you give some hint about this function? Thanks.

[1] https://mxr.mozilla.org/mozilla-central/source/docshell/base/nsDocShell.cpp?rev=cf3081233fad#9032

Comment 6

[Justin Lebar (not reading bugmail)]

> Justin, would you give some hint about this function? Thanks.

Someone is navigating a page which is still doing stuff, so we call Stop() on the old page before we navigate away.

We definitely don't want to display an error page in that case!  In fact, we probably don't want to display an error page for any NS_BINDING_ABORTED loaderror's; docshell doesn't even handle that error in nsDocShell::DisplayLoadError.

Comment 7

[Patrick Wang (Chih-Kai Wang) (:kk1fff)]

Attachment: Patch: don't fire mozbrowsererror when state changes to NS_BIND_ABORTED

Justin, would you help to review this patch? Thanks.

Comment 8

[Justin Lebar (not reading bugmail)]

Comment on attachment 688189 [details] [diff] [review]
Patch: don't fire mozbrowsererror when state changes to NS_BIND_ABORTED

r=me, but please add a comment to BEC explaining why we ignore NS_BINDING_ABORTED.

Comment 9

[Patrick Wang (Chih-Kai Wang) (:kk1fff)]

Attachment: Patch: don't fire mozbrowsererror when state changes to NS_BINDING_ABORTED

r+ in comment 8. Adding comment according to comment 8.

Comment 10

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/20e8cde489ba

Comment 11

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/20e8cde489ba

Comment 12

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

This bug solve bug 821527 which is a blocking-basecamp bug. Can we backport this patch to beta?

Ryan can you merge it?

Comment 13

[Ryan VanderMeulen [:RyanVM]]

Not without approval or blocking-basecamp status.

Comment 14

[Justin Lebar (not reading bugmail)]

We should have landed this on b2g to begin with; I think we probably just forgot.

Comment 15

[Chris Jones [:cjones] inactive; ni?/f?/r? if you need me]

https://hg.mozilla.org/releases/mozilla-aurora/rev/8f4f38d57907
https://hg.mozilla.org/releases/mozilla-b2g18/rev/a7a4704fd1ef