Closed
Bug 817326
Opened 12 years ago
Closed 12 years ago
Set character encoding in browser_fayt.js
Categories
(SeaMonkey :: Testing Infrastructure, defect)
SeaMonkey
Testing Infrastructure
Tracking
(Not tracked)
RESOLVED
FIXED
seamonkey2.17
People
(Reporter: InvisibleSmiley, Assigned: InvisibleSmiley)
Details
Attachments
(1 file)
1.03 KB,
patch
|
neil
:
review+
|
Details | Diff | Splinter Review |
Running browser_fayt.js gives the following Error Console output: TEST-INFO | chrome://mochitests/content/browser/suite/browser/test/browser_fayt.js | Console message: [JavaScript Error: "The character encoding of the HTML document was not declared. The document will render with garbled text in some browser configurations if the document contains characters from outside the US-ASCII range. The character encoding of the page must be declared in the document or in the transfer protocol." {file: "data:text/html,<p>this%20is%20some%20dummy%20text</p>" line: 0}] TEST-INFO | chrome://mochitests/content/browser/suite/browser/test/browser_fayt.js | Console message: [JavaScript Error: "The character encoding of the HTML document was not declared. The document will render with garbled text in some browser configurations if the document contains characters from outside the US-ASCII range. The character encoding of the page must be declared in the document or in the transfer protocol." {file: "data:text/html,<p>this%20is%20some%20random%20text</p>" line: 0}] which we can easily get rid of. (It also triggers the below, which is not what this bug is about:) TEST-INFO | chrome://mochitests/content/browser/suite/browser/test/browser_fayt.js | Console message: [JavaScript Error: "[Exception... "Component returned failure code: 0x80004003 (NS_ERROR_INVALID_POINTER) [nsIURI.equals]" nsresult: "0x80004003 (NS_ERROR_INVALID_POINTER)" location: "JS frame :: chrome://communicator/content/viewZoomOverlay.js :: FullZoom_onLocationChange/< :: line 207" data: no]" {file: "chrome://communicator/content/viewZoomOverlay.js" line: 207}]
Attachment #687434 -
Flags: review?(neil)
Comment 1•12 years ago
|
||
TEST-INFO | chrome://mochitests/content/browser/suite/browser/test/browser_fayt.js | Console message: [JavaScript Error: "[Exception... "Component returned failure code: 0x80004003 (NS_ERROR_INVALID_POINTER) [nsIURI.equals]" nsresult: "0x80004003 (NS_ERROR_INVALID_POINTER)" location: "JS frame :: chrome://communicator/content/viewZoomOverlay.js :: FullZoom_onLocationChange/< :: line 207" data: no]" {file: "chrome://communicator/content/viewZoomOverlay.js" line: 207}] We probably need to port Bug 675037 - async fullzoom callback needs to handle being called after window is destroyed. See: http://hg.mozilla.org/mozilla-central/rev/30e5fe8a62c2 Anything else we forgot to port?
Assignee | ||
Comment 2•12 years ago
|
||
(In reply to Philip Chee from comment #1) > We probably need to port Bug 675037 - async fullzoom callback needs to > handle being called after window is destroyed. Agreed, though it probably not due to destroyed windows here. I'm just not sure whether it should be done here. > Anything else we forgot to port? Not as far as this test is concerned. ;-)
Assignee | ||
Comment 3•12 years ago
|
||
Filed bug 817682 for the viewZoomOverlay stuff.
Comment 4•12 years ago
|
||
Comment on attachment 687434 [details] [diff] [review] patch [Checkin: Comment 5] (Stupid charset warning...) (I don't seem to have received bugmail for this request, so it was fortunate that it was mentioned that bug 817682 was a followup.)
Attachment #687434 -
Flags: review?(neil) → review+
Assignee | ||
Comment 5•12 years ago
|
||
Comment on attachment 687434 [details] [diff] [review] patch [Checkin: Comment 5] http://hg.mozilla.org/comm-central/rev/e4080ff96e9d
Attachment #687434 -
Attachment description: patch → patch [Checkin: Comment 5]
Assignee | ||
Updated•12 years ago
|
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → seamonkey2.17
You need to log in
before you can comment on or make changes to this bug.
Description
•