817682 - Port |Bug 675037: fullzoom callback needs to handle null currentURI|

Status: RESOLVED FIXED

(SeaMonkey :: UI Design, defect)

Description

[Jens Hatlak (:InvisibleSmiley)]

Attachment: patch [Checkin: Comment 3]

As mentioned on bug 817326, we should port bug 675037.

Note that the old code executed also if aBrowser was null. I think that's stupid (self._applyPrefToSetting() tries to get a browser by itself, but if it fails, it fails) so I replaced the check by one that does nothing if aBrowser is null.

Comment 1

[Philip Chee]

Comment on attachment 687845 [details] [diff] [review]
patch [Checkin: Comment 3]

> Note that the old code executed also if aBrowser was null. I think that's
> stupid (self._applyPrefToSetting() tries to get a browser by itself, but if it
> fails, it fails) so I replaced the check by one that does nothing if aBrowser
> is null.
So this gets rid of the error but I disagree with your changing the logic. I think we need to check with Neil about this.

Comment 2

[[e-mail]]

Comment on attachment 687845 [details] [diff] [review]
patch [Checkin: Comment 3]

Not sure why we were null-checking aBrowser there, it's never null. (Although Firefox's aBrowser can be null, it always uses a local browser that's not.)

r=me if you remove the aBrowser && check completely.

Comment 3

[Jens Hatlak (:InvisibleSmiley)]

Comment on attachment 687845 [details] [diff] [review]
patch [Checkin: Comment 3]

http://hg.mozilla.org/comm-central/rev/1c212e41559a
with comment 2 addressed