Closed Bug 817682 Opened 9 years ago Closed 9 years ago

Port |Bug 675037: fullzoom callback needs to handle null currentURI|

Categories

(SeaMonkey :: UI Design, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
seamonkey2.17

People

(Reporter: InvisibleSmiley, Assigned: InvisibleSmiley)

Details

Attachments

(1 file)

As mentioned on bug 817326, we should port bug 675037.

Note that the old code executed also if aBrowser was null. I think that's stupid (self._applyPrefToSetting() tries to get a browser by itself, but if it fails, it fails) so I replaced the check by one that does nothing if aBrowser is null.
Attachment #687845 - Flags: review?(philip.chee)
Comment on attachment 687845 [details] [diff] [review]
patch [Checkin: Comment 3]

> Note that the old code executed also if aBrowser was null. I think that's
> stupid (self._applyPrefToSetting() tries to get a browser by itself, but if it
> fails, it fails) so I replaced the check by one that does nothing if aBrowser
> is null.
So this gets rid of the error but I disagree with your changing the logic. I think we need to check with Neil about this.
Attachment #687845 - Flags: review?(philip.chee)
Attachment #687845 - Flags: review?(neil)
Attachment #687845 - Flags: review+
Comment on attachment 687845 [details] [diff] [review]
patch [Checkin: Comment 3]

Not sure why we were null-checking aBrowser there, it's never null. (Although Firefox's aBrowser can be null, it always uses a local browser that's not.)

r=me if you remove the aBrowser && check completely.
Attachment #687845 - Flags: review?(neil) → review+
Comment on attachment 687845 [details] [diff] [review]
patch [Checkin: Comment 3]

http://hg.mozilla.org/comm-central/rev/1c212e41559a
with comment 2 addressed
Attachment #687845 - Attachment description: patch → patch [Checkin: Comment 3]
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → seamonkey2.17
You need to log in before you can comment on or make changes to this bug.