817721 - Place tab tray on top in tablet portrait view

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Ian Barlow (:ibarlow)]

Mockup http://cl.ly/image/2v3L1C3U3z34

As part of our tab tray refinements, let's bring the tab tray up to the top when browsing in portrait mode. It's a more efficient use of UI space, and is more useful and looks nicer than a giant empty sidebar :)

* Tabs scroll horizontally in this view
* Synced tabs scroll horizontally in columns http://cl.ly/image/2l1T2C3G2I0s
* Swipe up to delete normal and private tabs

Comment 1

[Mark Finkle (:mfinkle) (use needinfo?)]

(In reply to Ian Barlow (:ibarlow) from comment #0)

> * Swipe up to delete normal and private tabs

Swiping up to close in portrait, but swiping left/right to close in landscape seems a bit confusing. And is opposite of what happens in bug 817735.

Comment 2

[Ian Barlow (:ibarlow)]

It's opposite because we have different UI structures for tablets and phones. Phones are too small to present a useful sidebar for tabs, and tablets are too big to have the tab interface take over 75% of the screen when it opens. 

As for the different scroll / swipe to close orientations, I'll paste what I noted in bug 817735, that it's a pretty common interaction on Android ICS+ nowadays. 

Take a look at Stock Browser, Chrome, the App Switcher. They all use a similar model and it's fairly easy to pick up on. If it is too much for people to handle, we can add in a more visual affordance, like a close button, if need be.

Comment 3

[Lucas Rocha (:lucasr)]

I'll be working on this from now on. I'll start with the horizontal listview/gridview changes in tabs tray.

Comment 4

[Lucas Rocha (:lucasr)]

Patches (reviewed in bug 817732) pushed:
https://hg.mozilla.org/integration/mozilla-inbound/rev/52eb67d56577
https://hg.mozilla.org/integration/mozilla-inbound/rev/f7b36d82768d
https://hg.mozilla.org/integration/mozilla-inbound/rev/d20e50778bbc
https://hg.mozilla.org/integration/mozilla-inbound/rev/2ad939012eb8
https://hg.mozilla.org/integration/mozilla-inbound/rev/3f0f2ba1521c
https://hg.mozilla.org/integration/mozilla-inbound/rev/5ab1d763ff1c
https://hg.mozilla.org/integration/mozilla-inbound/rev/ff74c059d79f
https://hg.mozilla.org/integration/mozilla-inbound/rev/173822e8dd83
https://hg.mozilla.org/integration/mozilla-inbound/rev/5445992580b1

Comment 5

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/52eb67d56577
https://hg.mozilla.org/mozilla-central/rev/f7b36d82768d
https://hg.mozilla.org/mozilla-central/rev/d20e50778bbc
https://hg.mozilla.org/mozilla-central/rev/2ad939012eb8
https://hg.mozilla.org/mozilla-central/rev/3f0f2ba1521c
https://hg.mozilla.org/mozilla-central/rev/5ab1d763ff1c
https://hg.mozilla.org/mozilla-central/rev/ff74c059d79f
https://hg.mozilla.org/mozilla-central/rev/173822e8dd83
https://hg.mozilla.org/mozilla-central/rev/5445992580b1
https://hg.mozilla.org/mozilla-central/rev/007046026bfa