817735 - Horizontal tab scrolling in landscape view for phones

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Ian Barlow (:ibarlow)]

Our tab UI could be improved in landscape view on phones. Let's make better use of UI real estate by allowing tabs to scroll horizonally. 

Mockup: http://cl.ly/image/1W3u16240c1h

* Normal and private tabs scroll horizontally in this view
* Synced tabs scroll horizontally 
* Swipe up to delete normal and private tabs

Comment 1

[Mark Finkle (:mfinkle) (use needinfo?)]

Swiping up to de(In reply to Ian Barlow (:ibarlow) from comment #0)

> * Normal and private tabs scroll horizontally in this view
> * Synced tabs scroll horizontally 
> * Swipe up to delete normal and private tabs

Swiping up to close in landscape, but swiping left/right to close in portrait seems a bit confusing.

Comment 2

[Ian Barlow (:ibarlow)]

It's a pretty common interaction on Android ICS+ nowadays. 

Take a look at Stock Browser, Chrome, the App Switcher. They all use a similar model and it's fairly easy to pick up on. If it is too much for people to handle, we can add in a more visual affordance, like a close button, if need be.

Comment 3

[Lucas Rocha (:lucasr)]

I'll be working on this from now on. I'll start with the horizontal listview/gridview changes in tabs tray.

Comment 4

[Lucas Rocha (:lucasr)]

Patches (reviewed in bug 817732) pushed:
https://hg.mozilla.org/integration/mozilla-inbound/rev/52eb67d56577
https://hg.mozilla.org/integration/mozilla-inbound/rev/f7b36d82768d
https://hg.mozilla.org/integration/mozilla-inbound/rev/d20e50778bbc
https://hg.mozilla.org/integration/mozilla-inbound/rev/2ad939012eb8
https://hg.mozilla.org/integration/mozilla-inbound/rev/3f0f2ba1521c
https://hg.mozilla.org/integration/mozilla-inbound/rev/5ab1d763ff1c
https://hg.mozilla.org/integration/mozilla-inbound/rev/ff74c059d79f
https://hg.mozilla.org/integration/mozilla-inbound/rev/173822e8dd83
https://hg.mozilla.org/integration/mozilla-inbound/rev/5445992580b1

Comment 5

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/52eb67d56577
https://hg.mozilla.org/mozilla-central/rev/f7b36d82768d
https://hg.mozilla.org/mozilla-central/rev/d20e50778bbc
https://hg.mozilla.org/mozilla-central/rev/2ad939012eb8
https://hg.mozilla.org/mozilla-central/rev/3f0f2ba1521c
https://hg.mozilla.org/mozilla-central/rev/5ab1d763ff1c
https://hg.mozilla.org/mozilla-central/rev/ff74c059d79f
https://hg.mozilla.org/mozilla-central/rev/173822e8dd83
https://hg.mozilla.org/mozilla-central/rev/5445992580b1
https://hg.mozilla.org/mozilla-central/rev/007046026bfa

Comment 6

[Andreea Pod]

Verified fixed on:
-build: Firefox for Android 20.0b1 build 3 (2013-02-22), Firefox for Android 21.0a2 (2013-02-25), Firefox for Android 22.0a1 (2013-02-25)
-device: Samsung Galaxy Nexus
-OS: Android 4.2.2

Comment 7

[Michael Monreal [:micmon]]

(In reply to Andreea Pod from comment #6)
> Verified fixed on:
> -build: Firefox for Android 20.0b1 build 3 (2013-02-22), Firefox for Android
> 21.0a2 (2013-02-25), Firefox for Android 22.0a1 (2013-02-25)
> -device: Samsung Galaxy Nexus
> -OS: Android 4.2.2

This is definitely not fixed on the v20 and v21 builds you mentioned. Looks like it is only landed for v22 yet anyway.

Comment 8

[Aaron Train [:aaronmt]]

Right that doesn't make sense.

This is on trunk (mozilla-central, 22).