89.28 KB, image/png
2.71 KB, patch
|Details | Diff | Splinter Review|
Clicking on a friend's name in the sidebar (or a message in the messages panel) no longer opens the chatbox for that friend, unless this is the first Firefox window opened.
Facebook chat window doesnot open in Firefox version 20.0al. I have updated the nightly 'n' number of times. But, it seems the chat window(small window on right side) should open on click of the friend's name that display on the chat list. When double click on it, this navigates to a new window with message history. Actual result - on click of the friend's name in the chat list - the page should navigate to open a "small chat window" on the right bottom of the FB home page!
Felipe, any luck finding a regression range? I'm not able to reproduce it. Arthi, if you are able to reproduce this reliably, can you do a couple of things? * open the error console CTRL+SHIFT+J to see if any errors occur when clicking a friend * use the mozregression tool to see if you can find a regression range 1. http://mozilla.github.com/mozregression/
Actually, it works fine now with the mouse click on friend's name -" on click, the chat window opened very normal". Was the issue fixed or still under regression test? .................................................................................................................................................................... I tried to open the 'Error Console' and it shows - Timestamp: 12/4/2012 4:34:28 PM Warning: Error in parsing value for 'filter'. Declaration dropped. Source File: https://www.facebook.com/ Line: 0 Shall try regression range as said. Is this input valuable or need some more?
While working on an unrelated issue (bug 807997), I discovered that if a second window is created after the provider has fully initialized, the chatbar in the second window remains hidden, causing the attempt to create the chat fail in socialchat.xml due to the xbl bindings not being setup. The reason for it remaining hidden is that there is no path in browser-social.js that calls SocialChatBar.update() if browser-social is loaded after the init (specifically, after the provider has supplied profile info). I've added a fix for this to the patch in bug 807997 - hopefully I can land that soon.
Created attachment 688936 [details] Regression range Cmd log in Windows7, 64 OS for Bug Id-817782 [Security approval request comment] How easily can the security issue be deduced from the patch? Do comments in the patch, the check-in comment, or tests included in the patch paint a bulls-eye on the security problem? Which older supported branches are affected by this flaw? If not all supported branches, which bug introduced the flaw? Do you have backports for the affected branches? If not, how different, hard to create, and risky will they be? How likely is this patch to cause regressions; how much testing does it need?
Created attachment 689041 [details] [diff] [review] unhide the social chatbar as new top-level windows are opened. includes a test.
Assignee: nobody → mhammond
Attachment #689041 - Flags: review?(gavin.sharp)
Comment on attachment 689041 [details] [diff] [review] unhide the social chatbar as new top-level windows are opened. awesome
Attachment #689041 - Flags: review?(gavin.sharp) → review+
status-firefox18: --- → affected
status-firefox19: --- → affected
tracking-firefox18: --- → ?
tracking-firefox19: --- → ?
tracking-firefox18: ? → +
tracking-firefox19: ? → +
Target Milestone: --- → Firefox 20
(In reply to Arthi from comment #5) Regression range for Mozilla Nightly builds from 12-03-2012 to updated build 12-04-12 has a DEFECT as of mozregression test! The range seems to be GOOD from 11-27-2012 till 12-03-2012 but it had a problem when version updated on 12-04-2012. > Created attachment 688936 [details] > Regression range Cmd log in Windows7, 64 OS for Bug Id-817782 > > [Security approval request comment] > How easily can the security issue be deduced from the patch? > > Do comments in the patch, the check-in comment, or tests included in the > patch paint a bulls-eye on the security problem? > > Which older supported branches are affected by this flaw? > > If not all supported branches, which bug introduced the flaw? > > Do you have backports for the affected branches? If not, how different, hard > to create, and risky will they be? > > How likely is this patch to cause regressions; how much testing does it need?
Arthi: thanks, but we've already identified the cause of this bug (bug 809258), so no further regression hunting is needed!
Status: NEW → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
Comment on attachment 689041 [details] [diff] [review] unhide the social chatbar as new top-level windows are opened. [Approval Request Comment] Bug caused by (feature/regressing bug #): 809258 User impact if declined: Social chat windows will not appear in new top-level windows. Testing completed (on m-c, etc.): Landed on m-c, has a test Risk to taking this patch (and alternatives if risky): Low risk, limited to social String or UUID changes made by this patch: None
This blocks bug 807997, but doesn't depend on it, right? I.e. we could land only this patch and not that one on beta?
Comment on attachment 689041 [details] [diff] [review] unhide the social chatbar as new top-level windows are opened. low risk, fixes regression, limited to social - approving for uplift.
status-firefox18: affected → fixed
status-firefox19: affected → fixed
status-firefox20: --- → fixed
Depends on: 820743
I verified this issue on 18b4, latest Aurora 19.a2 and latest Nightly 20.a1 (2012/12/13) on Windows 7 x64, Ubuntu x32 and Mac OS 10.8 and it looks like sidebar and message panel work as expected. I cleared error console after starting FF using new profile, and no error appeared while clicking a friend or makeing other actions, as reply to comment 2 .
Thank you very much, Mario.
Status: RESOLVED → VERIFIED
status-firefox18: fixed → verified
status-firefox19: fixed → verified
status-firefox20: fixed → verified
You need to log in before you can comment on or make changes to this bug.