Closed
Bug 818649
Opened 13 years ago
Closed 13 years ago
|mach -l build.log build| creates the file, but doesn't log to it
Categories
(Firefox Build System :: Mach Core, enhancement)
Tracking
(Not tracked)
RESOLVED
FIXED
mozilla20
People
(Reporter: emorley, Assigned: gps)
Details
Attachments
(1 file)
|
2.57 KB,
patch
|
k0scist
:
review+
|
Details | Diff | Splinter Review |
Win7x64
MozillaBuild 1.6.1
VS2010
Building from:
https://hg.mozilla.org/integration/mozilla-inbound/rev/5488aa7e3fc3
With patches from bug 810742 and bug 818628 applied.
topsrcdir$ mach -l build.log build
...results in a 0 byte build.log file in topsrcdir.
|
Assignee | |
Comment 1•13 years ago
|
||
There is really no reason why |mach build| should not be logging. Most weird.
Other commands, by contrast, don't automatically send all of their output to the logger.
|
|
Assignee | |
Comment 2•13 years ago
|
||
I can repro this on OS X :(
I'll look into this shortly.
Assignee: nobody → gps
|
||
Comment 3•13 years ago
|
||
Also mach build -l build.log doesn't parse.
|
|
Assignee | |
Comment 4•13 years ago
|
||
While the new code is arguably better than the current (code in mach should not reference mozbuild), there is still tons of crappiness in logging land. We'll need to rewrite lots of logging.py (likely in bug 796875).
Until then, this should suffice.
Attachment #689548 -
Flags: review?(jhammel)
|
||
Updated•13 years ago
|
Attachment #689548 -
Flags: review?(jhammel) → review+
|
|
Assignee | |
Comment 5•13 years ago
|
||
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla20
|
||
Updated•7 years ago
|
Product: Core → Firefox Build System
You need to log in
before you can comment on or make changes to this bug.
Description
•