Closed Bug 818649 Opened 9 years ago Closed 9 years ago

|mach -l build.log build| creates the file, but doesn't log to it

Categories

(Firefox Build System :: Mach Core, enhancement)

x86_64
Windows 7
enhancement
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
mozilla20

People

(Reporter: emorley, Assigned: gps)

Details

Attachments

(1 file)

Win7x64
MozillaBuild 1.6.1
VS2010

Building from:
https://hg.mozilla.org/integration/mozilla-inbound/rev/5488aa7e3fc3

With patches from bug 810742 and bug 818628 applied.

topsrcdir$ mach -l build.log build

...results in a 0 byte build.log file in topsrcdir.
There is really no reason why |mach build| should not be logging. Most weird.

Other commands, by contrast, don't automatically send all of their output to the logger.
I can repro this on OS X :(

I'll look into this shortly.
Assignee: nobody → gps
Also mach build -l build.log doesn't parse.
While the new code is arguably better than the current (code in mach should not reference mozbuild), there is still tons of crappiness in logging land. We'll need to rewrite lots of logging.py (likely in bug 796875).

Until then, this should suffice.
Attachment #689548 - Flags: review?(jhammel)
Attachment #689548 - Flags: review?(jhammel) → review+
https://hg.mozilla.org/mozilla-central/rev/47713070c007
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla20
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.