819009 - add the icon and other UX fixes for the call forwarding feature

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::Settings, defect, P1)

Description

[Julien Wajsberg [:julienw]]

Follow up to Bug 803533

An icon is attached there and we need the CSS and the updated sprite.

Comment 1

[José Antonio Olivera Ortega [:jaoo]]

(In reply to Julien Wajsberg [:julienw] from comment #0)
> Follow up to Bug 803533
> 
> An icon is attached there and we need the CSS and the updated sprite.

The icon attached in that bug is for a call forwarding entry in the setting app, as agreed with Rafa we will need a icon for calls -in general- since under this panel the user also find the call waiting switch button. Adding Patrick.

Comment 2

[Rafael Rebolleda]

Peter, could you update Patryk's icon to reflect the fact that it's about both call waiting and forwarding settings? Patryk's icons was very specific about call forwarding.

Comment 3

[José Antonio Olivera Ortega [:jaoo]]

Attachment: Pointer to Github WIP branch: https://github.com/jaoo/gaia/tree/819009

Comment 4

[Eric Pang [:epang] UX]

Attachment: Updated Call Settings Icon

Comment 5

[José Antonio Olivera Ortega [:jaoo]]

Update: Icon added. I've also done other minor fixes. Waiting for a quick UX review from Rafa before starting the review.

Comment 6

[José Antonio Olivera Ortega [:jaoo]]

Attachment: Pointer to Github PR: https://github.com/mozilla-b2g/gaia/pull/7047

Comment 7

[Fabien Cazenave [:kaze]]

The “other minor fixes” look good, but I’d much prefer to update the CSS sprite first (rather than using a separate icon): that’s what this bug is about.

Comment 8

[Fabien Cazenave [:kaze]]

FTR, the main panel looks much better with this patch. Thanks for this improvement! :)

Comment 9

[José Antonio Olivera Ortega [:jaoo]]

(In reply to Fabien Cazenave [:kaze] from comment #7)
> The “other minor fixes” look good, but I’d much prefer to update the CSS
> sprite first (rather than using a separate icon): that’s what this bug is
> about.

Ok!. epang, could you update the sprite as kaze says please? FYI the sprite lives at [1]. Thanks!

[1] https://github.com/mozilla-b2g/gaia/blob/master/apps/settings/style/images/icons_sprite.png

Comment 10

[Eric Pang [:epang] UX]

(In reply to José Antonio Olivera Ortega [:jaoo] from comment #9)
> (In reply to Fabien Cazenave [:kaze] from comment #7)
> > The “other minor fixes” look good, but I’d much prefer to update the CSS
> > sprite first (rather than using a separate icon): that’s what this bug is
> > about.
> 
> Ok!. epang, could you update the sprite as kaze says please? FYI the sprite
> lives at [1]. Thanks!
> 
> [1]
> https://github.com/mozilla-b2g/gaia/blob/master/apps/settings/style/images/
> icons_sprite.png

sure :), but seeing as this is a new icon that doesn't exist in the sprite yet where should it be added?  let me know, thanks!

Comment 11

[José Antonio Olivera Ortega [:jaoo]]

(In reply to Eric Pang [:epang] from comment #10)

> sure :), but seeing as this is a new icon that doesn't exist in the sprite
> yet where should it be added?  let me know, thanks!

I guess by adding a new row at the bottom and adding the icon (or new ones) from left to right.

Comment 12

[Eric Pang [:epang] UX]

Attachment: Settings Sprite

Updated the setting sprites with two new icons.
1. Call settings
2. Feedback

Thanks!

Comment 13

[Fabien Cazenave [:kaze]]

Thanks Eric!

Jaoo, I’ll happily merge your request as soon as you update the sprite.

Comment 15

[Fabien Cazenave [:kaze]]

Stealing, as :jaoo is on PTO for two weeks.

Comment 16

[Fabien Cazenave [:kaze]]

ooops, I just realize that :jaoo did the CSS part already. Un-stealing.

Comment 17

[Fabien Cazenave [:kaze]]

Comment on attachment 692989 [details]
Pointer to Github PR: https://github.com/mozilla-b2g/gaia/pull/7047

Merging. Nice job but next time, please fix the linter warnings. ;-)

https://github.com/mozilla-b2g/gaia/commit/e4d8435318b770fa7f50037f5d467efca1d89800

Comment 19

[Matt Wobensmith [:mwobensmith][:matt:]]

Confirmed two new icons for Call Settings and Improve Firefox OS. 
Verified build 20130110070201.