819207 - Carrier name in Settings should follow SIM display conditions

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Settings, defect, P1)

Description

[Patrick Wang (Chih-Kai Wang) (:kk1fff)]

Cellular & Data field in Settings app is not correct in MVNO environment. Following SPN/display conditions to show the carrier name should fix it.

Comment 1

[Tim Guan-tin Chien [:timdream] (please needinfo)]

Bug 813150 need to land first before start working on this one.

Comment 2

[Chris Lee [:clee]]

Daniel, can you comment here on the severity of this bug?  Thanks.

Comment 3

[Daniel Coloma:dcoloma]

This is a blocker, user should know accurately the operator providing the service to him, regardless it is a virtual or a non-virtual operator.

Comment 4

[Tim Guan-tin Chien [:timdream] (please needinfo)]

Kaze, are you already working on this bug? I can steal this if you want.

Comment 5

[Anthony Ricaud (:rik)]

I discussed it with Kaze and I'm gonna take this.

Comment 6

[David Palomino [:dpalomino]]

This would be a certification blocker, I add the dependency. 

Thks, 
David

Comment 7

[Anthony Ricaud (:rik)]

FYI, I'm working on this and have working code. I've factorized some code that dealt with Brazil. And I'm now writing tests for those. I thought I would be done by yesterday but it's my first experience with our testing framework so I'm not exactly efficient yet.

Comment 8

[Anthony Ricaud (:rik)]

Attachment: Proposed patch

Comment 9

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

Comment on attachment 694473 [details] [diff] [review]
Proposed patch

Sounds good for me. Lot of factorizations.

Comment 10

[Fabien Cazenave [:kaze]]

Comment on attachment 694473 [details] [diff] [review]
Proposed patch

*very* nice work, thanks Anthony!

r=me, please address James’ nits and rebase your PR so we can merge it.

Comment 11

[Fabien Cazenave [:kaze]]

https://github.com/mozilla-b2g/gaia/commit/185cccd163a20ac670aae8cb60ceada25ca05bc8

Comment 12

[Anthony Ricaud (:rik)]

QA: This patch touches code that is specific to Brazil, can we check that carrier displaying in the lockscreen, statusbar and settings app work as expected in that country?

Comment 13

[Tony Chung [:tchung]]

(In reply to Anthony Ricaud (:rik) from comment #12)
> QA: This patch touches code that is specific to Brazil, can we check that
> carrier displaying in the lockscreen, statusbar and settings app work as
> expected in that country?

We're gonna need Telefonica's help here, as they have VIVO SIM cards.   Massimo, any chance you can help out testing this patch on Brazillian sim cards?