822384 - Carrier name is shown as 'undefined' in settings and lockscreen

Status: VERIFIED FIXED

(Core :: DOM: Device Interfaces, defect, P1)

Description

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Not sure why but after updating my Unagi device from the build 20121213 to yesterdays build, the carrier name is shown as 'Unknown' for me. The phone is still registered in the network and mobile data works too. Not sure why it's shown as 'unknown' in settings and the lockscreen.

I will not restart the phone. So if you can give me steps how to get you the details I will do so.

Comment 1

[David Scravaglieri [:scravag]]

Maybe related to bug 819207 that will be closed soon.

Comment 2

[Henrik Skupin [:whimboo][⌚️UTC+2]]

(In reply to David Scravaglieri [:scravag] from comment #1)
> Maybe related to bug 819207 that will be closed soon.

Is it related to a regression? As mentioned in comment 0 it was working previously for me and has started recently. But lets see if it is the case and add bug 819207 as dependency.

Comment 3

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Even after a couple of reboots the carrier name is still shown as unknown. So this is indeed a regression between 12-13 and 12-17 builds.

Comment 4

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Uh, it's 'undefined' and not 'unknown'. Sorry.

Comment 5

[David Palomino [:dpalomino]]

Hi, 

Problems related to proper display of carrier name are usualyy certification blockers. 

Adding dep. 

Cheers, 
David

Comment 6

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Just to give some additional information. The carrier I'm using is O2 Germany.

Comment 7

[Tim Guan-tin Chien [:timdream] (please needinfo)]

Not a regression from bug 815595

Comment 8

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

The undefined string seems to be fixed for me with the upcoming patch in bug 819207

Comment 9

[Anthony Ricaud (:rik)]

Henrik, now that work has landed in bug 819207, can you confirm that it fixed your issue? Thanks!

Comment 10

[Francisco Jordano [:arcturus] [:francisco]]

Still happening to me with latest production build and production gaia.

My carrier is 'Movistar'

Comment 11

[Anthony Ricaud (:rik)]

Attachment: Patch to output debug information

Francisco: What is the sha1 of your production gaia? Do you see a valid network name on the lockscreen or the statusbar?
If anyone still sees 'undefined', apply this patch and cc the output of 'adb logcat|grep GeckoConsole' here when opening the settings app.

Comment 12

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Undefined is still shown with the daily build from 20121223. I can't do any debugging given that I run the daily builds and don't build b2g on my own. Sorry. I hope someone else can help out.

Comment 13

[Marcia Knous [:marcia]]

I am seeing this today running the smoketest today using 20121226. The carrier I have is AT&T.

Gaia: b4bcf70792f4
Gecko: e261861b0270

I see it on the lockscreen as well. How do I apply the patch to the daily builds?

Comment 14

[Marcia Knous [:marcia]]

After I crashed and restarted, the phone is now showing AT&T instead of undefined. I forgot to note in Comment 13 that I was running a freshly flashed build.

Comment 17

[Janet Swisher]

Ditto to comment 13: build from 20121226. Currently using E-plus (for the next couple of days).

Comment 18

[Anthony Ricaud (:rik)]

I'll let this bug sleep until next week's offsite. We'll have lots of people around to quickly try out things.

Idea for later: Ship with an hidden app that displays SIM and carrier information.

Comment 19

[Joel Braddock :jbraddock]

Is an O2 sim card still needed per the "BERLIN Work Week SIM request" sheet? I also have local Telekom SIMs available at the work week.

Comment 20

[Anthony Ricaud (:rik)]

I tried with a Telekom SIM here and couldn't reproduce.

Henrik: Before asking Joel to get an O2 sim card, could you confirm that you're still seeing this?

Comment 21

[Francisco Jordano [:arcturus] [:francisco]]

Hi folks,

This is a bit weird, cause I have the same build, with same SIM (movistar sim), and now I can see the O2 roaming information.

Yesterday in Spain I still had the 'undefined' message.

Comment 22

[Henrik Skupin [:whimboo][⌚️UTC+2]]

It still happens for me with yesterdays build on my Unagi device. Just in case it makes a different, I have a SIM from DeutschlandSIM:

http://www.deutschlandsim.de/

Comment 23

[Germán Toro del Valle (:gtorodelvalle)]

I am getting the same behavior as :arcturus with my Movistar Spanish SIM card :-)

Comment 24

[Henrik Skupin [:whimboo][⌚️UTC+2]]

I will be in Berlin and join the work week from Wednesday to Friday. So if it can wait you can get my SIM card for testing.

Comment 25

[Germán Toro del Valle (:gtorodelvalle)]

Sounds perfect to me ;-)

Comment 26

[David Scravaglieri [:scravag]]

We need to do proper test in each countries we will ship. We will not block on such issue without precisions.

Comment 27

[Daniel Coloma:dcoloma]

This is not working in Spain with Movistar that is one of the target markets. Renominating. This is blocking certification meta-bug, those ones should not be retriaged.

Comment 28

[José Antonio Olivera Ortega [:jaoo]]

Attachment: Logcat output with RIL debug enabled (Movistar SIM).

I/Gecko   (  108): -*- RadioInterfaceLayer: Received message from worker: {"isDisplayNetworkNameRequired":true,"isDisplaySpnRequired":true,"rilMessageType":"iccinfochange","imsi":"214075537652354","iccid":"8934071100275319147","ad":{"0":0,"1":0,"2":0,"3":2},"mcc":214,"mnc":7,"sst":{"0":158,"1":107,"2":29,"3":156,"4":103,"5":246,"6":88,"7":0,"8":0},"mbdn":"123","spn":""}

There is no value for the spn property so that's the reason we see 'undefined'.

Looking deeper into the problem.

Comment 29

[Anthony Ricaud (:rik)]

José: Thanks, that's helpful. When I look at the code though, with those values, it doesn't fall into the path that uses iccinfo.spn. Would you happen to have the voice.network.shortName and voice.network.longName values too?

Comment 30

[Tim Guan-tin Chien [:timdream] (please needinfo)]

(In reply to José Antonio Olivera Ortega [:jaoo] from comment #28)
> Created attachment 699213 [details]
> Logcat output with RIL debug enabled (Movistar SIM).
> 
> I/Gecko   (  108): -*- RadioInterfaceLayer: Received message from worker:
> {"isDisplayNetworkNameRequired":true,"isDisplaySpnRequired":true,
> "rilMessageType":"iccinfochange","imsi":"214075537652354","iccid":
> "8934071100275319147","ad":{"0":0,"1":0,"2":0,"3":2},"mcc":214,"mnc":7,"sst":
> {"0":158,"1":107,"2":29,"3":156,"4":103,"5":246,"6":88,"7":0,"8":0},"mbdn":
> "123","spn":""}
> 
> There is no value for the spn property so that's the reason we see
> 'undefined'.
> 
> Looking deeper into the problem.

That's interesting. Even though isDisplaySpnRequired is set to true, we do check whether or not |spn| is a falsey value or not at L12

https://github.com/mozilla-b2g/gaia/blob/master/shared/js/mobile_operator.js#L12-L18

I suspect that even voice.network.shortName and voice.network.longName are undefined at this stage.

Comment 31

[José Antonio Olivera Ortega [:jaoo]]

Attachment: Logcat output with RIL debug enabled (Movistar SIM).

New |adb logcat| output with the patch from :ric. Now you can see guys all the information you might need.

Comment 32

[Tim Guan-tin Chien [:timdream] (please needinfo)]

Comment on attachment 699295 [details]
Logcat output with RIL debug enabled (Movistar SIM).

E/GeckoConsole(  108): Content JS LOG at app://system.gaiamobile.org/shared/js/mobile_operator.js:10 in mo_userFacingInfo: shortName:  undefined
E/GeckoConsole(  108): Content JS LOG at app://system.gaiamobile.org/shared/js/mobile_operator.js:11 in mo_userFacingInfo: longName:  Movistar

Gecko is definitely sending string 'undefined' here. We fallback to longName if shortName is a falsey value in mobile_operator.js

Comment 33

[Tim Guan-tin Chien [:timdream] (please needinfo)]

When RILContentHelper receives a message w/o shortName in the json object:

I/Gecko   (  108): -*- RILContentHelper: Received message 'RIL:VoiceInfoChanged': {"connected":true,"emergencyCallsOnly":false,"roaming":false,"network":{"rilMessageType":"operatorchange","longName":"Movistar","mcc":214,"mnc":7},"cell":{"gsmLocationAreaCode":2862,"gsmCellId":21532830},"type":"gsm","signalStrength":-59,"relSignalStrength":87,"state":"registered"}

it would update voice.network.shortName here:

https://mxr.mozilla.org/mozilla-beta/source/dom/system/gonk/RILContentHelper.js#400

Supposedly, without any type-casting, this results shortName being specified as undefined undefined. I don't understand Gecko enough to tell what happen next.

Gaia expects a falsey value here (e.g. empty string).

Comment 34

[Patrick Wang (Chih-Kai Wang) (:kk1fff)]

According to the log:

I/Gecko   (  108): RIL Worker: updateNetworkName: Network names will be overriden: longName = Movistar, shortName = undefined

Looks like a bug of reading PNN function.

Comment 35

[Patrick Wang (Chih-Kai Wang) (:kk1fff)]

Attachment: Patch: Initialize PNN entry with empty strings.

Spec doesn't require every PNN entry to have short name field. If the PNN doesn't contain short name, the short name will be an empty string with this patch.

José, would you try out this patch?

Comment 36

[Henrik Skupin [:whimboo][⌚️UTC+2]]

This is interesting. So in my case I have just seen that the carrier name is visible for about 30 after switching the mobile settings from 2G <-> 3G. Then it is cleared out and undefined is shown. This can be reproduced constantly.

Comment 37

[Patrick Wang (Chih-Kai Wang) (:kk1fff)]

(In reply to Henrik Skupin (:whimboo) from comment #36)
> This is interesting. So in my case I have just seen that the carrier name is
> visible for about 30 after switching the mobile settings from 2G <-> 3G.
> Then it is cleared out and undefined is shown. This can be reproduced
> constantly.

It looks like that your carrier name is visible until PNN file has been read.

The 'undefined' comes from updateNetworkName(). After PNN file has been read, updateNetworkName() will replace the carrier name with names from PNN files. Short name is not present in that PNN file, so it becomes undefined.

Comment 38

[José Antonio Olivera Ortega [:jaoo]]

Attachment: Logcat output with RIL debug enabled (Movistar SIM).

By applying the patch from Patrick the operator name is shown in lock screen, status bar and settings app. Patrick, Tim, here is the log, you might take a look at it.

Comment 39

[Anthony Ricaud (:rik)]

So I applied attachment 699589 [details] [diff] [review] on my b2g18 branch. First it didn't apply so here is the diff that I've used: http://www.pastebin.mozilla.org/2047067

When I apply this patch and test with Henrik's SIM card, I get this:
shortName:  
longName:  Telco
isDisplaySpnRequired:  false
isDisplayNetworkNameRequired:  true
spn:  
And we display Telco.

If I switch to 2G, I get:
shortName:  O2
longName:  O2 (Germany) GmbH & Co. OHG
isDisplaySpnRequired:  false
isDisplayNetworkNameRequired:  true
spn:  
And we display O2.

That looks good to me!

Comment 40

[Patrick Wang (Chih-Kai Wang) (:kk1fff)]

Comment on attachment 699589 [details] [diff] [review]
Patch: Initialize PNN entry with empty strings.

Vicamo, could you help to review this patch?

Comment 41

[Vicamo Yang [:vicamo][:vyang]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/dbaa81015138

Comment 42

[Tim Guan-tin Chien [:timdream] (please needinfo)]

\o/

Comment 43

[Andrea Marchesini [:baku]]

https://hg.mozilla.org/releases/mozilla-b2g18/rev/06e5ac3b0980

Comment 44

[Johnny Stenback (:jst)]

Marking FIXED as this is landed on inbound and b2g18.

Comment 45

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/dbaa81015138

Comment 46

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Works fine for todays Unagi build. Thanks for fixing!