product/component line in email notifications a bit confusing

RESOLVED FIXED

Status

()

bugzilla.mozilla.org
General
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: heycam, Assigned: reed)

Tracking

(Blocks: 1 bug)

Production
Dependency tree / graph

Details

Attachments

(1 attachment)

I just got a bugmail that included the line:

  Product | Component: Core | Widget: Cocoa

It took me a bit to parse this.  I am not sure I have a good replacement suggestion.  Maybe either:

  Product: Core
  Component: Widget: Cocoa

or

  Product | Component
  Core | Widget: Cocoa

or

  Product & Component: Core | Widget: Cocoa

Sorry for lack of better suggestions.
Assignee: email-notifications → nobody
Component: Email Notifications → General
Product: Bugzilla → bugzilla.mozilla.org
QA Contact: default-qa
Version: unspecified → Production

Updated

5 years ago
Blocks: 820938

Comment 1

5 years ago
fwiw. The format of his line is what causes firebot to run into problems, since it matches exactly the format of the Changed table.

mozbot treats lines that look like this:
field| from | to
as part of that table, and since Product matches a valid field name.

So if this format gets changed, avoiding the dual pipes or using a label that isn't an field name would be good.
(Assignee)

Comment 2

5 years ago
Created attachment 693243 [details] [diff] [review]
patch - v1

Change to:
Product/Component: bugzilla.mozilla.org :: General
Assignee: nobody → reed
Status: NEW → ASSIGNED
Attachment #693243 - Flags: review?(glob)
Attachment #693243 - Flags: review?(dkl)
Comment on attachment 693243 [details] [diff] [review]
patch - v1

r=dkl
Attachment #693243 - Flags: review?(dkl) → review+
Attachment #693243 - Flags: review?(glob)
(Assignee)

Comment 4

5 years ago
Committing to: bzr+ssh://bzr.mozilla.org/bmo/4.0/
modified extensions/BMO/template/en/default/email/bugmail.html.tmpl
modified extensions/BMO/template/en/default/email/bugmail.txt.tmpl
Committed revision 8424.

Committing to: bzr+ssh://bzr.mozilla.org/bmo/4.2/
modified extensions/BMO/template/en/default/email/bugmail.html.tmpl
modified extensions/BMO/template/en/default/email/bugmail.txt.tmpl
Committed revision 8465.
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.