820496 - In print preview, background bottom moves when scrolling

Status: VERIFIED FIXED

(Core :: Print Preview, defect)

Description

[Alice0775 White]

Build Identifier:
http://hg.mozilla.org/mozilla-central/rev/4dfe323a663d
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:20.0) Gecko/20121211 Firefox/20.0 ID:20121211030855
http://hg.mozilla.org/releases/mozilla-aurora/rev/c042ea08a2b4
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:19.0) Gecko/20121211 Firefox/19.0 ID:20121211042015

See reports http://forums.mozillazine.org/viewtopic.php?p=12540791#p12540791

Steps to reproduce:
1) Check Page Setup > Print background
2) Open http://www.tizag.com/htmlT/htmlbackground.php
3) Select Print Preview

Actual Result:

[1] there is white rectangle on the right: http://i.imgur.com/tUQ6B.jpg --- Bug 820494
[2] Blue background moves downwards when I'm scrolling down. --- This bug.
There are 2 regressions.

#1 No backbround color in print preview
   --- Regressed by Bug 792314 and Fixed by Bug 816603 except [1]  --- Bug 820494

#2 Graphical glich in print preview when scroll
   --- Regressed by Bug 811570 and Fixed by Bug 812107 except [2]. --- I Will file separate bug

Comment 1

[Alice0775 White]

oops,
>#2 Graphical glich in print preview when scroll
>     --- Regressed by Bug 811570 and Fixed by Bug 812107 except [2]. --- I Will file separate bug
#2 Graphical glich in print preview when scroll
      --- Regressed by Bug 811570 and Fixed by Bug 812107 except [2]. --- this bug

Comment 2

[Alice0775 White]

Sorry
s/Bug 811570/Bug 810186/

Comment 3

[Alice0775 White]

I can also reproduce In 18Beta.

Comment 4

[Alice0775 White]

(In reply to Alice0775 White from comment #3)
> I can also reproduce In 18Beta.

So, root cause is Bug 792314 and Bug 794709 ?

Comment 5

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Attachment: testcase

Reduced testcase is simple enough...

Comment 6

[bhavana bajaj [:bajaj]]

Not tracking it for release considering it's not a blocker for release based on the user scenario described . Please feel free to renominate if the issue is widely seen

Comment 8

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Attachment: fix

Comment 9

[Matt Woodrow (:mattwoodrow)]

Comment on attachment 692888 [details] [diff] [review]
fix

Review of attachment 692888 [details] [diff] [review]:
-----------------------------------------------------------------

::: layout/generic/nsPageFrame.cpp
@@ +547,5 @@
>    // happens after we've built the list so that AddCanvasBackgroundColorItem
>    // can monkey with the contents if necessary.
> +  nsRect backgroundRect =
> +    nsRect(child->GetOffsetToCrossDoc(aBuilder->FindReferenceFrameFor(child)),
> +           child->GetSize());

Just aBuilder->ToReferenceFrame(child) should work here right?

Comment 10

[Robert O'Callahan (:roc) (email my personal email if necessary)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/dd277d439d31

Comment 11

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Comment on attachment 692888 [details] [diff] [review]
fix

[Approval Request Comment]
Bug caused by (feature/regressing bug #): 792314 (ultimately DLBI)
User impact if declined: incorrectly drawn background color in print preview, if background colors are turned on in Page Setup (so, not common)
Testing completed (on m-c, etc.): just landed on inbound
Risk to taking this patch (and alternatives if risky): This is a pretty small, focused and safe patch. Very likely the worst that could happen is that we draw the background differently wrong.
String or UUID changes made by this patch: none

Comment 12

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/dd277d439d31

Comment 13

[Alex Keybl [:akeybl]]

Comment on attachment 692888 [details] [diff] [review]
fix

We wouldn't chemspill for this issue, the user impact isn't absolutely critical, and we therefore shouldn't try to get this into our last beta. Approving for Aurora, however.

Comment 14

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/47d8fc2c65f7

Comment 15

[Mihai Morar, (:MihaiMorar)]

Attachment: Screenshot

Verified fixed on FF 19.3 on Windows 7 x64.

Mozilla/5.0 (Windows NT 6.1; WOW64; rv:19.0) Gecko/20100101 Firefox/19.0(20130123083802)

Comment 16

[Mihai Morar, (:MihaiMorar)]

Attachment: Screenshot

Comment 17

[Mihai Morar, (:MihaiMorar)]

I confirm the fix is verified on FF 20b5 too:

Mozilla/5.0 (Windows NT 6.1; WOW64; rv:20.0) Gecko/20100101 Firefox/20.0(20130313170052)