Closed
Bug 821012
Opened 13 years ago
Closed 13 years ago
B2G automation should use busybox during the install_gecko step if it's available
Categories
(Testing :: General, defect)
Tracking
(firefox19 fixed, firefox20 fixed, firefox21 fixed, b2g18 fixed, b2g18-v1.0.0 wontfix, b2g18-v1.0.1 fixed)
RESOLVED
FIXED
mozilla21
People
(Reporter: ahal, Assigned: ahal)
References
Details
Attachments
(3 files)
7.01 KB,
patch
|
jgriffin
:
review+
|
Details | Diff | Splinter Review |
3.25 KB,
patch
|
jgriffin
:
review+
|
Details | Diff | Splinter Review |
2.20 KB,
patch
|
jgriffin
:
review+
|
Details | Diff | Splinter Review |
The setup time is about 6-10 minutes. There are now 18 B2G emulator chunks across the various tests which equals almost 3 hours of slave time per push wasted on setup. Lets try and speed this up.
One quick win is to install busybox on the emulators and use that to copy all the gecko files over at once. I don't know how much faster it will be.
Assignee | ||
Updated•13 years ago
|
Assignee: nobody → ahalberstadt
Status: NEW → ASSIGNED
Assignee | ||
Comment 1•13 years ago
|
||
I'll push this to ash to test it out since it requires a mozharness change too.
Attachment #697935 -
Flags: review?(jgriffin)
Assignee | ||
Comment 2•13 years ago
|
||
Attachment #697945 -
Flags: review?(jgriffin)
Assignee | ||
Comment 3•13 years ago
|
||
Pushed to ash for testing:
https://tbpl.mozilla.org/?tree=Ash&rev=dcefa32b7944
Updated•13 years ago
|
Attachment #697935 -
Flags: review?(jgriffin) → review+
Updated•13 years ago
|
Attachment #697945 -
Flags: review?(jgriffin) → review+
Assignee | ||
Comment 4•13 years ago
|
||
Preliminary results seem to show that this cuts down 2-3 minutes per chunk. That's a bigger win than I was expecting.
Assignee | ||
Comment 5•13 years ago
|
||
I'll have to land the gecko patch everywhere before landing the mozharness one. I'll wait till next week when I'll be around all day to supervise it.
Assignee | ||
Comment 6•13 years ago
|
||
In order to make sure we don't get any failures I had to commit a part 1 gecko patch which is just the changes to add the busybox arg to the reftest and mochitest harnesses.
https://hg.mozilla.org/integration/mozilla-inbound/rev/7744b9769935
https://hg.mozilla.org/releases/mozilla-aurora/rev/f705a043ad9c
https://hg.mozilla.org/releases/mozilla-b2g18/rev/171baeed6231
Once this lands on central I'll commit the mozharness patch, then I can safely commit the marionette portion of the gecko patch.
Whiteboard: [leave-open]
Comment 7•13 years ago
|
||
Part 1 landed with an incorrect bug number (bug 812012). Happened to spot it by chance, but not until after the script had closed that bug.
Ideally please can we have a backout + reland (n the same push, with DONTBUILD on the topmost changeset), so hg annotate shows the correct bug number?
https://hg.mozilla.org/mozilla-central/rev/7744b9769935
Comment 8•13 years ago
|
||
(Also note that part 1 missed the merge of mozilla20 to aurora; so needs to land there too)
Updated•13 years ago
|
status-b2g18:
--- → fixed
status-firefox19:
--- → fixed
status-firefox20:
--- → affected
status-firefox21:
--- → fixed
Target Milestone: --- → mozilla21
Assignee | ||
Comment 9•13 years ago
|
||
Assignee | ||
Comment 10•13 years ago
|
||
Assignee | ||
Comment 11•13 years ago
|
||
gecko patch part 2:
https://hg.mozilla.org/integration/mozilla-inbound/rev/999039502afb
I probably won't bother landing on aurora/b2g18 as it isn't something that's critical.
Whiteboard: [leave-open]
Assignee | ||
Comment 12•13 years ago
|
||
Crap. I just realized that the install_gecko step is happening before the install_busybox step. This means a third gecko patch is needed.
Assignee | ||
Comment 13•13 years ago
|
||
Attachment #699347 -
Flags: review?(jgriffin)
Assignee | ||
Updated•13 years ago
|
Whiteboard: [leave-open]
Updated•13 years ago
|
Attachment #699347 -
Flags: review?(jgriffin) → review+
Assignee | ||
Comment 14•13 years ago
|
||
gecko patch part 3:
https://hg.mozilla.org/integration/mozilla-inbound/rev/564336aa34f6
Whiteboard: [leave-open]
Comment 15•13 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/999039502afb
https://hg.mozilla.org/mozilla-central/rev/564336aa34f6
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Comment 16•12 years ago
|
||
status-b2g18-v1.0.0:
--- → wontfix
status-b2g18-v1.0.1:
--- → fixed
You need to log in
before you can comment on or make changes to this bug.
Description
•