We need the changes from https://github.com/mozilla/mozbase/commit/93701293b5fa5ea538faec9d7f3ba6abcdf4ac48 to clean up b2g automation
git compare: https://github.com/mozilla/mozbase/compare/mozdevice-0.17...mozdevice-0.18 try run: https://tbpl.mozilla.org/?tree=Try&rev=04de607febe1
Attachment #693908 - Flags: review?(jhammel)
Comment on attachment 693908 [details] [diff] [review] Patch 1.0 - update mozdevice assuming a green try run, looks good to me
Attachment #693908 - Flags: review?(jhammel) → review+
B2G try is completely backed up, but the xpcshell tests passed. I think this is sufficient testing for B2G as all the harnesses are run nearly identically and xpcshell makes use of most of the code paths affected by this patch.
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla20
It looks like this landed on mozilla-aurora also, but not beta, possibly causing (or not solving) some beta-specific problems: bug 686245.
Comment on attachment 693908 [details] [diff] [review] Patch 1.0 - update mozdevice [Approval Request Comment] Bug caused by (feature/regressing bug #): This is a roll-up of various improvements to mozdevice User impact if declined: talos ts failures on beta - bug 686245 Testing completed (on m-c, etc.): on m-c and m-a since Dec 20 Risk to taking this patch (and alternatives if risky): Affects test infra String or UUID changes made by this patch: None
Attachment #693908 - Flags: approval-mozilla-beta?
Comment on attachment 693908 [details] [diff] [review] Patch 1.0 - update mozdevice Test only and shouldn't affect builds, so approving.
Attachment #693908 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
You need to log in before you can comment on or make changes to this bug.