Closed
Bug 821865
Opened 12 years ago
Closed 12 years ago
bump mozdevice to version 0.18 and release to m-c
Categories
(Testing :: Mozbase, defect)
Testing
Mozbase
Tracking
(firefox19 fixed, firefox20 fixed)
RESOLVED
FIXED
mozilla20
People
(Reporter: ahal, Assigned: ahal)
References
Details
Attachments
(1 file)
25.03 KB,
patch
|
k0scist
:
review+
lsblakk
:
approval-mozilla-beta+
|
Details | Diff | Splinter Review |
We need the changes from https://github.com/mozilla/mozbase/commit/93701293b5fa5ea538faec9d7f3ba6abcdf4ac48 to clean up b2g automation
Assignee | ||
Comment 1•12 years ago
|
||
git compare: https://github.com/mozilla/mozbase/compare/mozdevice-0.17...mozdevice-0.18
try run: https://tbpl.mozilla.org/?tree=Try&rev=04de607febe1
Attachment #693908 -
Flags: review?(jhammel)
Assignee | ||
Updated•12 years ago
|
Version: 18 Branch → Trunk
Comment 2•12 years ago
|
||
Comment on attachment 693908 [details] [diff] [review]
Patch 1.0 - update mozdevice
assuming a green try run, looks good to me
Attachment #693908 -
Flags: review?(jhammel) → review+
Assignee | ||
Comment 3•12 years ago
|
||
B2G try is completely backed up, but the xpcshell tests passed. I think this is sufficient testing for B2G as all the harnesses are run nearly identically and xpcshell makes use of most of the code paths affected by this patch.
Comment 4•12 years ago
|
||
wfm
Assignee | ||
Comment 5•12 years ago
|
||
Comment 6•12 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla20
![]() |
||
Comment 7•12 years ago
|
||
It looks like this landed on mozilla-aurora also, but not beta, possibly causing (or not solving) some beta-specific problems: bug 686245.
![]() |
||
Comment 8•12 years ago
|
||
Comment on attachment 693908 [details] [diff] [review]
Patch 1.0 - update mozdevice
[Approval Request Comment]
Bug caused by (feature/regressing bug #): This is a roll-up of various improvements to mozdevice
User impact if declined: talos ts failures on beta - bug 686245
Testing completed (on m-c, etc.): on m-c and m-a since Dec 20
Risk to taking this patch (and alternatives if risky): Affects test infra
String or UUID changes made by this patch: None
Attachment #693908 -
Flags: approval-mozilla-beta?
![]() |
||
Comment 9•12 years ago
|
||
Comment 10•12 years ago
|
||
Comment on attachment 693908 [details] [diff] [review]
Patch 1.0 - update mozdevice
Test only and shouldn't affect builds, so approving.
Attachment #693908 -
Flags: approval-mozilla-beta? → approval-mozilla-beta+
Comment 11•12 years ago
|
||
status-firefox19:
--- → fixed
status-firefox20:
--- → fixed
You need to log in
before you can comment on or make changes to this bug.
Description
•