821627 - [Music] the music doesn't stop when playing user recorded video

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::Music, defect, P3)

Description

[Askeing Yen[:askeing][:fyen]]

Build: unagi_2012-12-13_eng.zip
gaia revision: "47990e89ad5710224a771cf64751ed84935433cc"

Steps:
 case #1
 1. Open Music app, play music.
 2. Open Camera, switch to Recording, record a video.
 3. Click the video on screen top, play it.

 case #2
 1. Open Camera, switch to Recording, record a video.
 2. Open Music app, play music.
 3. Open Gallery, click the video, play it.

Expected results:
 The music should stop when video play, and resume when video stop.

Actual results:
 The music still play when video play.


Please ref:
Bug 811649 - [camera] Start video recording, audio clip keeps on playing in background

Comment 1

[Askeing Yen[:askeing][:fyen]]

device: unagi
build: unagi_2012-12-23 from https://releases.mozilla.com/b2g/

Still have this issue.

Comment 2

[Marco Chen [:mchen]]

Dear Alive,

I found that shared/js/media/video_player.js doesn't set mozAudioChannelType to 'content'.
Could you help to verify it?

Thanks.

Comment 3

[(inactive after 6/18) Alive Kuo [:alive]]

Root cause:
Uh, I doesn't notice that the Gallery app could play video... so I miss it in recent mozAudioChannelType change.

Nominate for bb.

Comment 4

[(inactive after 6/18) Alive Kuo [:alive]]

Unfortunately it doesn't work after gaia work done.
Branch here, 
https://github.com/alivedise/gaia/tree/bugzilla/821627

Please tell me if I have to modify something.

(In reply to Marco Chen [:mchen] from comment #2)
> Dear Alive,
> 
> I found that shared/js/media/video_player.js doesn't set mozAudioChannelType
> to 'content'.
> Could you help to verify it?
> 
> Thanks.

Comment 5

[Joe Cheng [:jcheng] (please needinfo)]

Triage: BB-, tracking-b2g18+, should not block if this were the last bug before ship

Comment 7

[Naoki Hirata :nhirata (please use needinfo instead of cc)]

## Repro :
1. Play a song in music app
2. launch video
3. select a video
4. wait til the song switches to the next song
5. play a video

## Expected :
1. music app stops, video plays sound

## Actual :
1. music app continues to play, video plays the sound as well.

Note:
I believe it has to do when the music switches to the next song that it over rides, because it kills the thread for the song and opens a new thread.

Comment 8

[Dietrich Ayala (:dietrich)]

Partner calling this a ship-blocker, blocking+ for now.

Alive, what's the ETA for a fix?

Comment 9

[(inactive after 6/18) Alive Kuo [:alive]]

(In reply to Dietrich Ayala (:dietrich) from comment #8)
> Partner calling this a ship-blocker, blocking+ for now.
> 
> Alive, what's the ETA for a fix?

Very quick fix If this is not a platform issue. But #7 sounds another issue different from original one.

Comment 10

[Marco Chen [:mchen]]

Attachment: Patch for comment 7 v1

This is in order to solve the issue from comment 7.

Root cause:
  If the music player try to play the next song in the background, a new AudioChannelAgent will be created but not set visibility well actively in that time. And the initial state of visibility in AudioChannelAgent is visible so in this case it will use visible state to register into AudioChannelService.

Solution:
  When creating AudioChannelAgent, try to set up initial visibility state.

Comment 11

[(inactive after 6/18) Alive Kuo [:alive]]

I propose to open another bug for #7 and do review there.

Comment 12

[Marco Chen [:mchen]]

(In reply to Alive Kuo [:alive] from comment #11)
> I propose to open another bug for #7 and do review there.

As the suggestion, open bug 834146 based on comment 7.

Comment 13

[(inactive after 6/18) Alive Kuo [:alive]]

Attachment: https://github.com/mozilla-b2g/gaia/pull/7767

Patch v1:
Add content channel to video player.

Comment 14

[(inactive after 6/18) Alive Kuo [:alive]]

https://github.com/mozilla-b2g/gaia/commit/c92179a8788ddefb88316796730932042afd8428
Leave opened until tef? is set

Comment 15

[Askeing Yen[:askeing][:fyen]]

## Repro :
 1. Open Music app, play music.
 2. Open Gallery app, click the video, play it.
## Expected :
 1. music app stops, video plays.
## Actual :
 1. music app continues to play, video also plays.
## Note :
 If user click stop video in Gallery app, first time the music and video will stop at the same time.


## Repro :
 1. Open Music app, play music.
 2. Open Video app, click the video, play it.
 3. Stop video, switch to Music app, play music again.
 4. Switch to Video app, click the video, play it.
## Expected :
 1. music app stops, when video plays.
## Actual :
 1. In Repro step 4, music app continues to play, video also plays.


Gaia:     6c53dfd2e5d60393f6a57e9e1a4b5af6a3d6a783
Gecko:    http://hg.mozilla.org/releases/mozilla-b2g18/rev/2226f181c8c2
BuildID   20130126070202
Version   18.0

Doesn't work.

Comment 16

[Jason Smith [:jsmith]]

Please file a followup bug and link it as a dependency on the bug for the issue you hit. Avoid reopening - it makes tracking landings, blockers, etc a royal pain.

Comment 17

[Askeing Yen[:askeing][:fyen]]

It is the same bug as Description and Comment 7 said.
I just pasted the STR again.
It's not fixed yet.

Comment 18

[Jason Smith [:jsmith]]

(In reply to Askeing Yen[:askeing] from comment #17)
> It is the same bug as Description and Comment 7 said.
> I just pasted the STR again.
> It's not fixed yet.

Then file a followup and link it. Don't reopen again please - this is not how bugzilla workflow is tracked at Mozilla. RESOLVED FIXED --> REOPENED is really more for backouts.

Comment 19

[Inder]

Filed another bug for this issue: bug 835454
Since the same issue is still there not sure what this bug fixed. I am also seeing another issue with recording and music playback as described in bug 835454.

Alive, were you able to verify that the issue is fixed with your changes in comment 13?

Comment 20

[(inactive after 6/18) Alive Kuo [:alive]]

(In reply to Inder from comment #19)
> Filed another bug for this issue: bug 835454
> Since the same issue is still there not sure what this bug fixed. I am also
> seeing another issue with recording and music playback as described in bug
> 835454.
> 
> Alive, were you able to verify that the issue is fixed with your changes in
> comment 13?

I will take a look tomorrow.
Notice: change to this patch needs to do reset-gaia to clear the permission DB.

Comment 21

[Marco Chen [:mchen]]

Hi Alive,

It is an Gecko issue caused by bug 835454 and I will have a patch there.

Comment 22

[Lukas Blakk [:lsblakk] use ?needinfo]

Landed on mozilla-b2g18/gaia master prior to the 1/25 branching to mozilla-b2g18_v1_0_0/v1.0.0, updating status-b2g-v1.0.0 to fixed.

Comment 23

[Sam Shipley]

Issue no longer reproduces on the Unagi device
Build ID: 20130214070203
December 5th Kernel
Gaia: 6544fdb8dddc56f1aefe94482402488c89eeec49
Gecko http://hg.mozilla.org/releases/mozilla-b2g18_v1_0_1/rev/d1288313218e

Music stops while video camera is recording.