821768 - Sidebar hidden if Social is activated while an in-content tab is active

Status: RESOLVED DUPLICATE of bug 1058010

(Firefox Graveyard :: SocialAPI, defect)

Description

[Virgil Dicu [:virgil] [QA]]

Mozilla/5.0 (X11; Linux i686; rv:20.0) Gecko/20121214 Firefox/20.0

STR:
1. Enable Facebook messenger for Firefox: https://www.facebook.com/about/messenger-for-firefox
2. Select Tools - Facebook Messenger- Turn off Facebook messenger (Nightly item names, different item names in Beta 18)
3. Open Add-ons Manager
4. Select Tools - Facebook - Turn on Facebook Messenger

Actual result: Panel isn't enabled. 
Some Error console messages, but these are displayed when the panel is enabled as well: 

Error: WorkerAPI: topic doesn't have a handler: 'worker.connected'
Source File: resource://gre/modules/WorkerAPI.jsm
Line: 41


Error: Firefox can't establish a connection to the server at wss://orcart.facebook.com/websocket.
Source File: https://www.facebook.com/desktop/fbdesktop2/socialfox/fbworker.js.php
Line: 184

Comment 1

[Virgil Dicu [:virgil] [QA]]

Reproducible in 17 RC as well, so not a recent regression.

Comment 2

[u279076]

Some further details on what's happening...

1. Sign in to Facebook from www.facebook.com
2. Enable Facebook Messenger via https://www.facebook.com/about/messenger-for-firefox
> Sidebar and toolbar load
3. Disable Facebook Messenger via the Tools menu
4. Open the Addons Manager via the Tools menu
5. Enable the Facebook Messenger via the Tools menu
> Sidebar and toolbar are not loaded
6. Open a new tab to www.facebook.com
> Toolbar is loaded
7. Click the Provider button in the toolbar
> Show sidebar is unchecked
8. Click "Show Sidebar"
> Sidebar is loaded

I think the real bug here is that the sidebar is not automatically enabled if Social is activated while viewing an in-content page. Yes, we shouldn't see the toolbar or sidebar when on an in-content page, but switching back to a regular tab should show all Social elements.

Comment 3

[:Gavin Sharp [email: [e-mail]]]

(In reply to Virgil Dicu [:virgil] [QA] from comment #0)
> Error: WorkerAPI: topic doesn't have a handler: 'worker.connected'
> Source File: resource://gre/modules/WorkerAPI.jsm
> Line: 41

FWIW, this error is caused by a bug with Facebook's code, and isn't related to behavior in any way - you can just ignore it. We're trying to get them to fix it.

Comment 4

[:Gavin Sharp [email: [e-mail]]]

This is kind of the sidebar version of bug 807997. We should probably just remove the "disablechrome" check from SocialSidebar's "chromeless" getter too.

Comment 5

[Mark Hammond [:markh] [:mhammond]]

I think this will also be fixed by bug 821262.

Comment 6

[Shane Caraveo (:mixedpuppy)]

unable to repro