Closed Bug 823253 Opened 8 years ago Closed 8 years ago

Remove StageFright decoding blocklisting on Froyo, GB, HC

Categories

(Core :: Widget: Android, defect)

ARM
Android
defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla21

People

(Reporter: scoobidiver, Assigned: cajbir)

References

Details

Attachments

(4 files, 2 obsolete files)

Currently, the StageFright decoding is blocked on the Android API level lower than 14 but bug 787228, bug 805700, and bug 821160 allow the feature so it should be unblocked, maybe partially like in API level 15.
Is this happening sometime soon?
tracking-fennec: --- → ?
FWIW --- I just fail at being the single point of failure for all gfx/h264 blacklisting bugs. The most likely to be successful course of action that I can see here, is along the lines of:
 1. Bring this bug to Maire Reavy and/or Brad Lassey 's attention
 2. They then find someone from mobile or media teams to work on this
The gfx team is swamped at the moment with the layers refactoring.
(In reply to Benoit Jacob [:bjacob] from comment #2)
> FWIW --- I just fail at being the single point of failure for all gfx/h264
> blacklisting bugs. The most likely to be successful course of action that I
> can see here, is along the lines of:
>  1. Bring this bug to Maire Reavy and/or Brad Lassey 's attention
>  2. They then find someone from mobile or media teams to work on this
> The gfx team is swamped at the moment with the layers refactoring.

Chris, Anthony - I'm not sure if you or anyone in NZ has the time and are comfortable taking over the blacklisting code itself from bjacob.  If not, we can ask blassey if he has someone.  

All -- Regardless of who takes over for bjacob, I feel we need to target modifying the blacklist code to allow working GB and HC devices (which have been tested/verified by QA) before Firefox 21 uplifts to Aurora (in approximately 2 weeks -- Feb 18).
I'll take it.
Assignee: nobody → chris.double
(In reply to Maire Reavy [:mreavy] from comment #3)
> 
> All -- Regardless of who takes over for bjacob, I feel we need to target
> modifying the blacklist code to allow working GB and HC devices (which have
> been tested/verified by QA) before Firefox 21 uplifts to Aurora (in
> approximately 2 weeks -- Feb 18).

Which devices have been tested/verified by QA? In the absence of this information I'm modifying the code for the devices I've tested.
Attached patch White HTC Gingerbread devices (obsolete) — Splinter Review
Attachment #714220 - Flags: review?(bjacob)
Comment on attachment 714220 [details] [diff] [review]
White HTC Gingerbread devices

Oops, got the versions wrong. Will upload new one shortly.
Attachment #714220 - Flags: review?(bjacob)
Attachment #714220 - Attachment is obsolete: true
Attachment #714225 - Flags: review?(bjacob)
Attachment #714242 - Flags: review?(bjacob)
Attachment #714252 - Flags: review?(bjacob)
Fix error where I was including the Froyo version range.
Attachment #714242 - Attachment is obsolete: true
Attachment #714242 - Flags: review?(bjacob)
Attachment #714254 - Flags: review?(bjacob)
Attachment #714256 - Flags: review?(bjacob)
Attachment #714225 - Flags: review?(bjacob) → review+
Attachment #714256 - Flags: review?(bjacob) → review+
Attachment #714252 - Flags: review?(bjacob) → review+
Attachment #714254 - Flags: review?(bjacob) → review+
Status: NEW → ASSIGNED
I've updated https://wiki.mozilla.org/Blocklisting/Blocked_Graphics_Drivers#On_Android_2 accordingly (that should have been done by the assignee).

Are there both StafeFright HW and SW decoding on those Android versions or only HW decoding?
(In reply to Scoobidiver from comment #15)
> I've updated
> https://wiki.mozilla.org/Blocklisting/Blocked_Graphics_Drivers#On_Android_2
> accordingly (that should have been done by the assignee).

The assignee didn't even know it existed, but thanks for pointing it out.

> Are there both StafeFright HW and SW decoding on those Android versions or
> only HW decoding?

It depends. Some devices are HW only (some Froyo devices), others are HW and SW. I'm sure there are SW only ones out there too. Our implementation picks whatever the device can do.
Did this need to land on mozilla-aurora/mozilla-beta?
(In reply to Aaron Train [:aaronmt] from comment #17)
> Did this need to land on mozilla-aurora/mozilla-beta?

I would suggest uplifting to aurora.
Depends on: 847837
Depends on: 859032
Depends on: 864734
Depends on: 874810
tracking-fennec: ? → ---
You need to log in before you can comment on or make changes to this bug.