823253 - Remove StageFright decoding blocklisting on Froyo, GB, HC

Status: RESOLVED FIXED

(Core Graveyard :: Widget: Android, defect)

Description

[Scoobidiver (away)]

Currently, the StageFright decoding is blocked on the Android API level lower than 14 but bug 787228, bug 805700, and bug 821160 allow the feature so it should be unblocked, maybe partially like in API level 15.

Comment 1

[Aaron Train [:aaronmt]]

Is this happening sometime soon?

Comment 2

[Benoit Jacob [:bjacob] (mostly away)]

FWIW --- I just fail at being the single point of failure for all gfx/h264 blacklisting bugs. The most likely to be successful course of action that I can see here, is along the lines of:
 1. Bring this bug to Maire Reavy and/or Brad Lassey 's attention
 2. They then find someone from mobile or media teams to work on this
The gfx team is swamped at the moment with the layers refactoring.

Comment 3

[Maire Reavy [:mreavy]]

(In reply to Benoit Jacob [:bjacob] from comment #2)
> FWIW --- I just fail at being the single point of failure for all gfx/h264
> blacklisting bugs. The most likely to be successful course of action that I
> can see here, is along the lines of:
>  1. Bring this bug to Maire Reavy and/or Brad Lassey 's attention
>  2. They then find someone from mobile or media teams to work on this
> The gfx team is swamped at the moment with the layers refactoring.

Chris, Anthony - I'm not sure if you or anyone in NZ has the time and are comfortable taking over the blacklisting code itself from bjacob.  If not, we can ask blassey if he has someone.  

All -- Regardless of who takes over for bjacob, I feel we need to target modifying the blacklist code to allow working GB and HC devices (which have been tested/verified by QA) before Firefox 21 uplifts to Aurora (in approximately 2 weeks -- Feb 18).

Comment 4

[cajbir (:cajbir)]

I'll take it.

Comment 5

[cajbir (:cajbir)]

(In reply to Maire Reavy [:mreavy] from comment #3)
> 
> All -- Regardless of who takes over for bjacob, I feel we need to target
> modifying the blacklist code to allow working GB and HC devices (which have
> been tested/verified by QA) before Firefox 21 uplifts to Aurora (in
> approximately 2 weeks -- Feb 18).

Which devices have been tested/verified by QA? In the absence of this information I'm modifying the code for the devices I've tested.

Comment 6

[cajbir (:cajbir)]

Attachment: White HTC Gingerbread devices

Comment 7

[cajbir (:cajbir)]

Comment on attachment 714220 [details] [diff] [review]
White HTC Gingerbread devices

Oops, got the versions wrong. Will upload new one shortly.

Comment 8

[cajbir (:cajbir)]

Attachment: Part 1: Whitelist HTC Gingerbread devices

Comment 9

[cajbir (:cajbir)]

Attachment: Part 2: Whitelist LG Froyo devices

Comment 10

[cajbir (:cajbir)]

Attachment: Part 3: Whitelist Samsung Gingerbread devices

Comment 11

[cajbir (:cajbir)]

Attachment: Part 2: Whitelist LG Froyo devices

Fix error where I was including the Froyo version range.

Comment 12

[cajbir (:cajbir)]

Attachment: Part 4: Whitelist Samsung Honeycomb devices

Comment 13

[cajbir (:cajbir)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/cef45c1cb7d4
https://hg.mozilla.org/integration/mozilla-inbound/rev/50dc45f30b22
https://hg.mozilla.org/integration/mozilla-inbound/rev/d5cb684d6b76
https://hg.mozilla.org/integration/mozilla-inbound/rev/8a5523cc2812

Comment 14

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

https://hg.mozilla.org/mozilla-central/rev/cef45c1cb7d4
https://hg.mozilla.org/mozilla-central/rev/50dc45f30b22
https://hg.mozilla.org/mozilla-central/rev/d5cb684d6b76
https://hg.mozilla.org/mozilla-central/rev/8a5523cc2812

Please be more careful with bug numbers...

Comment 15

[Scoobidiver (away)]

I've updated https://wiki.mozilla.org/Blocklisting/Blocked_Graphics_Drivers#On_Android_2 accordingly (that should have been done by the assignee).

Are there both StafeFright HW and SW decoding on those Android versions or only HW decoding?

Comment 16

[cajbir (:cajbir)]

(In reply to Scoobidiver from comment #15)
> I've updated
> https://wiki.mozilla.org/Blocklisting/Blocked_Graphics_Drivers#On_Android_2
> accordingly (that should have been done by the assignee).

The assignee didn't even know it existed, but thanks for pointing it out.

> Are there both StafeFright HW and SW decoding on those Android versions or
> only HW decoding?

It depends. Some devices are HW only (some Froyo devices), others are HW and SW. I'm sure there are SW only ones out there too. Our implementation picks whatever the device can do.

Comment 17

[Aaron Train [:aaronmt]]

Did this need to land on mozilla-aurora/mozilla-beta?

Comment 18

[Brad Lassey [:blassey] (use needinfo?)]

(In reply to Aaron Train [:aaronmt] from comment #17)
> Did this need to land on mozilla-aurora/mozilla-beta?

I would suggest uplifting to aurora.