864734 - crash in mozilla::ReentrantMonitorAutoEnter::~ReentrantMonitorAutoEnter @ libstagefright.so@0xf... on Samsung devices running Gingerbread

Status: RESOLVED INCOMPLETE

(Core :: Audio/Video: Playback, defect)

Description

[Scoobidiver (away)]

With combined signatures, it's #9 top crasher in 21.0b3 and #15 in 22.0a2.

The affected devices for the last day are (min 2 crashes):
* libstagefright.so@0xf9148 	13
Samsung SCH-I405 	13
* libstagefright.so@0xf9418 	11
Samsung SCH-S720C 	11
* libstagefright.so@0xf93e0 	10
Samsung SCH-I510 	10
* libstagefright.so@0xfae68 	4
Samsung SGH-S959G 	4
* libstagefright.so@0xfae80 	3
Samsung SCH-R760 	3
libstagefright.so@0xf49f0 	2
Samsung GT-I9000 	2
* libstagefright.so@0xf4a00 	2
Samsung GT-I9000 	2

Signature 	libstagefright.so@0xf9148 More Reports Search
UUID	0fa370b7-79e8-45ea-8aeb-c1d722130423
Date Processed	2013-04-23 02:23:55
Uptime	67
Install Age	2.1 minutes since version was first installed.
Install Time	2013-04-23 02:21:30
Product	FennecAndroid
Version	21.0
Build ID	20130416195807
Release Channel	beta
OS	Android
OS Version	0.0.0 Linux 2.6.35.7-FF1 #2 PREEMPT Wed Jul 18 21:01:10 KST 2012 armv7l verizon/SCH-I405/SCH-I405:2.3.6/GINGERBREAD/FF1:user/release-keys
Build Architecture	arm
Build Architecture Info	
Crash Reason	SIGSEGV
Crash Address	0x0
App Notes 	
AdapterDescription: 'Imagination Technologies -- PowerVR SGX 540 -- OpenGL ES 2.0 -- Model: SCH-I405, Product: SCH-I405, Manufacturer: samsung, Hardware: smdkc110'
EGL? EGL+ GL Context? GL Context+ GL Layers? GL Layers+ Stagefright? Stagefright+ 
samsung SCH-I405
verizon/SCH-I405/SCH-I405:2.3.6/GINGERBREAD/FF1:user/release-keys
Processor Notes 	sp-processor09.phx1.mozilla.com_22578:2012; non-integer value of "SecondsSinceLastCrash"; exploitability tool failed: 127
EMCheckCompatibility	True
Adapter Vendor ID	Imagination Technologies
Adapter Device ID	PowerVR SGX 540
Device	samsung SCH-I405
Android API Version	10 (REL)
Android CPU ABI	armeabi-v7a

Frame 	Module 	Signature 	Source
0 	libstagefright.so 	libstagefright.so@0xf9148 	
1 	libnspr4.so 	PR_ExitMonitor 	nsprpub/pr/src/pthreads/ptsynch.c:557
2 	libxul.so 	mozilla::ReentrantMonitorAutoEnter::~ReentrantMonitorAutoEnter 	obj-firefox/dist/include/mozilla/ReentrantMonitor.h:80
3 	libxul.so 	mozilla::MediaCacheStream::Seek 	content/media/MediaCache.cpp:2058
4 	libstagefright.so 	libstagefright.so@0x169a1a 	
5 	libstagefright.so 	libstagefright.so@0x169a1a 	
6 	libstagefright.so 	libstagefright.so@0xf54ad 	
7 	libstagefright.so 	libstagefright.so@0x169a1a 	
8 	libomxplugingb.so 	android::MediaStreamSource::initCheck const 	media/omx-plugin/OmxPlugin.cpp:84
9 	libstagefright.so 	libstagefright.so@0x169a1a 	
10 	libstagefright.so 	libstagefright.so@0x54bfb 	
11 	libstagefright.so 	libstagefright.so@0x1681be 	
12 	libstagefright.so 	libstagefright.so@0xf5473 	
13 	libstagefright.so 	libstagefright.so@0x50095 	
14 	libstagefright.so 	libstagefright.so@0x170236 	
15 	libutils.so 	_ZN7android6LooperC2Eb 	
16 	libstagefright.so 	libstagefright.so@0x169a1a 	
17 	libstagefright.so 	libstagefright.so@0x5c0bb 	
18 	libxul.so 	mozilla::MediaCacheStream::SetReadMode 	content/media/MediaCache.cpp:2013
19 	libomxplugingb.so 	OmxPlugin::OmxDecoder::Init 	media/omx-plugin/OmxPlugin.cpp:370

More reports at:
https://crash-stats.mozilla.com/query/query?product=FennecAndroid&query_search=signature&query_type=contains&query=libstagefright.so%400xf&do_query=1

Comment 1

[bhavana bajaj [:bajaj]]

Passing this onto chris, to help with the needed blocklist here as it looks like we had whitelisted all the Samsung Gingerbread devices for Stagefright decoding in 823253.

Chris, can we please get the blocklist landed here at the earliest to help with this top-crasher ?

Comment 2

[Naoki Hirata :nhirata (please use needinfo instead of cc)]

https://crash-stats.mozilla.com/query/query?product=FennecAndroid&version=ALL%3AALL&range_value=1&range_unit=weeks&date=04%2F26%2F2013+17%3A16%3A02&query_search=signature&query_type=contains&query=mozilla%3A%3AReentrantMonitorAutoEnter&reason=&build_id=&process_type=any&hang_type=any&do_query=1

Not sure if this is a top crash anymore.  Leaving as is though.

Comment 3

[Scoobidiver (away)]

The PR_ExitMonitor | mozilla::ReentrantMonitorAutoEnter::~ReentrantMonitorAutoEnter signature is on JB and without any Stagefright frames so unrelated to these crashes.

(In reply to Naoki Hirata :nhirata (please use needinfo instead of cc) from comment #2)
> Not sure if this is a top crash anymore.  Leaving as is though.
There are currently 251 crashes in 21.0b3 and 24 in 21.0b4 so it's #8 top crasher in 21.0b3 and #4 in 21.0b4.

Comment 4

[cajbir (:cajbir)]

Attachment: Blocklist devices

I think this gets all the devices in the crash reports. Scoobidiver, can you check if any are missing? I note the bug title says Gingerbread but the devices actually range from GB->HC->ICS->JB 4.1->JB 4.2.

Comment 5

[Scoobidiver (away)]

(In reply to Chris Double (:doublec) from comment #4)
> Scoobidiver, can you check if any are missing?
There are too many.
On Gingerbread, affected HW is only (manual checking):
smdkc110, smdkc210, herring, shw-m110s, shw-m180s, n1, latona, aalto, atlas, qcom
The qcom blocklist will help fix bug 847837 not fully fixed by the current blocklist based on models.
On other Android versions, no blocklist is required for this bug. See below.

> I note the bug title says Gingerbread but the devices actually range from
> GB->HC->ICS->JB 4.1->JB 4.2.
In 20.0.1 and below, crashes with signatures starting with libstagefright.so@0xf are bug 802620 which is a low volume crash, #109 crasher in 20.0.1, so not requiring a blocklist.
In 21.0 Beta and above (see https://crash-stats.mozilla.com/query/query?product=FennecAndroid&version=FennecAndroid%3A23.0a1&version=FennecAndroid%3A22.0a2&version=FennecAndroid%3A21.0b4&version=FennecAndroid%3A21.0b3&version=FennecAndroid%3A21.0b2&version=FennecAndroid%3A21.0b1&range_value=4&range_unit=weeks&query_search=signature&query_type=contains&query=libstagefright.so%400xf&do_query=1), only Gingerbread is affected except for libstagefright.so@0xf1219 and other low volume crashes which have a different stack trace and don't belong to this bug.

Comment 6

[cajbir (:cajbir)]

Scoobidiver, are you going to expand on the feedback-?

Comment 7

[cajbir (:cajbir)]

Oh you did, missed that. Ok I'm confused. Someone please provide an exact list of devices and android versions required to fix this bug. I won't be doing anything until that is provided.

Comment 8

[cajbir (:cajbir)]

As per comment 7.

Comment 9

[Scoobidiver (away)]

(In reply to Chris Double (:doublec) from comment #7)
> Someone please provide an exact list of devices and android versions required to fix
> this bug.
Per comment 5:
Gingerbread: smdkc110, smdkc210, herring, shw-m110s, shw-m180s, n1, latona, aalto, atlas, qcom
Honeycomb: nothing
ICS: nothing
JB: nothing

Comment 10

[cajbir (:cajbir)]

Attachment: Blocklist scoobi devices

Comment 11

[Benoit Jacob [:bjacob] (mostly away)]

Comment on attachment 743289 [details] [diff] [review]
Blocklist scoobi devices

Review of attachment 743289 [details] [diff] [review]:
-----------------------------------------------------------------

::: widget/android/GfxInfo.cpp
@@ +406,5 @@
>          {
>            isWhitelisted = false;
>          }
>  
> +        if (cHardware.Equals("smdkc110", nsCaseInsensitiveCStringComparator()) ||

You could merge that into the previous if(). Up to you. If you don't, maybe add a quick comment as to why.

Comment 12

[cajbir (:cajbir)]

Attachment: Block devices

Address review comment, carry forward r+

Comment 13

[cajbir (:cajbir)]

Comment on attachment 743302 [details] [diff] [review]
Block devices

[Approval Request Comment]
Bug caused by (feature/regressing bug #): Enabling of gingerbread devices
User impact if declined: Some gingerbread devices will crash when playing video
Testing completed (on m-c, etc.): Unable to test due to no hardware
Risk to taking this patch (and alternatives if risky): Some devices that do not crash may not play video
String or IDL/UUID changes made by this patch: None

Comment 14

[cajbir (:cajbir)]

Comment on attachment 743302 [details] [diff] [review]
Block devices

[Approval Request Comment]
Bug caused by (feature/regressing bug #): Enabling of gingerbread devices
User impact if declined: Some gingerbread devices will crash when playing video
Testing completed (on m-c, etc.): Unable to test due to no hardware
Risk to taking this patch (and alternatives if risky): Some devices that do not crash may not play video
String or IDL/UUID changes made by this patch: None

Comment 15

[bhavana bajaj [:bajaj]]

Chris, I think this needs to land on m-c too , unless you are planning on landing the fwd fix there instead of blocklist ?

Comment 16

[bhavana bajaj [:bajaj]]

Spoke on irc with Chris & he will be landing this on m-c soon . I am already approving this so that it can land on branches in parallel given the timeline for our Fx21 beta5, going to build tomorrow.

Hence the pre-approval on branches here.

Comment 17

[bhavana bajaj [:bajaj]]

Comment on attachment 743302 [details] [diff] [review]
Block devices

Please make sure to land before Tuesday noon PT to get this into our second last beta which is when we will be going to build for our next beta.

Comment 18

[cajbir (:cajbir)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/9018a6a45065

Comment 19

[cajbir (:cajbir)]

https://hg.mozilla.org/releases/mozilla-aurora/rev/755dc68138b6

Comment 20

[cajbir (:cajbir)]

https://hg.mozilla.org/releases/mozilla-beta/rev/be6b75ee328c

Comment 21

[Scoobidiver (away)]

I've updated https://wiki.mozilla.org/Blocklisting/Blocked_Graphics_Drivers#On_Android_2 accordingly.

Comment 22

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/9018a6a45065

Comment 23

[Scoobidiver (away)]

There are eight crashes in 21.0b6.

Comment 24

[u597032]

Gingerbread is no longer supported.